Received: by 2002:a25:ef43:0:0:0:0:0 with SMTP id w3csp175076ybm; Wed, 27 May 2020 23:16:11 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyKW7kJy4PcF708GoLHxS3IOlchxvyTAJ0PtQVI5Xhl2Ep33Cja/dVjoWxlV4+bb2AvbEZ5 X-Received: by 2002:a17:907:b11:: with SMTP id h17mr1614730ejl.497.1590646571355; Wed, 27 May 2020 23:16:11 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1590646571; cv=none; d=google.com; s=arc-20160816; b=y2KSvqISK3t+xQ71g4MB7WRQKykdHYn6wEF/VgAR/BlX74AbjOniWD/hyiAj1nOilR Gt/UfWbhmAELd+s3TDQliNXykNoiPi6PbXfU4++KQqt//XEFys5a+J/s5LVSYXG9e3rl 3Rw0RtmLIsqOeIJD8WkVdc91JF65xph5CQ+mpiaGkcaEM6sL3i5DNg5KXmFZEF1kEqI6 53D3ktcC6Uo9aIJYRWFWt/+72Vc9RUrTqA2MWdlnihoJA3VhHoeK6YdR/n4PZRcSOOCV 2NlahKyeBP4R3VvXH+fljQ/7JPn7uHUCdVdFD/gXZHQtIvicfIJtd2+SISNEIBL77Ixt sSbg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=zni0B8k5iMx2062s+cLkcal1ezBX/6+aSXESnytrVBA=; b=nezmiARTPEQBBP+g59CRBTvhti5rFCkwrHe7ZLFV+yi9nyoSm+ZA0t+pnR0+C33HZO NASBfIENNI99RtDeUDiga8oR++I+ITHYo886HxIHvTcgZvTCX813bhetnphAjoy+HCL2 KHv4Vlp3uU9gPAGMPQVb0ecCxhscTIZZMNiMoycEXHD9u0VSQYPCL+8Wk6zOY3tQSPCp BRc01uPF+058Mnr5qgucvZ0aCtHRUMMCTZhuzzMLkYqILmd4m599CL0iqMj0cFA75yJS kEegvD+n1sflO/9jd3V2oraacAE5IlczNNfIReWkqXnTEh26UxztcXofBaXt/FNBYOdO hKWQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=n6L4oCgg; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id n1si2958811edy.216.2020.05.27.23.15.48; Wed, 27 May 2020 23:16:11 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=n6L4oCgg; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727084AbgE1GOA (ORCPT + 99 others); Thu, 28 May 2020 02:14:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49806 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725859AbgE1GOA (ORCPT ); Thu, 28 May 2020 02:14:00 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DC1D2C05BD1E for ; Wed, 27 May 2020 23:13:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=zni0B8k5iMx2062s+cLkcal1ezBX/6+aSXESnytrVBA=; b=n6L4oCgg5qx1q88mtA0neKBlJH VH5WkwsKABSpxb2nXXripcejQz22sXvL/OXW6RXPrCwIl3MJy9Z0HTPAP2asJIv+VT3HxqDGr6Qtj Db/jZtyXSdRaq03bWrdWmluP1qui019NEK5NZkiRVdb6cNJNj85irS1+kavTyvaJ3gwBTlAAShxgF 6jcnT1yUoRPamgODIO4mqAstUWV9KEQzTDTcyuAukl73XzsP2imQk1CtHPU8waqlwRAPN6V8CP717 A1wABNoblFdvkivbGnODWd7/NBuXGGgYsjNhvA4Qmt3/7dasgoJfiboIkWqXJ2iSsbO87fAqkCStm SIyURPEA==; Received: from hch by bombadil.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1jeBnd-0007EK-9j; Thu, 28 May 2020 06:13:53 +0000 Date: Wed, 27 May 2020 23:13:53 -0700 From: Christoph Hellwig To: Joerg Roedel Cc: iommu@lists.linux-foundation.org, jroedel@suse.de, linux-kernel@vger.kernel.org Subject: Re: [PATCH 02/10] iommu/amd: Unexport get_dev_data() Message-ID: <20200528061353.GA17035@infradead.org> References: <20200527115313.7426-1-joro@8bytes.org> <20200527115313.7426-3-joro@8bytes.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200527115313.7426-3-joro@8bytes.org> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 27, 2020 at 01:53:05PM +0200, Joerg Roedel wrote: > From: Joerg Roedel > > This function is internal to the AMD IOMMU driver and only exported > because the amd_iommu_v2 modules calls it. But the reason it is called > from there could better be handled by amd_iommu_is_attach_deferred(). > So unexport get_dev_data() and use amd_iommu_is_attach_deferred() > instead. Btw, what is the reason amd_iommu_v2 is a separate module? It is very little code, and other drivers seem to just integrate such functionality.