Received: by 2002:a25:ef43:0:0:0:0:0 with SMTP id w3csp301174ybm; Thu, 28 May 2020 03:09:16 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzCwSbocBqNVUvujZpfr+CA09mkMDrWyu4gHjJScBQ1KNDw5p1Dnf98PaKTtyaV+GCwIl09 X-Received: by 2002:a17:906:4815:: with SMTP id w21mr2364339ejq.533.1590660556638; Thu, 28 May 2020 03:09:16 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1590660556; cv=none; d=google.com; s=arc-20160816; b=PsjaSIPpPpEJDBQEuoXEGFO2kjZ8lgXtcel0SsxJMEM/qblVWQEjASE6ZhNq/+pyZX SPivqOBO1fRWeyWi3FJCTE9t7h3rh8QVGHjXOUsGm+tkBBrjrgijZ7eu6MEzlJAXRh+A vOA9+RNrl5E7xFC5H9UZ1ij3dmc7muSOZ+AgxUhpC5ZzAsDqABlPJxheUon4p7XS24WW r/be/ncatpnmLCFjbuYWTlwc1u15Jyw+yrFdkYCgrje8yw4FCU6B7kJ1DGdfR8Q7rmY3 xHV+COpR9Za4qjIRwzfnPEKJjEkzLZb15M4NOjfKy6guyUyDgsIAhrOvez5A8/jPCMfT Vh8w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=/KSuSX3QihRtC4WO/4NLERdREBLmtzhRjH7jJcqHAXA=; b=Gh/1gN6/8F8+S09Fdn17K7CXk9L/TxfIRaaliMtpKptCOWcO5penNX61cTT2dQo5+O zDCBZGJmHGrYPMl61NM1U6R3WYpd/Ugfb2VNLm80fVHWzrpX1oYpspWm0hZ3tTofHZay /Dm4ZIrWLKjrkXWr9aE7oUfv++ayuutRMjZ0Yy2hH3M/y/dQN/34jj3UmEqN2q47s90y fRVsHCP8VG9De7zW+jIiNh99zYV/UvOooek/jgbdtE3rHnqAUk4iMZQQpvrQyybGZA4r OYEA1aBrQ3xWhi3PPtqEPTVIOZwlEI/vAqf8ndfPOKnUt2qoOVEJs6WNd7iV5RxBjmrb pxCw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2020-01-29 header.b=MHJDaRqi; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id j21si3398183ejm.613.2020.05.28.03.08.53; Thu, 28 May 2020 03:09:16 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2020-01-29 header.b=MHJDaRqi; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387685AbgE1KEw (ORCPT + 99 others); Thu, 28 May 2020 06:04:52 -0400 Received: from userp2130.oracle.com ([156.151.31.86]:41738 "EHLO userp2130.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387597AbgE1KEw (ORCPT ); Thu, 28 May 2020 06:04:52 -0400 Received: from pps.filterd (userp2130.oracle.com [127.0.0.1]) by userp2130.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 04S9tPjX085670; Thu, 28 May 2020 10:04:47 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=corp-2020-01-29; bh=/KSuSX3QihRtC4WO/4NLERdREBLmtzhRjH7jJcqHAXA=; b=MHJDaRqi6IPK7bv/ILFZfjgfKp8q9mql065vuZsJCV/Gg0oVJlni1+bmyM2WHFOENOWg B4xFW0f0HcWhqL8EcpEbqKtG/51Wv6QAbIwVTdT70CrONPpB4Y7vsXHvhr6w+auLmLLW pvj1Uh/WQBhw9minbKjAdiDXZ9JHv1b3xy5ci7JHbJuCII+CZZYp3rmJ6tKlNqMYXhYW ftn0QXzSNuiaJx0Rq1M7inongrf31+Ra4B4+FdeslJsCcgdXmX9kYnxdpusTo0GTkzpt d86IDObYl3dHV2kjy/7pnf8N9qzVikSgdmU4IoHsYS/3mW8yCLjhuU95sFAoFOjVxXKn ig== Received: from userp3030.oracle.com (userp3030.oracle.com [156.151.31.80]) by userp2130.oracle.com with ESMTP id 316u8r44gs-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Thu, 28 May 2020 10:04:47 +0000 Received: from pps.filterd (userp3030.oracle.com [127.0.0.1]) by userp3030.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 04S9mvTn052896; Thu, 28 May 2020 10:04:46 GMT Received: from aserv0121.oracle.com (aserv0121.oracle.com [141.146.126.235]) by userp3030.oracle.com with ESMTP id 317ds28hyp-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 28 May 2020 10:04:46 +0000 Received: from abhmp0019.oracle.com (abhmp0019.oracle.com [141.146.116.25]) by aserv0121.oracle.com (8.14.4/8.13.8) with ESMTP id 04SA4iZk019698; Thu, 28 May 2020 10:04:44 GMT Received: from kadam (/41.57.98.10) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Thu, 28 May 2020 03:04:44 -0700 Date: Thu, 28 May 2020 13:04:38 +0300 From: Dan Carpenter To: Pascal Terjan Cc: Greg Kroah-Hartman , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] staging: rtl8723bs: Use common packet header constants Message-ID: <20200528100438.GI30374@kadam> References: <20200527194811.GF30374@kadam> <20200527205100.35794-1-pterjan@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200527205100.35794-1-pterjan@google.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9634 signatures=668686 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 phishscore=0 malwarescore=0 mlxlogscore=999 adultscore=0 suspectscore=0 bulkscore=0 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2004280000 definitions=main-2005280066 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9634 signatures=668686 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 mlxscore=0 priorityscore=1501 spamscore=0 cotscore=-2147483648 suspectscore=0 phishscore=0 clxscore=1015 mlxlogscore=999 bulkscore=0 adultscore=0 lowpriorityscore=0 impostorscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2004280000 definitions=main-2005280066 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 27, 2020 at 09:51:00PM +0100, Pascal Terjan wrote: > This driver contains a local version of the rfc1042 header and bridge > tunnel header constants which are available from cfg80211.h, switch to > those. > > Signed-off-by: Pascal Terjan > --- > v2: improve description and drop confusing cosmetic changes Perfect! Thanks. Reviewed-by: Dan Carpenter regards, dan carpenter