Received: by 2002:a25:ef43:0:0:0:0:0 with SMTP id w3csp303429ybm; Thu, 28 May 2020 03:12:41 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxzmgjZB4tmpxnWq1UPLTG55E57PurL/qxeIQabZ6Q9IO/HQz4V9HiKc2BXbeH/pHeoFOJ1 X-Received: by 2002:aa7:d1c6:: with SMTP id g6mr2275241edp.303.1590660761549; Thu, 28 May 2020 03:12:41 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1590660761; cv=none; d=google.com; s=arc-20160816; b=o52mmh5JawWiY3ALKghkxPyg4l08KXDcW9ANfRFmjfqyXzY0uTJm1o8LNwHwy3yM+c RXQ2pJBGHhB921wN3a1FuAjr1yHxjW7Y9o7T/RaDwWBhy890tSS50Q3K8R2O/4sb/MQZ S/iz4nqG86QNWNrU2ebsRmcZ6DoHwLStnSy+bn4pgCg8WJvwG+s2Y+SucJrjZrW63GQi CcrfSXp/Hcg198wrHhUQzWU4/uWPbQV4CheIvitszFvA8h5ssLt//TzvtaADAq4OZ4eT h19I1w7TESvznz6Sta49UqhEHgy82PM2f7nShmNY6ZOwIxzXbFDrCgmwNEscRLR7jRLk ZQlg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:organization:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:ironport-sdr:ironport-sdr; bh=IibakVaXT2I/CCx2egcmqeuxTAplnbSb/ZdruZIXslM=; b=W6HCy52nDM427cZmYxRwGniy4tysaqnFAW5fIDdLh3k51CQKEdAHwe6VMsyv8TAz0Y 3FWDtun0141ODsYBPP49rcfN6231sXI8C5sI0VwUP4LUNEUB/khKmtEocv5NIzdqN0ji VkJvqfbVNCVuOD11cCqXYMZyyhz16Rr+2LW2w2nUOKe8rjj97TUcMnLSnAj/3DMEFpkP tIfdIzxKW2Q2QAErRm8xdVto7U094a2JMA1nwVrWdYx+TKcij7RRMdmlYJ2NAgN/39ak 66BlTXuKsdx3ikwrq1+G8AFvifc1HUHwoC69rQGf6NhrnICftAE1M+uIDKfLuwUT0+7p b96A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id s14si3786761ejq.37.2020.05.28.03.12.18; Thu, 28 May 2020 03:12:41 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387727AbgE1KIJ (ORCPT + 99 others); Thu, 28 May 2020 06:08:09 -0400 Received: from mga18.intel.com ([134.134.136.126]:46347 "EHLO mga18.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387624AbgE1KII (ORCPT ); Thu, 28 May 2020 06:08:08 -0400 IronPort-SDR: yj9bYpMAfDabcsP635o9OgsE5VR0GDN17cCJ6pnzS37FsHWJ9mdJDJwbe49DlbfY9D2MTdNj/m Vuu+HJKS8PgA== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 May 2020 03:08:07 -0700 IronPort-SDR: f0QxIkCXMLpT7uPGwjlQr/w3sy+LgAkB6jAzbE0bp7IxkzPCC4JoUQbaRhXNnXItyFYmyzVX9o 8W4eyG73WF9g== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,444,1583222400"; d="scan'208";a="345862249" Received: from smile.fi.intel.com (HELO smile) ([10.237.68.40]) by orsmga001.jf.intel.com with ESMTP; 28 May 2020 03:08:05 -0700 Received: from andy by smile with local (Exim 4.93) (envelope-from ) id 1jeFSK-009PCc-Aq; Thu, 28 May 2020 13:08:08 +0300 Date: Thu, 28 May 2020 13:08:08 +0300 From: Andy Shevchenko To: Michael Walle Cc: Pierre-Louis Bossart , Linux Kernel Mailing List , "open list:GPIO SUBSYSTEM" , Linus Walleij , Bartosz Golaszewski , Mark Brown Subject: Re: [PATCH v4 2/2] gpio: add a reusable generic gpio_chip using regmap Message-ID: <20200528100808.GI1634618@smile.fi.intel.com> References: <20200525160741.21729-1-michael@walle.cc> <20200525160741.21729-3-michael@walle.cc> <6d08ebbfbc9f656cb5650ede988cf36d@walle.cc> <143ec2f44c881706db9744465328329f@walle.cc> <0d4bce3de91df9526ada76f4f2347d25@walle.cc> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <0d4bce3de91df9526ada76f4f2347d25@walle.cc> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, May 28, 2020 at 10:46:56AM +0200, Michael Walle wrote: > Am 2020-05-28 10:37, schrieb Andy Shevchenko: > > On Thu, May 28, 2020 at 7:11 AM Michael Walle wrote: > > > Am 2020-05-28 02:31, schrieb Pierre-Louis Bossart: > > > > > > > I've send a v5 with that fix and your names property. > > > > Did you already? > > Yes, I forgot to add you :( > > > Because I have a question why we have gpio-regmap.h instead of > > gpio/regmap.h ? > > No particular reason, I thought gpio/ was for low level gpio stuff (like > the consumer.h, driver.h etc) or lets say - more integrated stuff. > > I don't have a strong opinion. I can send a v6 with that change, on > short notice if the maintainers prefer that location. I guess it's quite close to core and belongs to GPIO family of headers, I definitely would like to see it there, but let's wait for Linus and Bart to speak up. -- With Best Regards, Andy Shevchenko