Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <6eb98232-bc84-0854-243a-e54b91f2bda6@web.de>
In-Reply-To: <6eb98232-bc84-0854-243a-e54b91f2bda6@web.de>
From:   Chuhong Yuan <hslester96@gmail.com>
Date:   Thu, 28 May 2020 18:21:29 +0800
Message-ID: <CANhBUQ0_do+=MZsj0NKEfAAVeuWy8V+hvQuVBBB2o+u+H9s1qA@mail.gmail.com>
Subject: Re: [PATCH] rtc: rv3028: Add missed check for devm_regmap_init_i2c()
To:     Markus Elfring <Markus.Elfring@web.de>
Cc:     linux-rtc@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
        Alexandre Belloni <alexandre.belloni@bootlin.com>,
        Alessandro Zummo <a.zummo@towertech.it>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Thu, May 28, 2020 at 5:17 PM Markus Elfring <Markus.Elfring@web.de> wrot=
e:
>
> > rv3028_probe() misses a check for devm_regmap_init_i2c().
>
> Such information is helpful.
>
>
> > Add the missed check
>
> Thanks for another completion of the exception handling.
>
>
> >                      to fix it.
>
> I suggest to replace this wording by the tag =E2=80=9CFixes=E2=80=9D for =
the commit message.
> How do you think about to take this possibility into account
> for any more patches?
>

I got it. I have added fixes tags in my newly sent patches.

Regards,
Chuhong

> Regards,
> Markus