Received: by 2002:a25:ef43:0:0:0:0:0 with SMTP id w3csp320490ybm; Thu, 28 May 2020 03:43:00 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyPT6l8PLWKIvz3J9+XcFTRzPsuROeRaeBQgnmhDIS4CjoEXYRrUW14vYY8N2255YIpr0p6 X-Received: by 2002:a17:906:5f87:: with SMTP id a7mr2376722eju.70.1590662580493; Thu, 28 May 2020 03:43:00 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1590662580; cv=none; d=google.com; s=arc-20160816; b=IRTv+OQm2MN8rJ4dt5QRrTpzaLvDfwJYWshF+K+qwg6ydxot6hSciwOgKDS9yoOcB5 wjBVPTqrr7u+snTRdi9HhWNs+4cVNTCAocw5e2zgtoVaw192P0f29YwsgUtRnlvNBnFI hab4kWMMEs4rc2wr358BHT0wMmpz/oTBJIh1bidBcw1ziU6hIVIPseLyEWc7NX88gk4f rtUvGtGv/PTqxmJN1nFgt9dmTC4++YFJWL4ExYb1VbivhUB6zE/EH77l7NhFLIKfTTqz sNR+66VjaaRpdXnSYs5kL4vF6XO+yMxUxjTfStBtHEgaFMwgfpMHx1EnWzozPcCnOPzo 9TYQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:to:content-transfer-encoding:mime-version :message-id:date:subject:cc:from:dkim-signature; bh=PccFhNjS4hhr30qgJVviBgbheq+JeXNwdy/AbmdcXhg=; b=B8H+3fa1+Hy1lsCI6kW30iQ7S2BH+7EgvO0ZzFYdLpYPSu2nHZMIXBLkuDp+w7JM+z ujORtIH8qr9S3CK+dv6yJEEaVsLq83yBfW1iF94fPHh9B7TAXUjN1+19G0ERtBujjJeR LLb50UxZxjSvbaBZ6tHtrNjlIkm0sDN/X0HrDkRhCj2BE0THgSbcrcqr7VSLc7p1PLzG 75How1eOYaPp65xxd31QyyJqeik0R9wNAWWzLlaBNCfJFgPsMYPJKup+XO7caKHEKivK XUEp2Rmyd7QYJ/aAKqAiU+qfiJhqna1c58SXEiRsdwBpkS1aoAEhkaFxs5OrcSqfnI0M muUw== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b="GJ/O7P97"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id gh22si3543471ejb.532.2020.05.28.03.42.36; Thu, 28 May 2020 03:43:00 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b="GJ/O7P97"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387982AbgE1KkT (ORCPT + 99 others); Thu, 28 May 2020 06:40:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34582 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387924AbgE1KkL (ORCPT ); Thu, 28 May 2020 06:40:11 -0400 Received: from mail-pg1-x544.google.com (mail-pg1-x544.google.com [IPv6:2607:f8b0:4864:20::544]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EA070C05BD1E; Thu, 28 May 2020 03:40:10 -0700 (PDT) Received: by mail-pg1-x544.google.com with SMTP id r10so13287451pgv.8; Thu, 28 May 2020 03:40:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=PccFhNjS4hhr30qgJVviBgbheq+JeXNwdy/AbmdcXhg=; b=GJ/O7P976gM9R4fCiCYxrVEz8ja0koSDzYE92U/6XQJLCvTE6/pZyP73revZl0frc/ tLXaU22Nw3nMpojTGdjGipJ7K8Jo0cSApT9L119zjuduyjbfbGY56IzPjOAt4ATuC8g7 KvTFXg419z5JXuqS4LHgL4y8vauJU7K93iIhHPEL7eYuP9aHKhsD7+yXHwBfMY5z8Ppr D3U6qLKhAVlp3boPM/mrylqkgAl+v+OAHxrgDRykbhP5e+YrpCXxyI6eg7XEfboayHhE uaSd7/hvgr6dRW6qDa3mc9Scj5mX4+HxL7YLL85OgmK+Is0H/q954zTaamamBBHj+FSF t2RQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=PccFhNjS4hhr30qgJVviBgbheq+JeXNwdy/AbmdcXhg=; b=pMZPZ+FnPKYYVyYlzwdWzzS6L5j5B7OlXmKM71LPtqPL4bxiG8d/Sfbdc9DTXGlXQg W2XiGAuI1pHR8T+cDN9hqAL7GBSWqu4CJZY+nLiDjDvS5CArjHRPZGfR2WNmwg1sMdO5 48rEh9zkyUo/QPbp6214+VEcdaMV4EWcJM1BCgu2954n814jufp4V2m0t0Iv99V87FIx O3ZuXBlcHsvXIKrDNjXyFnI/4mCxf1J/5PTvXBMK5eywCbaqd3Xn1OldfTSP9DOvV5fC +N313r58wdkWFZWerXPJq4lymsxzOostdx97AMCGeaY1Wp28XmqG2rzQ/EKunu8vuFU5 e73g== X-Gm-Message-State: AOAM531GJ+AmuaU5knOeoIpPd0YtGqB90yGkcjU/B9/DdbI8Ca2yNNcM uYXJs+PgylrszBSFbgt72yqXNQlsi3E= X-Received: by 2002:a62:6404:: with SMTP id y4mr2354759pfb.64.1590662410555; Thu, 28 May 2020 03:40:10 -0700 (PDT) Received: from suzukaze.ipads-lab.se.sjtu.edu.cn ([202.120.40.82]) by smtp.gmail.com with ESMTPSA id mn19sm5115152pjb.8.2020.05.28.03.40.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 28 May 2020 03:40:09 -0700 (PDT) From: Chuhong Yuan Cc: Alessandro Zummo , Alexandre Belloni , linux-rtc@vger.kernel.org, linux-kernel@vger.kernel.org, Chuhong Yuan Subject: [PATCH v2] rtc: rv3028: Add missed check for devm_regmap_init_i2c() Date: Thu, 28 May 2020 18:39:50 +0800 Message-Id: <20200528103950.912353-1-hslester96@gmail.com> X-Mailer: git-send-email 2.26.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit To: unlisted-recipients:; (no To-header on input) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org rv3028_probe() misses a check for devm_regmap_init_i2c(). Add the missed check to fix it. Fixes: e6e7376cfd7b ("rtc: rv3028: add new driver") Signed-off-by: Chuhong Yuan --- Changes in v2: - Add fixes tag. drivers/rtc/rtc-rv3028.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/rtc/rtc-rv3028.c b/drivers/rtc/rtc-rv3028.c index a0ddc86c975a..ec84db0b3d7a 100644 --- a/drivers/rtc/rtc-rv3028.c +++ b/drivers/rtc/rtc-rv3028.c @@ -755,6 +755,8 @@ static int rv3028_probe(struct i2c_client *client) return -ENOMEM; rv3028->regmap = devm_regmap_init_i2c(client, ®map_config); + if (IS_ERR(rv3028->regmap)) + return PTR_ERR(rv3028->regmap); i2c_set_clientdata(client, rv3028); -- 2.26.2