Received: by 2002:a25:ef43:0:0:0:0:0 with SMTP id w3csp332195ybm; Thu, 28 May 2020 04:04:23 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyokTAGgKTK8Ra4s82KEW9WNHD3Y66vODlCv4UmvgX8ao1JemB8u0b7yNu6eBmtZccjrbGY X-Received: by 2002:a05:6402:1cb6:: with SMTP id cz22mr2369885edb.86.1590663863332; Thu, 28 May 2020 04:04:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1590663863; cv=none; d=google.com; s=arc-20160816; b=nJlA+bWlJZLgXAbLV1rbnanXiEW56HE9OgJ6vnLrrCneaHlEnoKnvnN75pj8r9UDLU FjWwTY1NCRD3vl35uPiamXijTGc5rz6Cfd1z8unruwlbeNH7bXYF23O96o8JakSVnbbP kErVS3yTN/+AFvbFG3uyc2esEsZ97ZzMDVn96sz1pMRXfIsrqqm+iR66EekqtZ/vMHPg LXPVLXFGN9sEtCvI5nf2kk5ioV4zNsheJkORe/Bcuny352H1i0RDxpDdBxrcj1e21WKD /uBwsO3fgE2ixDst5BvOz5GtcYC98semeLYLOA4JaFLVwnNLb/dTL7yWe18Q35uT5fz9 35Cg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from; bh=CJ1yfYVN7KdXAf3wwgLR3wVulhBOrlD2OS22w+CA+Es=; b=frMhdi9+cHUozit/uRPOeieIvxnPft2BSW2YFhYk2m2Ccj6QNpQxkIBUKllwE/Rrv+ XbJlBc/kEZ0XKMb8/Lq4cEiemZc/OtqtwMpnCr8GeVhZCNZtKIBQKbQan/B4yKzDfBj0 tscEIYCut2TZg9Ua9y0f802qkOXOe3WCqIpD2VntOEMlmUWE0F0WKhbVPPRy0U2p53MG AtyiBcF0xr0xlYtxJbF7bm3gd3RyIjWxzeTOe8N1m652YZ0VrF6W+41WcFCj8GoghlES t5nu76m6Yzu3VfUlVMFecYd9RIf4EE+NNHT5E2D433twYg+Zzw/lZaa582+pByF0fKzJ qRHQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id z15si3480527eda.482.2020.05.28.04.03.58; Thu, 28 May 2020 04:04:23 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388111AbgE1LBj (ORCPT + 99 others); Thu, 28 May 2020 07:01:39 -0400 Received: from out30-54.freemail.mail.aliyun.com ([115.124.30.54]:35773 "EHLO out30-54.freemail.mail.aliyun.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388091AbgE1LBg (ORCPT ); Thu, 28 May 2020 07:01:36 -0400 X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R171e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e01e01419;MF=alex.shi@linux.alibaba.com;NM=1;PH=DS;RN=19;SR=0;TI=SMTPD_---0Tztb9j4_1590663687; Received: from localhost(mailfrom:alex.shi@linux.alibaba.com fp:SMTPD_---0Tztb9j4_1590663687) by smtp.aliyun-inc.com(127.0.0.1); Thu, 28 May 2020 19:01:28 +0800 From: Alex Shi To: akpm@linux-foundation.org, mgorman@techsingularity.net, tj@kernel.org, hughd@google.com, khlebnikov@yandex-team.ru, daniel.m.jordan@oracle.com, yang.shi@linux.alibaba.com, willy@infradead.org, hannes@cmpxchg.org, lkp@intel.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, shakeelb@google.com, iamjoonsoo.kim@lge.com, richard.weiyang@gmail.com Cc: Alex Shi , Michal Hocko , Vladimir Davydov Subject: [PATCH v11 08/16] mm/memcg: add debug checking in lock_page_memcg Date: Thu, 28 May 2020 19:00:50 +0800 Message-Id: <1590663658-184131-9-git-send-email-alex.shi@linux.alibaba.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1590663658-184131-1-git-send-email-alex.shi@linux.alibaba.com> References: <1590663658-184131-1-git-send-email-alex.shi@linux.alibaba.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Add a debug checking in lock_page_memcg, then we could get alarm if anything wrong here. Suggested-by: Johannes Weiner Signed-off-by: Alex Shi Cc: Johannes Weiner Cc: Michal Hocko Cc: Vladimir Davydov Cc: Andrew Morton Cc: cgroups@vger.kernel.org Cc: linux-mm@kvack.org Cc: linux-kernel@vger.kernel.org --- mm/memcontrol.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/mm/memcontrol.c b/mm/memcontrol.c index d04f1e242d47..91b073891d06 100644 --- a/mm/memcontrol.c +++ b/mm/memcontrol.c @@ -1983,6 +1983,12 @@ struct mem_cgroup *lock_page_memcg(struct page *page) if (unlikely(!memcg)) return NULL; +#ifdef CONFIG_PROVE_LOCKING + local_irq_save(flags); + might_lock(&memcg->move_lock); + local_irq_restore(flags); +#endif + if (atomic_read(&memcg->moving_account) <= 0) return memcg; -- 1.8.3.1