Received: by 2002:a25:ef43:0:0:0:0:0 with SMTP id w3csp332623ybm; Thu, 28 May 2020 04:04:56 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyrsvbrxOQ3nkFrEWU4cUHYHOmOUdK2fAzRDU+L2+tnYG7DlGr4ewtY8cAsIUV8npyhkCgu X-Received: by 2002:a17:906:198d:: with SMTP id g13mr2373311ejd.281.1590663896675; Thu, 28 May 2020 04:04:56 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1590663896; cv=none; d=google.com; s=arc-20160816; b=sarJKtFzgF+NWbZRWKSLkgmgvVBj7AfEkd6a1AQIGOFMqKypjuYmbNhgAfStgzh57I j3ykKzGaHsGHG56gnHHEOm1of5DVaVevu7mhHGZRlkXVyarsvxOMh5c4c2xU2+GTR+Wl Om3Oqwc9RbvLyKf3KOirTeoLieYw7PRxDb6MiBbkBYPviyIqEKkn2RjnsQgjaNMsyQVV RkZt6jUx7NmZfzHq6Bfw7CctLil9OgiTLy1B69T09zo54r3POfjrpf9ftNKy0Bxc62sp 4z6nVos8tzbNbP6z9pndqHh7n9vFqMxIZHh9sEKI32N6Ow2BB87OR4RuPkkHPBTzfeYI hF2w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:autocrypt:from:references:cc:to:subject:dkim-signature; bh=GNMUfaAS1uFxk0W4ap5uWlqfs79WUP9nAHlNDKy6Dqs=; b=ZRJ+XQH+2Ot50eD6LZMIuf2i/MKsGwMZL7e/2OxJZyNUJVwRzHPEUUHPDFQZdCIIOg hiTObRIQcvCSGyXeEhKCAKAMvHdDbvqrQ8NnqwYUyY2eIQeXmYLQRTqnd2M/0+tTyoii H6/5JeJU4xMlduivO3iZWXPUjnqCv1FAV+T7MyvsSzPMyHKUSkP2MzP77MXE+IT7R0pY 4W5TRjnP+UphqFUqERWI890Ttyqepa0t2FzXATlt7fGVUN1Mv8bpv8GyJRvwQpBMEug0 Nzw8ts1t5fy2pxlzeSdMer3k+/X3XPfrnc10ar8gXbCBiWi5oMILKt8uAJ78PQiCMlDJ WQsg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@web.de header.s=dbaedf251592 header.b=e2n9djQ7; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id qx14si3603941ejb.442.2020.05.28.04.04.32; Thu, 28 May 2020 04:04:56 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@web.de header.s=dbaedf251592 header.b=e2n9djQ7; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388068AbgE1LA1 (ORCPT + 99 others); Thu, 28 May 2020 07:00:27 -0400 Received: from mout.web.de ([212.227.15.4]:57331 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387998AbgE1LAZ (ORCPT ); Thu, 28 May 2020 07:00:25 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=dbaedf251592; t=1590663604; bh=JDTvcYUT9QQ84zndHyXTumjbvjRP4wWAX6bJiCmB9qw=; h=X-UI-Sender-Class:Subject:To:Cc:References:From:Date:In-Reply-To; b=e2n9djQ7i5w43UNVKm+AS6PmKJyiVEVFEqmAsnoSARLpRRlnRHV0yAUAssqH6dbNf 1G7NZnPY2BtTu1Axs6k2PJOlEKkkDCSeK+k6r9IaBqSuafLzbvXxLr9E54gA4L8UOD x0b40+otv8bZGyIzhShcDtbtYQC0i4QSHJSWYE20= X-UI-Sender-Class: c548c8c5-30a9-4db5-a2e7-cb6cb037b8f9 Received: from [192.168.1.2] ([2.243.155.229]) by smtp.web.de (mrweb005 [213.165.67.108]) with ESMTPSA (Nemesis) id 1MwjFu-1ip1QM0CZm-00y6Yz; Thu, 28 May 2020 13:00:04 +0200 Subject: Re: [v5] workqueue: Remove unnecessary kfree() call in rcu_free_wq() To: Tejun Heo , Dan Carpenter , Zhang Qiang , Lai Jiangshan Cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org References: <20200527075715.36849-1-qiang.zhang@windriver.com> <284c7851-4e89-a00f-a2e6-aa8e2e1f3fce@web.de> <20200528095703.GH30374@kadam> <20200528103809.GK83516@mtj.thefacebook.com> From: Markus Elfring Autocrypt: addr=Markus.Elfring@web.de; prefer-encrypt=mutual; keydata= mQINBFg2+xABEADBJW2hoUoFXVFWTeKbqqif8VjszdMkriilx90WB5c0ddWQX14h6w5bT/A8 +v43YoGpDNyhgA0w9CEhuwfZrE91GocMtjLO67TAc2i2nxMc/FJRDI0OemO4VJ9RwID6ltwt mpVJgXGKkNJ1ey+QOXouzlErVvE2fRh+KXXN1Q7fSmTJlAW9XJYHS3BDHb0uRpymRSX3O+E2 lA87C7R8qAigPDZi6Z7UmwIA83ZMKXQ5stA0lhPyYgQcM7fh7V4ZYhnR0I5/qkUoxKpqaYLp YHBczVP+Zx/zHOM0KQphOMbU7X3c1pmMruoe6ti9uZzqZSLsF+NKXFEPBS665tQr66HJvZvY GMDlntZFAZ6xQvCC1r3MGoxEC1tuEa24vPCC9RZ9wk2sY5Csbva0WwYv3WKRZZBv8eIhGMxs rcpeGShRFyZ/0BYO53wZAPV1pEhGLLxd8eLN/nEWjJE0ejakPC1H/mt5F+yQBJAzz9JzbToU 5jKLu0SugNI18MspJut8AiA1M44CIWrNHXvWsQ+nnBKHDHHYZu7MoXlOmB32ndsfPthR3GSv jN7YD4Ad724H8fhRijmC1+RpuSce7w2JLj5cYj4MlccmNb8YUxsE8brY2WkXQYS8Ivse39MX BE66MQN0r5DQ6oqgoJ4gHIVBUv/ZwgcmUNS5gQkNCFA0dWXznQARAQABtCZNYXJrdXMgRWxm cmluZyA8TWFya3VzLkVsZnJpbmdAd2ViLmRlPokCVAQTAQgAPhYhBHDP0hzibeXjwQ/ITuU9 Figxg9azBQJYNvsQAhsjBQkJZgGABQsJCAcCBhUICQoLAgQWAgMBAh4BAheAAAoJEOU9Figx g9azcyMP/iVihZkZ4VyH3/wlV3nRiXvSreqg+pGPI3c8J6DjP9zvz7QHN35zWM++1yNek7Ar OVXwuKBo18ASlYzZPTFJZwQQdkZSV+atwIzG3US50ZZ4p7VyUuDuQQVVqFlaf6qZOkwHSnk+ CeGxlDz1POSHY17VbJG2CzPuqMfgBtqIU1dODFLpFq4oIAwEOG6fxRa59qbsTLXxyw+PzRaR LIjVOit28raM83Efk07JKow8URb4u1n7k9RGAcnsM5/WMLRbDYjWTx0lJ2WO9zYwPgRykhn2 sOyJVXk9xVESGTwEPbTtfHM+4x0n0gC6GzfTMvwvZ9G6xoM0S4/+lgbaaa9t5tT/PrsvJiob kfqDrPbmSwr2G5mHnSM9M7B+w8odjmQFOwAjfcxoVIHxC4Cl/GAAKsX3KNKTspCHR0Yag78w i8duH/eEd4tB8twcqCi3aCgWoIrhjNS0myusmuA89kAWFFW5z26qNCOefovCx8drdMXQfMYv g5lRk821ZCNBosfRUvcMXoY6lTwHLIDrEfkJQtjxfdTlWQdwr0mM5ye7vd83AManSQwutgpI q+wE8CNY2VN9xAlE7OhcmWXlnAw3MJLW863SXdGlnkA3N+U4BoKQSIToGuXARQ14IMNvfeKX NphLPpUUnUNdfxAHu/S3tPTc/E/oePbHo794dnEm57LuuQINBFg2+xABEADZg/T+4o5qj4cw nd0G5pFy7ACxk28mSrLuva9tyzqPgRZ2bdPiwNXJUvBg1es2u81urekeUvGvnERB/TKekp25 4wU3I2lEhIXj5NVdLc6eU5czZQs4YEZbu1U5iqhhZmKhlLrhLlZv2whLOXRlLwi4jAzXIZAu 76mT813jbczl2dwxFxcT8XRzk9+dwzNTdOg75683uinMgskiiul+dzd6sumdOhRZR7YBT+xC wzfykOgBKnzfFscMwKR0iuHNB+VdEnZw80XGZi4N1ku81DHxmo2HG3icg7CwO1ih2jx8ik0r riIyMhJrTXgR1hF6kQnX7p2mXe6K0s8tQFK0ZZmYpZuGYYsV05OvU8yqrRVL/GYvy4Xgplm3 DuMuC7/A9/BfmxZVEPAS1gW6QQ8vSO4zf60zREKoSNYeiv+tURM2KOEj8tCMZN3k3sNASfoG fMvTvOjT0yzMbJsI1jwLwy5uA2JVdSLoWzBD8awZ2X/eCU9YDZeGuWmxzIHvkuMj8FfX8cK/ 2m437UA877eqmcgiEy/3B7XeHUipOL83gjfq4ETzVmxVswkVvZvR6j2blQVr+MhCZPq83Ota xNB7QptPxJuNRZ49gtT6uQkyGI+2daXqkj/Mot5tKxNKtM1Vbr/3b+AEMA7qLz7QjhgGJcie qp4b0gELjY1Oe9dBAXMiDwARAQABiQI8BBgBCAAmFiEEcM/SHOJt5ePBD8hO5T0WKDGD1rMF Alg2+xACGwwFCQlmAYAACgkQ5T0WKDGD1rOYSw/+P6fYSZjTJDAl9XNfXRjRRyJSfaw6N1pA Ahuu0MIa3djFRuFCrAHUaaFZf5V2iW5xhGnrhDwE1Ksf7tlstSne/G0a+Ef7vhUyeTn6U/0m +/BrsCsBUXhqeNuraGUtaleatQijXfuemUwgB+mE3B0SobE601XLo6MYIhPh8MG32MKO5kOY hB5jzyor7WoN3ETVNQoGgMzPVWIRElwpcXr+yGoTLAOpG7nkAUBBj9n9TPpSdt/npfok9ZfL /Q+ranrxb2Cy4tvOPxeVfR58XveX85ICrW9VHPVq9sJf/a24bMm6+qEg1V/G7u/AM3fM8U2m tdrTqOrfxklZ7beppGKzC1/WLrcr072vrdiN0icyOHQlfWmaPv0pUnW3AwtiMYngT96BevfA qlwaymjPTvH+cTXScnbydfOQW8220JQwykUe+sHRZfAF5TS2YCkQvsyf7vIpSqo/ttDk4+xc Z/wsLiWTgKlih2QYULvW61XU+mWsK8+ZlYUrRMpkauN4CJ5yTpvp+Orcz5KixHQmc5tbkLWf x0n1QFc1xxJhbzN+r9djSGGN/5IBDfUqSANC8cWzHpWaHmSuU3JSAMB/N+yQjIad2ztTckZY pwT6oxng29LzZspTYUEzMz3wK2jQHw+U66qBFk8whA7B2uAU1QdGyPgahLYSOa4XAEGb6wbI FEE= Message-ID: <5e25fc22-fb61-46f8-a8ec-232bceee40b7@web.de> Date: Thu, 28 May 2020 13:00:03 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 MIME-Version: 1.0 In-Reply-To: <20200528103809.GK83516@mtj.thefacebook.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:S63PDuuxhX5z2Fao7KFsJ3aiqzbSy+UBK/l6Ff08BJh8pfZmC6N T/+ARQrQeCE0IzaaP2XcHBsow3DIhUwrR1LghXmJXxuvkjWPhiUTdNSqrC2MTiPw/ouUYLa p8cewGKqDH9pgUU2oE09WXPuT4UECUQo166kEQke6Wz2KATq0lNwiSlpJK4OHN2eYCjwoIa ZCU7wVEXWNnt2Fi02Wg8g== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:bjo7JMP2dRA=:5YO5IBquEt73MoiuQVlt7i 1M8nAuLy+mFygfF2iJjDxxYNwWbM5WTZZyO/UKl5Qj3JE2PyR8qsQRBfSYWd59ZzrnzHjV++G kFaxyYXfAdMOzlPIKZDXPL5C/tKgnjtWkhEvRnqmYU07rZZr1nx2HcNxJPvxZTY6pWuIB1Lg+ kKU9MrY5Uhuuw2bo+zuBrH+Ip4iYMNjbNJVAfBKi8F/of/eAGhRqApUlZ8YigO+psG1vb7A1x wc34usNORarsahUsW4epL5lDLm6OrGNd/mRdOqpJ/dI+MSHCk6hl6TLY9IrYY7aIxthqNBAFa fNgvmq4A2bCoMjVhiy89gxp/MKVxzl754hDiThrsjLuXkvKECxb+gt/1XmMlpEowAXVsWLIf9 sBsr5tlxk9s/JnnBzSmeaOu7g/fem4hQ36fk9qeWd4OLjS5liTu3Riq2uKhhCf4aJzFNZYjr/ F3AQs0ZCbu0bcTzso6cWzR/9t9fVKS7/9U7bfsqjvQobtnTOQtfltUDJmWtoz1wY1ijSVkiSK n+fk1hhytMNspGhDxKFCkA2EzOkOZr4Empp2ZRtzHd9r8L6paMAg8QF02tyyX+Ra21fjVwmUc cHgr5PRAeZzEZ5vrDjqo9d3Xdyvf/d7W/BBjk527afYKiuAVQKvH3e4B8jdZaarsNleAXMKGw jA9Tpt45BveV2v7oWKutSA0u0coKrPHwaCqmpvVbB+Dd8x9FiVVN5Zjw2/Sh+6O/nkBEjpsqI sX80pKqFYtTAHO47Uqo2LHSo9P44E6wGZL4byCJdRpAxuEewuL4XE2xz0Bc0Tam30KhC0QtWO 682uKp+p6zJuxil7FYExLhtMw991BvPu7V+0bjg915gSAMxp6vGkGxiaQLixAbxY10k8+TyK5 MlJBjArK0VJYb3fEXl/RIV/6w9XAMhOOEd5ndgh6rSVIouRTfjKag2YMLcIqH0arBaOD+lmBy dWZeEnYwyRkfrTtXOtEFDrUq6mxZhPrhoWWy10tfHn9EPZ0rb2hLSlHi++WeFv/g+BXThlGTe Ihy26tf4/P1gwDc55TczHZnJ2+DddXESQMfO6nOyhthkdIYtLRTU22vZOTtiEtxsBUUqdI6OI 6PBMSz4xTNBgVyvYKm1idI0YxN4sOjQqWVtIOMRrjaIFuW75Y1eK8oUcDDb1sQIc027v5rwsd UXvaaCTaPIJWiOF/UpaJNwoEXCsAEcJmD2NNVDeHBO3EOHfuGRgKKkium1sbj8zxx9xdZX+RX eTKzBbjqo2l/lZw3u Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org >> Guys, the patch is wrong. The kfree is harmless when this is called >> from destroy_workqueue() and required when it's called from >> pwq_unbound_release_workfn(). Lai Jiangshan already explained this >> already. Why are we still discussing this? > > Oops, missed that. Reverting. Can it matter to use separate callback functions for these cases? https://elixir.bootlin.com/linux/v5.7-rc7/C/ident/rcu_free_pwq Regards, Markus