Received: by 2002:a25:ef43:0:0:0:0:0 with SMTP id w3csp359820ybm; Thu, 28 May 2020 04:50:16 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw34JG0w8I4TCkDCAT12+PUMjSyNcGNSejd3WibFIsoDZ/73DF18NGBeRDzg4uWLcUP5y07 X-Received: by 2002:a17:906:944c:: with SMTP id z12mr2621371ejx.472.1590666616165; Thu, 28 May 2020 04:50:16 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1590666616; cv=none; d=google.com; s=arc-20160816; b=xiVJ0DcZwSNiifepaIad2/iaQnXKBVSh8J2KtT3VazTnjM5R87me7c5MJxfDg3E0wf U6zBBD1tna7QMATVtORHg+hfe/DGNBzgoPEO0plhg+Z0nP1ApjVnq6dyiVYEMWLlyzRK GvFCZBg3EpXYpZFpVATy2fvMpiJiBWp9egjzrBbdhAK/eEtHd6ehtUSdro3cOfj0Ze6l X+mO5rtasCk4t3dy5vzVqOHjEr1wOGGMOVRYX5AMGWSfR/+XCktsiulkbsvmZ7ICBVBb BLaYvNbKp0aT5T7N8YzymrNtP79Dt562AqypWfrLR479vOXZFlEesQ/VZmI40l+78/Pt qFxg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=wh/sx94U9V0RgLAGv/f6/CxSNs/6Wn3ad6LS90qEaxI=; b=vh4LoLVw+nR1HQ82mzcHRZPd1ZgFN3LL1JbN2O6PteyckHmdwZyxoh98pV9u+78Hlg k4Kv0FAjFQdp5gwroXG7xOX8yXH2vwd36DuF1EWApjQVErooySxNKTnwdt+RU6EXXZZl aHbuguzBcxQ0F2Wvnulw9HRYQe8FFUaVtQ38T5b2hhGPqQG08arsxbqnkxFrXGHY63X/ qHPW/OLOR9rL2ZoQDvOyacNfxZcv5+4tyNTz+Pn/c9jhlm2KPiUhNJpfH/nWuy2UPHg3 cbipkcrgbd/RWE5GV/h3hL+YPsIy4qgmYzUz99invOpKnLqSlOlaBm1+NZ2qCSVDxeKx kFpw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id i18si3722133ejx.488.2020.05.28.04.49.51; Thu, 28 May 2020 04:50:16 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388491AbgE1Lrs (ORCPT + 99 others); Thu, 28 May 2020 07:47:48 -0400 Received: from cmccmta3.chinamobile.com ([221.176.66.81]:5585 "EHLO cmccmta3.chinamobile.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388326AbgE1Lrs (ORCPT ); Thu, 28 May 2020 07:47:48 -0400 Received: from spf.mail.chinamobile.com (unknown[172.16.121.13]) by rmmx-syy-dmz-app12-12012 (RichMail) with SMTP id 2eec5ecfa4d1012-158dc; Thu, 28 May 2020 19:47:30 +0800 (CST) X-RM-TRANSID: 2eec5ecfa4d1012-158dc X-RM-TagInfo: emlType=0 X-RM-SPAM-FLAG: 00000000 Received: from localhost.localdomain (unknown[112.25.154.146]) by rmsmtp-syy-appsvr07-12007 (RichMail) with SMTP id 2ee75ecfa4cf278-b3077; Thu, 28 May 2020 19:47:29 +0800 (CST) X-RM-TRANSID: 2ee75ecfa4cf278-b3077 From: Tang Bin To: gregkh@linuxfoundation.org, thierry.reding@gmail.com, balbi@kernel.org, jonathanh@nvidia.com Cc: linux-usb@vger.kernel.org, linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org, Tang Bin , Zhang Shengju Subject: [PATCH] usb: phy: tegra: Fix unnecessary check in tegra_usb_phy_probe() Date: Thu, 28 May 2020 19:47:17 +0800 Message-Id: <20200528114717.21028-1-tangbin@cmss.chinamobile.com> X-Mailer: git-send-email 2.20.1.windows.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org In the function tegra_usb_phy_probe(), if usb_add_phy_dev() failed, the return value will be given to err, and if usb_add_phy_dev() succeed, the return value will be zero. Thus it is unnecessary to repeated check here. Signed-off-by: Zhang Shengju Signed-off-by: Tang Bin --- drivers/usb/phy/phy-tegra-usb.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/usb/phy/phy-tegra-usb.c b/drivers/usb/phy/phy-tegra-usb.c index c294dc617..27c2e9843 100644 --- a/drivers/usb/phy/phy-tegra-usb.c +++ b/drivers/usb/phy/phy-tegra-usb.c @@ -1200,11 +1200,7 @@ static int tegra_usb_phy_probe(struct platform_device *pdev) platform_set_drvdata(pdev, tegra_phy); - err = usb_add_phy_dev(&tegra_phy->u_phy); - if (err) - return err; - - return 0; + return usb_add_phy_dev(&tegra_phy->u_phy); } static int tegra_usb_phy_remove(struct platform_device *pdev) -- 2.20.1.windows.1