Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: TimAcTaAbz9xASzqzG035Xkk4ID7D0A6dHEgzf1R2GsADv7ksdvq2inETPoRxazgKzBQhBgCH0
 UT1H90HdosQA==
IronPort-SDR: u84QpQ5IqhYypu7SUxlUsG6vo+VFTGP0sKs3nGhLi3A+qwIBXcUKU1s9f+mwe61bf/k4p+L/YD
 c6NltBp8W5eQ==
From:   "Wan, Kaike" <kaike.wan@intel.com>
To:     "wu000273@umn.edu" <wu000273@umn.edu>,
        "kjlu@umn.edu" <kjlu@umn.edu>
CC:     "Dalessandro, Dennis" <dennis.dalessandro@intel.com>,
        "Marciniszyn, Mike" <mike.marciniszyn@intel.com>,
        Doug Ledford <dledford@redhat.com>,
        "Jason Gunthorpe" <jgg@ziepe.ca>,
        "linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] RDMA/qib: Fix several reference count leak
 qib_create_port_files
Thread-Topic: [PATCH] RDMA/qib: Fix several reference count leak
 qib_create_port_files
Thread-Index: AQHWNJl7SA8NUO5mFkqEEZv/I2OK46i9ZzrQ
Date:   Thu, 28 May 2020 12:05:57 +0000
Message-ID: <MW3PR11MB4665C9149B684B4B9F00AFF5F48E0@MW3PR11MB4665.namprd11.prod.outlook.com>
References: <20200528024037.6611-1-wu000273@umn.edu>
In-Reply-To: <20200528024037.6611-1-wu000273@umn.edu>
Accept-Language: en-US
Content-Language: en-US
dlp-product: dlpe-windows
dlp-reaction: no-action
dlp-version: 11.2.0.6
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 7a748bc5-1776-4f5b-c5e5-08d802ff7b2a
X-MS-Exchange-CrossTenant-originalarrivaltime: 28 May 2020 12:05:57.8564
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 2EduTT2hD8ngHOH85Gm9rpg9ZxmZbGDcVtRPl5OjM4orvxyN4wiL4yTg5VntaYW25/Swkrpf/dVHiJA6ZI4d7w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW3PR11MB4603
X-OriginatorOrg: intel.com
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> -----Original Message-----
> From: linux-rdma-owner@vger.kernel.org <linux-rdma-
> owner@vger.kernel.org> On Behalf Of wu000273@umn.edu
> Sent: Wednesday, May 27, 2020 10:41 PM
> To: kjlu@umn.edu
> Cc: wu000273@umn.edu; Dalessandro, Dennis
> <dennis.dalessandro@intel.com>; Marciniszyn, Mike
> <mike.marciniszyn@intel.com>; Doug Ledford <dledford@redhat.com>;
> Jason Gunthorpe <jgg@ziepe.ca>; linux-rdma@vger.kernel.org; linux-
> kernel@vger.kernel.org
> Subject: [PATCH] RDMA/qib: Fix several reference count leak
> qib_create_port_files
>=20
> From: Qiushi Wu <wu000273@umn.edu>
>=20
> kobject_init_and_add() takes reference even when it fails.
> If this function returns an error, kobject_put() must be called to proper=
ly
> clean up the memory associated with the object. To fix these issues, we
> correct the jump targets when the calls of
> kobject_init_and_add() fail, to make sure they can be handled by
> kobject_put(). Previous commit "b8eb718348b8" fixed a similar problem.
>=20
> Signed-off-by: Qiushi Wu <wu000273@umn.edu>
> ---
>  drivers/infiniband/hw/qib/qib_sysfs.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
>=20
> diff --git a/drivers/infiniband/hw/qib/qib_sysfs.c
> b/drivers/infiniband/hw/qib/qib_sysfs.c
> index 568b21eb6ea1..017ed82070f9 100644
> --- a/drivers/infiniband/hw/qib/qib_sysfs.c
> +++ b/drivers/infiniband/hw/qib/qib_sysfs.c
> @@ -760,7 +760,7 @@ int qib_create_port_files(struct ib_device *ibdev, u8
> port_num,
>  		qib_dev_err(dd,
>  			"Skipping linkcontrol sysfs info, (err %d) port %u\n",
>  			ret, port_num);
> -		goto bail;
> +		goto bail_link;
>  	}
>  	kobject_uevent(&ppd->pport_kobj, KOBJ_ADD);
>=20
> @@ -770,7 +770,7 @@ int qib_create_port_files(struct ib_device *ibdev, u8
> port_num,
>  		qib_dev_err(dd,
>  			"Skipping sl2vl sysfs info, (err %d) port %u\n",
>  			ret, port_num);
> -		goto bail_link;
> +		goto bail_sl;
>  	}
>  	kobject_uevent(&ppd->sl2vl_kobj, KOBJ_ADD);
>=20
> @@ -780,7 +780,7 @@ int qib_create_port_files(struct ib_device *ibdev, u8
> port_num,
>  		qib_dev_err(dd,
>  			"Skipping diag_counters sysfs info, (err %d)
> port %u\n",
>  			ret, port_num);
> -		goto bail_sl;
> +		goto bail_diagc;
>  	}
>  	kobject_uevent(&ppd->diagc_kobj, KOBJ_ADD);
>=20
> @@ -793,7 +793,7 @@ int qib_create_port_files(struct ib_device *ibdev, u8
> port_num,
>  		qib_dev_err(dd,
>  		 "Skipping Congestion Control sysfs info, (err %d) port %u\n",
>  		 ret, port_num);
> -		goto bail_diagc;
> +		goto bail_cc;
>  	}
>=20
>  	kobject_uevent(&ppd->pport_cc_kobj, KOBJ_ADD);
> --
> 2.17.1
Already fixed:

https://marc.info/?l=3Dlinux-rdma&m=3D158925321102485&w=3D2

Kaike