Received: by 2002:a25:ef43:0:0:0:0:0 with SMTP id w3csp373057ybm; Thu, 28 May 2020 05:10:16 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzTSJNpoQtO60kHLFzkzkNQtd+bPsPxk1vLucnH0eq/vX4pH2T4raW2proU8XapdTmYOKew X-Received: by 2002:a17:906:5941:: with SMTP id g1mr2779555ejr.182.1590667816787; Thu, 28 May 2020 05:10:16 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1590667816; cv=none; d=google.com; s=arc-20160816; b=wu804n9YDLj6hltyQ28B9cq17Ims/yo60kx6GvSFfJcxLPfUpq3UZzY7adfhxthmfa rjJhLKBYqNIvnfW8ZcDvcthaTs/74KJGRhzFodG/60R/HFcvGy0EcBjpxmHLBxPBMwEJ bFjeb22zWMlzhMk+zgiIDs7lSp5M96DbQQmOhmNgDMtIOz50a+/N+Te1XqLi/vDQ7hYu h5U64XPSl+/m8P3hFbo+mbTCck5eLzb91Pc9si0DfApwrPU3RoiMRKxqzSS4aOayfrpO qncLq7ZyRa9XqfweIFry4YvB1avUt5CVPFOyX5qomt2OMNuVUK4zoc0EJ0fSvbf8ktWy 4xVQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:mail-followup-to :reply-to:message-id:subject:cc:to:from:date; bh=vLJGR04fL0Yt7NjM7eipC+hZ6BVExcXpQYOt8c6HOu4=; b=PrPtxW3MHIUOmT+36wNnAe6nF1njXLTOcjgUXSclRXcrrZI3/q0OICs5aLHRyTqX+3 CE2kN/GFTSXVKkNdwSYeb3bRSvykO9RwxKHjCSm9s3+p9MamHxjK89WZ1Hdg9s59Z3Ov t9DT5jsTlOlFogCkHK0NHOvZQebbCwGD00yzoUqXHF3vS1wVn4QbEwjRqietYOZZ4RgX sK5hLbE5CYArC6gf4eB4kWLwmuTzngS3YjlxNKyjpfa1uyYvQkWLK+/9D5qOlzLclrqY FUEmX1pymUlBZbPBwjNlJaw/yfQsefkwQNXNjzd+RWZkZaaKDHh6rNFlUBX5xBt/56FW G7dA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id n13si3584075edv.140.2020.05.28.05.09.54; Thu, 28 May 2020 05:10:16 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389488AbgE1MGP (ORCPT + 99 others); Thu, 28 May 2020 08:06:15 -0400 Received: from mx2.suse.de ([195.135.220.15]:40922 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388840AbgE1MGN (ORCPT ); Thu, 28 May 2020 08:06:13 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 5BC56AD4B; Thu, 28 May 2020 12:06:08 +0000 (UTC) Received: by ds.suse.cz (Postfix, from userid 10065) id D6CF9DA72D; Thu, 28 May 2020 14:05:09 +0200 (CEST) Date: Thu, 28 May 2020 14:05:09 +0200 From: David Sterba To: Arnd Bergmann Cc: Chris Mason , Josef Bacik , David Sterba , Goldwyn Rodrigues , Johannes Thumshirn , YueHaibing , linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] btrfs: select FS_IOMAP Message-ID: <20200528120509.GM18421@twin.jikos.cz> Reply-To: dsterba@suse.cz Mail-Followup-To: dsterba@suse.cz, Arnd Bergmann , Chris Mason , Josef Bacik , David Sterba , Goldwyn Rodrigues , Johannes Thumshirn , YueHaibing , linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org References: <20200528091649.2874627-1-arnd@arndb.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200528091649.2874627-1-arnd@arndb.de> User-Agent: Mutt/1.5.23.1-rc1 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, May 28, 2020 at 11:16:42AM +0200, Arnd Bergmann wrote: > As btrfs now calls iomap_dio_rw, the helper code actually has > to be enabled to avoid a link error: > > ERROR: modpost: "iomap_dio_rw" [fs/btrfs/btrfs.ko] undefined! > > Fixes: f31e5f70919f ("btrfs: switch to iomap_dio_rw() for dio") > Signed-off-by: Arnd Bergmann Thanks, I've folded the patch in so we don't get build breakage in the patches between the two.