Received: by 2002:a25:ef43:0:0:0:0:0 with SMTP id w3csp401369ybm; Thu, 28 May 2020 05:52:21 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz0WGiwYFYavGVtWgXBaW71uCegrya5db2m4seQ+UU/tG0jz502cWDtVd38H0lsrTEB9dPs X-Received: by 2002:a50:ed06:: with SMTP id j6mr2927021eds.209.1590670340890; Thu, 28 May 2020 05:52:20 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1590670340; cv=none; d=google.com; s=arc-20160816; b=SUGHeLCSofWeMqCGiDhwlzkSm3euLPf7erYe94nsyOoJFxUuhlvt1p1ven5+KQBhwu nvkcKyrXwBnFj+I6mFSMlLrftydKVNGq+lEaXIVFYsmYSNSvvnDqeIOZO+A2UtcT7mod 1bhQXa9lKzn6M+mbWr+Go1JyENSWDwzLjVHh7O8XAfFQkz/pQlT0pKcWzcy2mjmSRRJP FTWt0HyoQbI/Po3WSbX/NhTtJ5+84jt1ExnGhi7g/qwj/spyZMPL2/3S5sqIuHgqQfec XtHu70ICSKtCbeFR4iLSiCoSFCI4tdFZQ4Hppy/6eDGzCiqbzfQCJA/OObalvNHm/p5M VB8g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=N44YvMNoS2XEf8I1F7cjr6cLz8BwzDvWheszxZeZLbQ=; b=PYhbwNiHwWxGbZ5LwlP2tPqizI869YpjaOWVyzywgpCYId2Cjl+W8CNzgy1ZetO32R dt49lP5TyhY7yxVp+SjTWk9hNwElV9oU1QqokV8aBqUdi7qGG8h//nCyeFtx8615W2Dx EfE3nuw1we7W1fCfeCcjmSSJrsX5lYKxGCCef0IDM0EnpaDOq1584XAX+YQaEL5XNvwm bUnZ1Vv4qC5rJ51B9B4AqoLKN7JAClrNE/IGwuVy2A7tWl5nB/VsGG5+sdoXcDZLPzQ5 Fase61pHPvQrVSp9AjbJPx+2P+2cG0cQXgGU/KcL7Ebxn0UxZ3NXsFRmjltMjLDDso2r DUwQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=J9eumBDY; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id do15si2110016ejc.430.2020.05.28.05.51.57; Thu, 28 May 2020 05:52:20 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=J9eumBDY; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389850AbgE1Mte (ORCPT + 99 others); Thu, 28 May 2020 08:49:34 -0400 Received: from us-smtp-1.mimecast.com ([207.211.31.81]:21875 "EHLO us-smtp-delivery-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S2389860AbgE1Mt1 (ORCPT ); Thu, 28 May 2020 08:49:27 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1590670166; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=N44YvMNoS2XEf8I1F7cjr6cLz8BwzDvWheszxZeZLbQ=; b=J9eumBDYNrJ/ziAmT/7OUVDP/8oRLVoKS4hIPwc+rN/xvQ3plnU3EOzfdbqmfKiLaxbF3I jpOQVY7l34u6pMx/iTgtE7Gd1kDazpAaR2futDsT+/Eyo/rJvu1ktW7d/4Qa/OIr1gZi4m UO/4j+zZeO+HGkcrW34mnpC64+2tJUM= Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-355-Y0oHpMRwNbySY2uojqCwQA-1; Thu, 28 May 2020 08:49:24 -0400 X-MC-Unique: Y0oHpMRwNbySY2uojqCwQA-1 Received: by mail-qk1-f200.google.com with SMTP id x22so2648693qkj.6 for ; Thu, 28 May 2020 05:49:24 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=N44YvMNoS2XEf8I1F7cjr6cLz8BwzDvWheszxZeZLbQ=; b=ZSObU/+tnW0DSB6Fy7zyP/8B84JjHnH+PGJMurKZajlmn5wQsdAyoBbe3In65njMIF qvAVbBsN1lWB+3HNAPeJfhMmW5kwg2QTtJq6CTRdwS87LQmM4x94oS/06+P6PG7KbL4U 0bjwip3sSod4GQrK8IeHPQrRu+rkz90mfSHpROowfLsLcdPrlkSeGI2v23K7cKMZS5Zf YxrroyCvo+q8kMuqa6MYooXv1zc0rh0joN5BC3miHfbJvy5glONzgHg3Pv1xqXvS/Aiy ypaavRrHs2OcVAyr415N7HiGXeXA9AEsDgFD/syRNBM6l+3CPr5MvdtN6YNhv6/9FRd7 jPPw== X-Gm-Message-State: AOAM5308lgvlQDt/4D1n/TmHkBzcnLFZyszhin79AAshwTm4JGnXaXaA 7TRY3q0n1czofcBC0GuJQw4+H/LPunv7BaYrRrv5DAIk/rEWsBsH5O8LwxHqycL4agCkMDJYdfH nfcNX45t3D02b/NBOlNkXFtQx X-Received: by 2002:ad4:44e3:: with SMTP id p3mr2862070qvt.166.1590670164167; Thu, 28 May 2020 05:49:24 -0700 (PDT) X-Received: by 2002:ad4:44e3:: with SMTP id p3mr2862037qvt.166.1590670163851; Thu, 28 May 2020 05:49:23 -0700 (PDT) Received: from xz-x1 ([2607:9880:19c0:32::2]) by smtp.gmail.com with ESMTPSA id d56sm5440421qtb.54.2020.05.28.05.49.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 28 May 2020 05:49:23 -0700 (PDT) Date: Thu, 28 May 2020 08:49:19 -0400 From: Peter Xu To: Xiaoming Ni Cc: aarcange@redhat.com, akpm@linux-foundation.org, cracauer@cons.org, dplotnikov@virtuozzo.com, gokhale2@llnl.gov, hannes@cmpxchg.org, hughd@google.com, jglisse@redhat.com, kirill@shutemov.name, linux-kernel@vger.kernel.org, linux-mm@kvack.org, maxime.coquelin@redhat.com, mcfadden8@llnl.gov, mcgrof@kernel.org, mgorman@suse.de, mike.kravetz@oracle.com, pbonzini@redhat.com, rppt@linux.vnet.ibm.com, xemul@virtuozzo.com, keescook@chromium.org Subject: Re: [PATCH v2 1/1] userfaultfd/sysctl: add vm.unprivileged_userfaultfd Message-ID: <20200528124919.GK1194141@xz-x1> References: <3b64de85-beb4-5a07-0093-cad6e8f2a8d8@huawei.com> <20200527142143.GC1194141@xz-x1> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, May 28, 2020 at 04:50:49PM +0800, Xiaoming Ni wrote: > Since userfaultfd and vm are more closely related, will there be > consideration to move fs/userfaultfd.c to the mm directory in the future? Xiaoming, I don't think so - userfaultfd is still interfacing the userspace as a file object, so I think it's proper to have fs/userfaultfd.c handles the fs part of userfaultfd. There's also an mm/userfaultfd.c which handles some internal logic of userfaultfd syscalls, please feel free to have a look. Thanks, -- Peter Xu