Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 28 May 2020 18:24:45 +0530
User-Agent: K-9 Mail for Android
In-Reply-To: <xmqqa71tmika.fsf@gitster.c.googlers.com>
References: <xmqqtv02mt2m.fsf@gitster.c.googlers.com> <e66ea483-5e7f-4ebd-5ba8-91227efa454a@gmail.com> <xmqqa71tmika.fsf@gitster.c.googlers.com>
MIME-Version: 1.0
Content-Type: text/plain;
 charset=utf-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [ANNOUNCE] Git v2.27.0-rc2
To:     Junio C Hamano <gitster@pobox.com>
CC:     git@vger.kernel.org, Linux Kernel <linux-kernel@vger.kernel.org>,
        git-packagers@googlegroups.com
From:   Kaartic Sivaraam <kaartic.sivaraam@gmail.com>
Message-ID: <DA3387FB-670A-4A36-9017-6D1372F9DBC2@gmail.com>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


On 27 May 2020 22:17:01 GMT+05:30, Junio C Hamano <gitster@pobox=2Ecom> wr=
ote:
>Kaartic Sivaraam <kaartic=2Esivaraam@gmail=2Ecom> writes:
>
>> Hi Junio,
>>
>> On 27-05-2020 00:17, Junio C Hamano wrote:
>>> Shourya Shukla (4):
>>>        submodule--helper=2Ec: Rename 'cb_foreach' to 'foreach_cb'
>>>        gitfaq: files in =2Egitignore are tracked
>>>        gitfaq: fetching and pulling a repository
>>>        submodule: port subcommand 'set-url' from shell to C
>>
>> This is the only place where the `set-url` conversion from Shell to C
>> is mentioned=2E I wonder if it's enough or if it needs a little bit
>more
>> attention may be in the "Performance, Internal Implementation,
>> Development Support etc=2E" as it is a conversion of a submodule
>> sub-command?
>
>I'm not sure if it is worth the bits=2E  It may matter _only_ if/when
>new implementaiton of set-url hurts the end-users by being buggy ;-)

OK=2E That makes sense=2E The converted version has gone through reviews a=
nd presumably it does pass our CI test cases=2E I think I was just trying t=
o overcautious to ensure we're not bitten by a worst case scenario wherein =
a bug slipped through the reviews and the tests=2E I believe it's pretty un=
likely, though :-)

--=20
Sivaraam

Sent from my Android device with K-9 Mail=2E Please excuse my brevity and =
possible "typso"=2E