Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 28 May 2020 09:09:16 -0500
From:   Josh Poimboeuf <jpoimboe@redhat.com>
To:     Matt Helsley <mhelsley@vmware.com>
Cc:     linux-kernel@vger.kernel.org,
        Peter Zijlstra <peterz@infradead.org>,
        Steven Rostedt <rostedt@goodmis.org>
Subject: Re: [RFC][PATCH 2/3] objtool: Find relocation base section using
 sh_info
Message-ID: <20200528140916.6crguzfpehf6lext@treble>
References: <cover.1590597288.git.mhelsley@vmware.com>
 <d848189dac6c41193a6c55c3588b78114bbcb0f8.1590597288.git.mhelsley@vmware.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <d848189dac6c41193a6c55c3588b78114bbcb0f8.1590597288.git.mhelsley@vmware.com>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Wed, May 27, 2020 at 09:42:32AM -0700, Matt Helsley wrote:
> Currently objtool uses a naming heuristic to find the "base"
> section to apply the relocation(s) to. The standard defines
> the SHF_INFO_LINK flag (SHF => in the section header flags)
> which indicates when the section header's sh_info field can
> be used to find the necessary section.
> 
> Warns when the heuristic is used as a fallback and changes
> the name heuristic calculation to handle rela (explicit
> addend) and now rel (implicit addend) relocations.

Does this fallback case actually happen?

-- 
Josh