Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 28 May 2020 09:24:14 -0500
From:   Josh Poimboeuf <jpoimboe@redhat.com>
To:     Matt Helsley <mhelsley@vmware.com>
Cc:     linux-kernel@vger.kernel.org,
        Peter Zijlstra <peterz@infradead.org>,
        Steven Rostedt <rostedt@goodmis.org>
Subject: Re: [RFC][PATCH 3/3] objtool: Add support for relocations without
 addends
Message-ID: <20200528142414.rzk5mvz4nwhsjcwp@treble>
References: <cover.1590597288.git.mhelsley@vmware.com>
 <933488b79c91ba040e68847fe53531fd97b18e07.1590597288.git.mhelsley@vmware.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <933488b79c91ba040e68847fe53531fd97b18e07.1590597288.git.mhelsley@vmware.com>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Wed, May 27, 2020 at 09:42:33AM -0700, Matt Helsley wrote:
> @@ -525,16 +556,8 @@ static int read_relocs(struct elf *elf)
>  				return -1;
>  			}
>  			memset(reloc, 0, sizeof(*reloc));
> -
> -			if (!gelf_getrela(sec->data, i, &reloc->rela)) {
> -				WARN_ELF("gelf_getrela");
> +			if (read_reloc(sec, i, reloc, &symndx))
>  				return -1;
> -			}

I try to avoid function pointers, them being slow and ugly and all.

Since it's just a single call site, I'd rather a direct call.  For
example, call read_reloc(), which has an if-then to decide which
subfunction to call.

-- 
Josh