Received: by 2002:a25:ef43:0:0:0:0:0 with SMTP id w3csp490734ybm; Thu, 28 May 2020 07:56:37 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx1El0DTOoP8V4FF3dNjuKEkdtGfOXsj2s8bSOdUmwJGOwB+Ghv7GmgioY5Smmi/vQsQeMZ X-Received: by 2002:a05:6402:1d2d:: with SMTP id dh13mr3403225edb.169.1590677797435; Thu, 28 May 2020 07:56:37 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1590677797; cv=none; d=google.com; s=arc-20160816; b=ov6AwiR27NlMGAl+CyNzT/9QXMarJi94xCTQ1TCVIYLrTM2nOGk0nfRh88HlzQ0fe4 79Oi+90TwMN3gNwUXDc/6qoiCXRHqSgiJXGWTyPjstbLJfic3We0MGonwHuYI9gYZh8j 9EFSAs0HjY0hcLL2Ewr4vsBwNLjmu1XY2McnquO4q1oFfF7mj4LrAcV+xwyEgpwegCtW NEG9+PYL53sWTDFRJzxJDJ48ctb+ejw9EcxlKU9Fr3Ep/h8u8fKQxhCayTbJx+HUNqNk bIRXuzoaqt5IYdbylC94QE1RALLjWKvSO9BkSwBvdpJbHt2Xc9a8sCQoWjwDu91LUxJF IUmA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:autocrypt:from:references:cc:to:subject; bh=cfzDVeenpvj+BZqV0/UhApIa8t7msOrP7Mg4fGDJbms=; b=0TLQiRmRvDpgInt2v/+uTXiPkSsbkvW+byvRroic/2GDQNcZgPcE3SNCSar3xZjYT5 MHr0JKMjgz1RBtE3YvshPQthFvprsjMBCxwjv8PQmNUp9Z32cq/9qMNx2WiaCq4bt42S qJUI0yMEknW63dXG3xb+SIwQokm7ytdvsLYo/He8g9mIb6oRDIz27scQHjPmePWl6M5p IHeZilFsObFsVqMuUbqQueao80W/2DbXgCFPsOzB9XkoNkMQbMc8X1pYX9P1Veo9YBom mtv8bZx/hhWgTwWDuGCft+UpwffYS5M+1d2fnn3EQXLVmYunf2B0FL9LHcM3tVnuIUZA dYkA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id h4si3741037ejk.9.2020.05.28.07.56.13; Thu, 28 May 2020 07:56:37 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2391370AbgE1Oxl (ORCPT + 99 others); Thu, 28 May 2020 10:53:41 -0400 Received: from mail-pg1-f195.google.com ([209.85.215.195]:44109 "EHLO mail-pg1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2391244AbgE1Oxi (ORCPT ); Thu, 28 May 2020 10:53:38 -0400 Received: by mail-pg1-f195.google.com with SMTP id p30so13561852pgl.11; Thu, 28 May 2020 07:53:37 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:autocrypt :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=cfzDVeenpvj+BZqV0/UhApIa8t7msOrP7Mg4fGDJbms=; b=aFu4DGMAKjLdV5kkQZKqVi9PDjp8s1ze+gdYXwwyva8l6MlIrnQ8kWtkrE4qW8jb3G NkD5d6Y+TR/Igxv3Ysb7xcLy30lSkALRDZRx2aCVcxWM2GBXpWd/mu4PUBFOFKIQzDnc tm2EbVUyZpBcT8Agpler1bsVaPgObiaM7wfixvlEkVuXEHJdiOz84HP5TqwmLfFmPq3e PXKCL1fQtmjZ4tH8YQ5GjvuLmMKYKYS4tjHax+6n1EB/Rzc56KyzC7iqim8VPDga67FB KE+0PQYloLcbyVT7x+6vmo9rkrUOGmT/2fzZVU3j/pbQ6jt6yRVb71cpnMXDABWXU/sh sY0w== X-Gm-Message-State: AOAM5300UDoUA1zGlnvTwIAMwoeQD8Qt5q0ZFvasL2HTDZPKAg+0AksQ doa8vfebl3vnvZWOwz/nhrYnaHSoU/8= X-Received: by 2002:a63:40a:: with SMTP id 10mr3383814pge.310.1590677616663; Thu, 28 May 2020 07:53:36 -0700 (PDT) Received: from ?IPv6:2601:647:4000:d7:40e6:aa88:9c03:e0b4? ([2601:647:4000:d7:40e6:aa88:9c03:e0b4]) by smtp.gmail.com with ESMTPSA id k92sm5799676pjh.2.2020.05.28.07.53.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 28 May 2020 07:53:35 -0700 (PDT) Subject: Re: [PATCH] sbp-target: add the missed kfree() in an error path To: Chris Boot Cc: Chuhong Yuan , "Martin K . Petersen" , Nicholas Bellinger , Stefan Richter , linux-scsi@vger.kernel.org, target-devel@vger.kernel.org, linux1394-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org References: <20200528102056.911825-1-hslester96@gmail.com> From: Bart Van Assche Autocrypt: addr=bvanassche@acm.org; prefer-encrypt=mutual; keydata= mQENBFSOu4oBCADcRWxVUvkkvRmmwTwIjIJvZOu6wNm+dz5AF4z0FHW2KNZL3oheO3P8UZWr LQOrCfRcK8e/sIs2Y2D3Lg/SL7qqbMehGEYcJptu6mKkywBfoYbtBkVoJ/jQsi2H0vBiiCOy fmxMHIPcYxaJdXxrOG2UO4B60Y/BzE6OrPDT44w4cZA9DH5xialliWU447Bts8TJNa3lZKS1 AvW1ZklbvJfAJJAwzDih35LxU2fcWbmhPa7EO2DCv/LM1B10GBB/oQB5kvlq4aA2PSIWkqz4 3SI5kCPSsygD6wKnbRsvNn2mIACva6VHdm62A7xel5dJRfpQjXj2snd1F/YNoNc66UUTABEB AAG0JEJhcnQgVmFuIEFzc2NoZSA8YnZhbmFzc2NoZUBhY20ub3JnPokBOQQTAQIAIwUCVI67 igIbAwcLCQgHAwIBBhUIAgkKCwQWAgMBAh4BAheAAAoJEHFcPTXFzhAJ8QkH/1AdXblKL65M Y1Zk1bYKnkAb4a98LxCPm/pJBilvci6boefwlBDZ2NZuuYWYgyrehMB5H+q+Kq4P0IBbTqTa jTPAANn62A6jwJ0FnCn6YaM9TZQjM1F7LoDX3v+oAkaoXuq0dQ4hnxQNu792bi6QyVdZUvKc macVFVgfK9n04mL7RzjO3f+X4midKt/s+G+IPr4DGlrq+WH27eDbpUR3aYRk8EgbgGKvQFdD CEBFJi+5ZKOArmJVBSk21RHDpqyz6Vit3rjep7c1SN8s7NhVi9cjkKmMDM7KYhXkWc10lKx2 RTkFI30rkDm4U+JpdAd2+tP3tjGf9AyGGinpzE2XY1K5AQ0EVI67igEIAKiSyd0nECrgz+H5 PcFDGYQpGDMTl8MOPCKw/F3diXPuj2eql4xSbAdbUCJzk2ETif5s3twT2ER8cUTEVOaCEUY3 eOiaFgQ+nGLx4BXqqGewikPJCe+UBjFnH1m2/IFn4T9jPZkV8xlkKmDUqMK5EV9n3eQLkn5g lco+FepTtmbkSCCjd91EfThVbNYpVQ5ZjdBCXN66CKyJDMJ85HVr5rmXG/nqriTh6cv1l1Js T7AFvvPjUPknS6d+BETMhTkbGzoyS+sywEsQAgA+BMCxBH4LvUmHYhpS+W6CiZ3ZMxjO8Hgc ++w1mLeRUvda3i4/U8wDT3SWuHcB3DWlcppECLkAEQEAAYkBHwQYAQIACQUCVI67igIbDAAK CRBxXD01xc4QCZ4dB/0QrnEasxjM0PGeXK5hcZMT9Eo998alUfn5XU0RQDYdwp6/kMEXMdmT oH0F0xB3SQ8WVSXA9rrc4EBvZruWQ+5/zjVrhhfUAx12CzL4oQ9Ro2k45daYaonKTANYG22y //x8dLe2Fv1By4SKGhmzwH87uXxbTJAUxiWIi1np0z3/RDnoVyfmfbbL1DY7zf2hYXLLzsJR mSsED/1nlJ9Oq5fALdNEPgDyPUerqHxcmIub+pF0AzJoYHK5punqpqfGmqPbjxrJLPJfHVKy goMj5DlBMoYqEgpbwdUYkH6QdizJJCur4icy8GUNbisFYABeoJ91pnD4IGei3MTdvINSZI5e Message-ID: <475e4f50-6d20-d653-8288-0676bc708bcc@acm.org> Date: Thu, 28 May 2020 07:53:34 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 MIME-Version: 1.0 In-Reply-To: <20200528102056.911825-1-hslester96@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2020-05-28 03:20, Chuhong Yuan wrote: > sbp_fetch_command() forgets to call kfree() in an error path. > Add the missed call to fix it. Hi Chris, The changelog of the code under drivers/target/sbp makes we wonder whether this driver has ever had any other users than its original author. Do you agree with this? If so, do you want to keep this driver in the kernel tree? Thanks, Bart.