Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: 00Ai3wkTbUDxmrkH4dhmlHIZbUlcINxTRtiRQuBsXpnY2QdQ1wLiJgPwir8H0TjySgf8ffAFY4
 0/6VMhR8BZ0POfTL1+d2jAOv8FcUUxvNw6YXvlgamYVWQKKcXGx0TFCNSrx8qPmaGaYYWXYrfB
 Eit67PO9E7NgXFapHOO+DB0HRSc5DU1w/OlsBkKzec7CK5ZHh7bogEFqzITxHGnOWVnhx48kIr
 U6LfWSuWN1mBnG4bhahaFCBA8zzORm5OcFHj+Y8COTloFL4BpfG7vvWJZ5uWCxpY/9Qaqzdiu2
 EdA=
From:   Avri Altman <Avri.Altman@wdc.com>
To:     Bean Huo <huobean@gmail.com>,
        "alim.akhtar@samsung.com" <alim.akhtar@samsung.com>,
        "asutoshd@codeaurora.org" <asutoshd@codeaurora.org>,
        "jejb@linux.ibm.com" <jejb@linux.ibm.com>,
        "martin.petersen@oracle.com" <martin.petersen@oracle.com>,
        "stanley.chu@mediatek.com" <stanley.chu@mediatek.com>,
        "beanhuo@micron.com" <beanhuo@micron.com>,
        "bvanassche@acm.org" <bvanassche@acm.org>,
        "tomas.winkler@intel.com" <tomas.winkler@intel.com>,
        "cang@codeaurora.org" <cang@codeaurora.org>
CC:     "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH v2 3/3] scsi: ufs: cleanup ufs initialization path
Thread-Topic: [PATCH v2 3/3] scsi: ufs: cleanup ufs initialization path
Thread-Index: AQHWNOcS9knWlNkkEEihSjLjCZj2TKi9j3+Q
Date:   Thu, 28 May 2020 14:58:22 +0000
Message-ID: <SN6PR04MB4640F8F4B293E6D3980952D5FC8E0@SN6PR04MB4640.namprd04.prod.outlook.com>
References: <20200528115616.9949-1-huobean@gmail.com>
 <20200528115616.9949-4-huobean@gmail.com>
In-Reply-To: <20200528115616.9949-4-huobean@gmail.com>
Accept-Language: en-US
Content-Language: en-US
wdcipoutbound: EOP-TRUE
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 0ef18296-6ed1-4cc9-f85e-08d803179119
X-MS-Exchange-CrossTenant-originalarrivaltime: 28 May 2020 14:58:22.5025
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: lvhL3Sspv8uG2Xr6e6oVYlLGCURGdVNSJN8KzNXDBwfCs8+2hEU6F3sxOF0v8xzEHP5aSG9k7qd5l8KiYLUiuA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR04MB5213
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi,

> From: Bean Huo <beanhuo@micron.com>
>=20
> At UFS initialization stage, to get the length of the descriptor,
> ufshcd_read_desc_length() being called 6 times.
May I suggest one more clarifying sentence to your commit log:
"Instead, we will capture the descriptor size the first time we'll read it.=
"

>This patch is to
> delete unnecessary reduntant code, remove ufshcd_read_desc_length()
typo: redundant

> and boost UFS initialization.
>=20
> Signed-off-by: Bean Huo <beanhuo@micron.com>

> +       if (desc_id >=3D QUERY_DESC_IDN_MAX) {
>                 *desc_len =3D 0;
>                 return -EINVAL;
>         }
if (desc_id =3D=3D QUERY_DESC_IDN_RFU_0 || desc_id =3D=3D QUERY_DESC_IDN_RF=
U_1)
	*desc_len =3D 0;
else
> +
> +       *desc_len =3D hba->desc_size[desc_id];
>         return 0;
>  }
>  EXPORT_SYMBOL(ufshcd_map_desc_id_to_length);
>=20
> +static void ufshcd_update_desc_length(struct ufs_hba *hba,
> +                                     enum desc_idn desc_id, int desc_len=
)
desc_len is at most 255 so maybe u8?

> +{
> +       if (hba->desc_size[desc_id] =3D=3D QUERY_DESC_MAX_SIZE &&
> +           desc_id !=3D QUERY_DESC_IDN_STRING)
> +               hba->desc_size[desc_id] =3D desc_len;
> +}
> +


Thanks,
Avri