Received: by 2002:a25:ef43:0:0:0:0:0 with SMTP id w3csp517563ybm; Thu, 28 May 2020 08:26:32 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy8WMeCEKWavaHLiJhxn6Btprzwi8JopJmtfec8B74kFqqZ0NcNDkOwQRkoR+NfJeLqPKhc X-Received: by 2002:a17:906:139a:: with SMTP id f26mr3422423ejc.267.1590679592591; Thu, 28 May 2020 08:26:32 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1590679592; cv=none; d=google.com; s=arc-20160816; b=k19EBJxVWPO5CPGtqLeMkuBiVQGN1r+OlbKXcLEQXNt52xWasFx3FWTX/YUPL6nNk1 lO/n2VfBI2PTFFWc5UXAWvdxeM2PDthxOfkbxd7PPL92uXPQjZ7/ipZ+C74IUiNXTM5h AeaHm5O1Tf/A/7oRPBz3O2ds41fKp4EX0GSA8m1VMa/y/tBIYhN5TIPBQnMAoOEz9XWh rPruEXc2VLn+FZFdgT5p1T7WZKZOaVEmjLBpyXRQCExwsu4A58iujgt5DHR0QC58c3LD tPWITYjzDquQQ3rO1poPmIEyHOEZTyp2maRh8vB8i6JzX1lTKBXpvWPcPNNIeQHceFRR lcYg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:content-transfer-encoding :dlp-product:dlp-reaction:dlp-version:content-language :accept-language:in-reply-to:references:message-id:date:thread-index :thread-topic:subject:cc:to:from:ironport-sdr:ironport-sdr; bh=i3j5TdZNC7WzvbcS0/+keDp3yI9rCHUWdmwDNPV5Tx8=; b=Y2i9POWMh6NZaXzYfDcqU6KBZ8m6XxuvWv+MkssQcwGssdKfYSsaAqtrZwC0ieS3I8 diIq4FHVeIIhYSd8Ja5cHVF2eQpCWK3OklMuLUMW/mxmAO5KEB6ST9C2yUTHwUBf6GgB HwhAJ65rdr56lXcvdGVvphsUS8PQL1E6JspznX9jAbduYMwvkyveJXpKqLHfmrnchCkj WpSlSRfigNHXV9Zl6HJbal7A74N+Yd8oJyEhzWbC1ZrvX7999vqxjKJHJf51uQDotBvV fCbKYLzP7ktd63Vh5SbyJFX8TlCablnreM7u1Q0rULwZTfDiPTKMs98L1aMkrkMgeMo4 OQRA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id k10si3786598edx.155.2020.05.28.08.26.09; Thu, 28 May 2020 08:26:32 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2404355AbgE1PVi convert rfc822-to-8bit (ORCPT + 99 others); Thu, 28 May 2020 11:21:38 -0400 Received: from mga17.intel.com ([192.55.52.151]:21665 "EHLO mga17.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2404271AbgE1PVh (ORCPT ); Thu, 28 May 2020 11:21:37 -0400 IronPort-SDR: +PrWkeR7NKbm099t4fJUvZ+lKP9z0oYEoVYWmLEm6QqHhulTcWq5V0XpJOXMbBv7sZFCepHtn4 SKVvYvZ4ghxA== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 May 2020 08:21:37 -0700 IronPort-SDR: 2StUYC0pcSlnqJlBdbSoTJnv84fYnfmJ21iYzmKquRBq+uXwQMWWmIDeuVWswkskwoSgfpyK06 Hqq7wjvK7ElQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,445,1583222400"; d="scan'208";a="256192753" Received: from orsmsx106.amr.corp.intel.com ([10.22.225.133]) by orsmga007.jf.intel.com with ESMTP; 28 May 2020 08:21:37 -0700 Received: from orsmsx155.amr.corp.intel.com (10.22.240.21) by ORSMSX106.amr.corp.intel.com (10.22.225.133) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 28 May 2020 08:21:36 -0700 Received: from orsmsx110.amr.corp.intel.com ([169.254.10.119]) by ORSMSX155.amr.corp.intel.com ([169.254.7.235]) with mapi id 14.03.0439.000; Thu, 28 May 2020 08:21:36 -0700 From: "Kleen, Andi" To: "Tang, Feng" , Qian Cai CC: Andrew Morton , Michal Hocko , Johannes Weiner , Stephen Rothwell , Matthew Wilcox , Mel Gorman , Kees Cook , Luis Chamberlain , Iurii Zaikin , "Chen, Tim C" , "Hansen, Dave" , "Huang, Ying" , "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" Subject: RE: [PATCH 0/3] make vm_committed_as_batch aware of vm overcommit policy Thread-Topic: [PATCH 0/3] make vm_committed_as_batch aware of vm overcommit policy Thread-Index: AQHWNQIlUjqwkSwmEkaddhwmrHfhIqi9nR5A Date: Thu, 28 May 2020 15:21:36 +0000 Message-ID: References: <1588922717-63697-1-git-send-email-feng.tang@intel.com> <20200521212726.GC6367@ovpn-112-192.phx2.redhat.com> <20200526181459.GD991@lca.pw> <20200527014647.GB93879@shbuild999.sh.intel.com> <20200527022539.GK991@lca.pw> <20200527104606.GE93879@shbuild999.sh.intel.com> <20200528141802.GB1810@lca.pw> <20200528151020.GF93879@shbuild999.sh.intel.com> In-Reply-To: <20200528151020.GF93879@shbuild999.sh.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.2.0.6 dlp-reaction: no-action dlp-product: dlpe-windows x-originating-ip: [10.22.254.139] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org >If it's true, then there could be 2 solutions, one is to skip the WARN_ONCE as it has no practical value, as the real >check is the following code, the other is to rectify the percpu counter when the policy is changing to >OVERCOMMIT_NEVER. I think it's better to fix it up when the policy changes. That's the right place. The WARN_ON might be useful to catch other bugs. -Andi