Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <29bd753d5ff5596425905b0b07f51153e2345cc1.1589297433.git.andreyknvl@google.com>
 <78a81fde6eeda9db72a7fd55fbc33173a515e4b1.1589297433.git.andreyknvl@google.com>
 <20200528134913.GA1810@lca.pw> <CAAeHK+zELpKm7QA7PCxRtvRDTCXpjef9wOcOuRwjc-RcT2HSiA@mail.gmail.com>
 <20200528151554.GC2702@lca.pw>
In-Reply-To: <20200528151554.GC2702@lca.pw>
From:   Andrey Konovalov <andreyknvl@google.com>
Date:   Thu, 28 May 2020 17:24:43 +0200
Message-ID: <CAAeHK+xKDJ-=GRDEoSNoaqbKcAYbEWS0a=Cg-_gijE7NXVWE_w@mail.gmail.com>
Subject: Re: [PATCH 2/3] kasan: move kasan_report() into report.c
To:     Qian Cai <cai@lca.pw>
Cc:     Andrew Morton <akpm@linux-foundation.org>,
        Andrey Ryabinin <aryabinin@virtuozzo.com>,
        Alexander Potapenko <glider@google.com>,
        Dmitry Vyukov <dvyukov@google.com>,
        kasan-dev <kasan-dev@googlegroups.com>,
        Linux Memory Management List <linux-mm@kvack.org>,
        LKML <linux-kernel@vger.kernel.org>,
        Leon Romanovsky <leonro@mellanox.com>,
        Leon Romanovsky <leon@kernel.org>,
        Randy Dunlap <rdunlap@infradead.org>,
        Josh Poimboeuf <jpoimboe@redhat.com>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Thu, May 28, 2020 at 5:15 PM Qian Cai <cai@lca.pw> wrote:
>
> On Thu, May 28, 2020 at 05:00:54PM +0200, 'Andrey Konovalov' via kasan-dev wrote:
> > On Thu, May 28, 2020 at 3:49 PM Qian Cai <cai@lca.pw> wrote:
> > >
> > > On Tue, May 12, 2020 at 05:33:20PM +0200, 'Andrey Konovalov' via kasan-dev wrote:
> > > > The kasan_report() functions belongs to report.c, as it's a common
> > > > functions that does error reporting.
> > > >
> > > > Reported-by: Leon Romanovsky <leon@kernel.org>
> > > > Signed-off-by: Andrey Konovalov <andreyknvl@google.com>
> > >
> > > Today's linux-next produced this with Clang 11.
> > >
> > > mm/kasan/report.o: warning: objtool: kasan_report()+0x8a: call to __stack_chk_fail() with UACCESS enabled
> > >
> > > kasan_report at mm/kasan/report.c:536
> >
> > Hm, the first patch in the series ("kasan: consistently disable
> > debugging features") disables stack protector for kasan files. Is that
> > patch in linux-next?
>
> Yes, it is there,
>
> +CFLAGS_report.o := $(call cc-option, -fno-conserve-stack -fno-stack-protector)
>
> It seems that will not work for Clang?

Ah, Clang doesn't have -fno-conserve-stack and that makes the whole
cc-option expression fail? OK, I'll send a fix.