Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <f1e1e76ca6deb796c1ccd432d4d4dd695b812320.camel@gmail.com>
Subject: Re: [PATCH v2 3/3] scsi: ufs: cleanup ufs initialization path
From:   Bean Huo <huobean@gmail.com>
To:     Avri Altman <Avri.Altman@wdc.com>,
        "alim.akhtar@samsung.com" <alim.akhtar@samsung.com>,
        "asutoshd@codeaurora.org" <asutoshd@codeaurora.org>,
        "jejb@linux.ibm.com" <jejb@linux.ibm.com>,
        "martin.petersen@oracle.com" <martin.petersen@oracle.com>,
        "stanley.chu@mediatek.com" <stanley.chu@mediatek.com>,
        "beanhuo@micron.com" <beanhuo@micron.com>,
        "bvanassche@acm.org" <bvanassche@acm.org>,
        "tomas.winkler@intel.com" <tomas.winkler@intel.com>,
        "cang@codeaurora.org" <cang@codeaurora.org>
Cc:     "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Date:   Thu, 28 May 2020 18:03:52 +0200
In-Reply-To: <SN6PR04MB4640F8F4B293E6D3980952D5FC8E0@SN6PR04MB4640.namprd04.prod.outlook.com>
References: <20200528115616.9949-1-huobean@gmail.com>
         <20200528115616.9949-4-huobean@gmail.com>
         <SN6PR04MB4640F8F4B293E6D3980952D5FC8E0@SN6PR04MB4640.namprd04.prod.outlook.com>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Thu, 2020-05-28 at 14:58 +0000, Avri Altman wrote:
> Hi,
> 
> > From: Bean Huo <beanhuo@micron.com>
> > 
> > At UFS initialization stage, to get the length of the descriptor,
> > ufshcd_read_desc_length() being called 6 times.
> 
> May I suggest one more clarifying sentence to your commit log:
> "Instead, we will capture the descriptor size the first time we'll
> read it."
> 
> > This patch is to
> > delete unnecessary reduntant code, remove ufshcd_read_desc_length()
> 
> typo: redundant

fixed.
> 
> > and boost UFS initialization.
> > 
> > Signed-off-by: Bean Huo <beanhuo@micron.com>
> > +       if (desc_id >= QUERY_DESC_IDN_MAX) {
> >                 *desc_len = 0;
> >                 return -EINVAL;
> >         }
> 
> if (desc_id == QUERY_DESC_IDN_RFU_0 || desc_id ==
> QUERY_DESC_IDN_RFU_1)
> 	*desc_len = 0;
> else
> > +
> > +       *desc_len = hba->desc_size[desc_id];
> >         return 0;
> >  }
> >  EXPORT_SYMBOL(ufshcd_map_desc_id_to_length);
> > 
> > +static void ufshcd_update_desc_length(struct ufs_hba *hba,
> > +                                     enum desc_idn desc_id, int
> > desc_len)
> 
> desc_len is at most 255 so maybe u8?
> 
Avri
thanks, it will be changed in next version.


Bean