Received: by 2002:a25:ef43:0:0:0:0:0 with SMTP id w3csp557600ybm; Thu, 28 May 2020 09:21:19 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyeQa7y/m9tti86cb+IZBy8SdoiiY9X1otqrvhJ68QRYWMbRFlCDUlpzpJsoo+eKWz4b83u X-Received: by 2002:aa7:d706:: with SMTP id t6mr4149379edq.210.1590682879458; Thu, 28 May 2020 09:21:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1590682879; cv=none; d=google.com; s=arc-20160816; b=FBhnGqKMc2Kazstzs8uDzB+Qt6BLW7LUWRUgHnI6fMEN6AdcCwSnYRVMft0buYjuHi WXYs3cFmPPqsOQjLJwDTNWpFy6p9WwChzZ4/u6FrqDWIwslHR2+SEFyANyyCM/5ZHJSw Qkaao+BpSeg5N5YJDpHUQEYETiUnU0Ronq1v5rKnWqeAKwAx/AHPbkrGVcUZYYl9oMmM SjBrk/Q6XpubxQW7G1MTR3XgCifNQ6HheBD2muUuy9hUChNNnFqlwqW+X+h/mX53a51o il49sJEsy4WPUq4RC6Kys1CVXU7SaRpWNKXXDIgR+HkN+bsfo9qdxvPdriFvUmM4LpdB lzKQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:autocrypt:from:references:cc:to:subject; bh=KfsbVj6z63bsl5JP4iMltZwaQmXOUwSJ85dsdEa49v0=; b=Uzls4MnsjEY3yNmjAVesAKuNLPskxwskMvy9i5n5dZtoi4Ga+GWqRmZ1FYmyHlRsen hsUrESRXpduqr/hD1xt1dioYL3kT7Kpx2/Qo8BHPSN8hU1o+oycSgMLjuAKYKRevILrT cGnK169hroyt02GMJwxiM45UdSlWzaGbvAHxQWsIRX+20erixFRzmp1uloP8vps0pVpQ EvKnwBbEaBcDr9o89rs59QkpO+GfqKXu3WetyyOSFhvlo3lp50jHFY/tH5v/5LEslw8/ KQ574ZSHnmvvNTpEy11K6ZpyCE2j76ICe84EYw8vZTSjQrhWCuPbIIIYVbb/DbusFsO3 xqUQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id u9si4061285ejb.268.2020.05.28.09.20.55; Thu, 28 May 2020 09:21:19 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2404987AbgE1QSg (ORCPT + 99 others); Thu, 28 May 2020 12:18:36 -0400 Received: from mail-pl1-f194.google.com ([209.85.214.194]:41731 "EHLO mail-pl1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2404830AbgE1QSe (ORCPT ); Thu, 28 May 2020 12:18:34 -0400 Received: by mail-pl1-f194.google.com with SMTP id a13so11745485pls.8; Thu, 28 May 2020 09:18:33 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:autocrypt :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=KfsbVj6z63bsl5JP4iMltZwaQmXOUwSJ85dsdEa49v0=; b=Q/gJa6Ofe8uHIf+UD/bW/tFXyUYXQtF977ngNyQZ3HOkxffijf/ZObUFsBYskdJPFZ QJXMCILWyLx5FRpwXqLfo3tkXPN0y4zbTH2ov8VObxLQRIA9049RWdiMaYnEWf6swvCG rYgozQ8Qy5Drp0y9l0+vtYndg1g56tsGbySqzJprUcydkdcJgqvMEtjL80/fpuWqvKZk xBplf1rVk9K2UiDcGPu7SiwMTw1rIF2+KA9lliRn6jzXxqfTqOOGc2tqh4ztk9odeGJs rFeInuWiHV+819Lnzz4QlhTJyakJovVCL1L0vCaeJD+1owwBbcdusRcynKKhAAum+V8i vOaw== X-Gm-Message-State: AOAM530wyDPG9BCDqAJmJS8ydvEnkgek0CFSsT/57eDs4Lhuqs5KsFgr LenmycZEXKyBgvZkiJh2YZ1eVvLKlYg= X-Received: by 2002:a17:90b:193:: with SMTP id t19mr4874703pjs.47.1590682712542; Thu, 28 May 2020 09:18:32 -0700 (PDT) Received: from ?IPv6:2601:647:4000:d7:40e6:aa88:9c03:e0b4? ([2601:647:4000:d7:40e6:aa88:9c03:e0b4]) by smtp.gmail.com with ESMTPSA id u26sm5137592pfn.88.2020.05.28.09.18.30 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 28 May 2020 09:18:31 -0700 (PDT) Subject: Re: [PATCH v2 3/3] scsi: ufs: cleanup ufs initialization path To: Avri Altman , Bean Huo , "alim.akhtar@samsung.com" , "asutoshd@codeaurora.org" , "jejb@linux.ibm.com" , "martin.petersen@oracle.com" , "stanley.chu@mediatek.com" , "beanhuo@micron.com" , "tomas.winkler@intel.com" , "cang@codeaurora.org" Cc: "linux-scsi@vger.kernel.org" , "linux-kernel@vger.kernel.org" References: <20200528115616.9949-1-huobean@gmail.com> <20200528115616.9949-4-huobean@gmail.com> From: Bart Van Assche Autocrypt: addr=bvanassche@acm.org; prefer-encrypt=mutual; keydata= mQENBFSOu4oBCADcRWxVUvkkvRmmwTwIjIJvZOu6wNm+dz5AF4z0FHW2KNZL3oheO3P8UZWr LQOrCfRcK8e/sIs2Y2D3Lg/SL7qqbMehGEYcJptu6mKkywBfoYbtBkVoJ/jQsi2H0vBiiCOy fmxMHIPcYxaJdXxrOG2UO4B60Y/BzE6OrPDT44w4cZA9DH5xialliWU447Bts8TJNa3lZKS1 AvW1ZklbvJfAJJAwzDih35LxU2fcWbmhPa7EO2DCv/LM1B10GBB/oQB5kvlq4aA2PSIWkqz4 3SI5kCPSsygD6wKnbRsvNn2mIACva6VHdm62A7xel5dJRfpQjXj2snd1F/YNoNc66UUTABEB AAG0JEJhcnQgVmFuIEFzc2NoZSA8YnZhbmFzc2NoZUBhY20ub3JnPokBOQQTAQIAIwUCVI67 igIbAwcLCQgHAwIBBhUIAgkKCwQWAgMBAh4BAheAAAoJEHFcPTXFzhAJ8QkH/1AdXblKL65M Y1Zk1bYKnkAb4a98LxCPm/pJBilvci6boefwlBDZ2NZuuYWYgyrehMB5H+q+Kq4P0IBbTqTa jTPAANn62A6jwJ0FnCn6YaM9TZQjM1F7LoDX3v+oAkaoXuq0dQ4hnxQNu792bi6QyVdZUvKc macVFVgfK9n04mL7RzjO3f+X4midKt/s+G+IPr4DGlrq+WH27eDbpUR3aYRk8EgbgGKvQFdD CEBFJi+5ZKOArmJVBSk21RHDpqyz6Vit3rjep7c1SN8s7NhVi9cjkKmMDM7KYhXkWc10lKx2 RTkFI30rkDm4U+JpdAd2+tP3tjGf9AyGGinpzE2XY1K5AQ0EVI67igEIAKiSyd0nECrgz+H5 PcFDGYQpGDMTl8MOPCKw/F3diXPuj2eql4xSbAdbUCJzk2ETif5s3twT2ER8cUTEVOaCEUY3 eOiaFgQ+nGLx4BXqqGewikPJCe+UBjFnH1m2/IFn4T9jPZkV8xlkKmDUqMK5EV9n3eQLkn5g lco+FepTtmbkSCCjd91EfThVbNYpVQ5ZjdBCXN66CKyJDMJ85HVr5rmXG/nqriTh6cv1l1Js T7AFvvPjUPknS6d+BETMhTkbGzoyS+sywEsQAgA+BMCxBH4LvUmHYhpS+W6CiZ3ZMxjO8Hgc ++w1mLeRUvda3i4/U8wDT3SWuHcB3DWlcppECLkAEQEAAYkBHwQYAQIACQUCVI67igIbDAAK CRBxXD01xc4QCZ4dB/0QrnEasxjM0PGeXK5hcZMT9Eo998alUfn5XU0RQDYdwp6/kMEXMdmT oH0F0xB3SQ8WVSXA9rrc4EBvZruWQ+5/zjVrhhfUAx12CzL4oQ9Ro2k45daYaonKTANYG22y //x8dLe2Fv1By4SKGhmzwH87uXxbTJAUxiWIi1np0z3/RDnoVyfmfbbL1DY7zf2hYXLLzsJR mSsED/1nlJ9Oq5fALdNEPgDyPUerqHxcmIub+pF0AzJoYHK5punqpqfGmqPbjxrJLPJfHVKy goMj5DlBMoYqEgpbwdUYkH6QdizJJCur4icy8GUNbisFYABeoJ91pnD4IGei3MTdvINSZI5e Message-ID: <0cc529a9-10a5-2ccd-055e-b9b2a47e5183@acm.org> Date: Thu, 28 May 2020 09:18:29 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2020-05-28 07:58, Avri Altman wrote: >> From: Bean Huo >> +static void ufshcd_update_desc_length(struct ufs_hba *hba, >> + enum desc_idn desc_id, int desc_len) > desc_len is at most 255 so maybe u8? At least on x86 using types like 'u8' for function arguments may lead to suboptimal code because it may cause the compiler to insert a widening instruction. How about changing 'int desc_len' into 'unsigned desc_len' instead? Thanks, Bart.