Received: by 2002:a25:ef43:0:0:0:0:0 with SMTP id w3csp577753ybm; Thu, 28 May 2020 09:51:57 -0700 (PDT) X-Google-Smtp-Source: ABdhPJze1/cC82WmVXvK5/nHMOi7TfqW7SColO+5oAfVf9zOyuSvUq9rwAC2UCdFE1HTrh2vBctN X-Received: by 2002:a50:fd83:: with SMTP id o3mr3968387edt.329.1590684717646; Thu, 28 May 2020 09:51:57 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1590684717; cv=none; d=google.com; s=arc-20160816; b=FFvGMwSEApJmNueAaa2ezT0pBrW0VZftlUvw+MczpOY+KxefPAUT5pd9qH6eTmfxtF U3Mf2RM00CnZ0bnZ0uZoxFplx8O4IvtrWxxjfYboxBygjdOrSstmdR0O67Z4ZfcEHD8H ZL9sIzhZEGLQFBEbZNdjLKxIldLkPHlr7vdFNeQN8Gg81AkFr25GBy0Jt/ml6KgxIkHp dOYmlUkohGS/u7bMOpSnkuzuP3KEI0NNRa0GbuR2Ijp2PCS0Wbm8TU8yX1Bf3vp3LaWn uKdQPYs04U/m27kxdi2c4w5+gEIPT8ruSCjUkmzQwTx1fQnbdYoY6Fk1Ikp5ljKJpxLm MNbg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-language :content-transfer-encoding:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:dmarc-filter :dkim-signature; bh=X89xsDaOFRdGrU4xaHY0/NaYtl9HOEBQ8tbCfVlGxxI=; b=W0GhwQMCyRF2nX9KecFEl4XVKZxlbwVIL63b049rR5lZpVqMF32SiUjSpZeRyCjtES r7Gsk2pVp1lwC65K6QbFLPun6tyhioXJcsV0Zj0n8HI6cQOwLSAUeA3FTCzjQGxdWeFZ DSZb1ieI1/yqqDXwT5hpGG8Jxgtbngi79oNdn0UGX/vAG8PZ5aswUqdf440x9yUKDn/I f7smUI5y0EL/FWwsGTpCNAxcAc08+662bYCyS5cTLXaE5ERc68k9P3rrHZjNbYn2Yyqc aqkFzlv1TCoLARWBsem5h2oFr9Cs5TdGzNhQ/D5GDWAPG77eSA2FphqKYcKyvM27sadD Mvxg== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@mg.codeaurora.org header.s=smtp header.b=FRA9EyaY; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id t15si4188445edy.62.2020.05.28.09.51.33; Thu, 28 May 2020 09:51:57 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=fail header.i=@mg.codeaurora.org header.s=smtp header.b=FRA9EyaY; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2405105AbgE1Qtn (ORCPT + 99 others); Thu, 28 May 2020 12:49:43 -0400 Received: from mail27.static.mailgun.info ([104.130.122.27]:34282 "EHLO mail27.static.mailgun.info" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2405116AbgE1Qth (ORCPT ); Thu, 28 May 2020 12:49:37 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1590684577; h=Content-Transfer-Encoding: Content-Type: In-Reply-To: MIME-Version: Date: Message-ID: From: References: Cc: To: Subject: Sender; bh=X89xsDaOFRdGrU4xaHY0/NaYtl9HOEBQ8tbCfVlGxxI=; b=FRA9EyaYQmNGpj1qMmeeuxMHKOe7h8l+Xx0LJtXChjhw9kczCzgKHTjBh4yjWFsaH7IGW7dy ofrdSdXmiMaDv8/NnNRBDDL7uhw4BCi2uL4ZLv0NBECll7rAHhVyiXfKdzjbXVd3bhmLEecz qkW0U56lyo2wA/LeM9mBqsRxa+M= X-Mailgun-Sending-Ip: 104.130.122.27 X-Mailgun-Sid: WyI0MWYwYSIsICJsaW51eC1rZXJuZWxAdmdlci5rZXJuZWwub3JnIiwgImJlOWU0YSJd Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n04.prod.us-west-2.postgun.com with SMTP id 5ecfeb9cbf0e32d254271083 (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Thu, 28 May 2020 16:49:32 GMT Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 314F0C433CA; Thu, 28 May 2020 16:49:32 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-caf-mail-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=2.0 tests=ALL_TRUSTED,SPF_NONE autolearn=unavailable autolearn_force=no version=3.4.0 Received: from [192.168.1.102] (unknown [157.47.99.82]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: jprakash) by smtp.codeaurora.org (Postfix) with ESMTPSA id 33BCAC433C9; Thu, 28 May 2020 16:49:09 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 33BCAC433C9 Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=none smtp.mailfrom=jprakash@codeaurora.org Subject: Re: [PATCH V5 5/5] iio: adc: Clean up ADC code common to PMIC5 and PMIC7 To: Andy Shevchenko Cc: agross@kernel.org, Bjorn Andersson , devicetree , Linux Kernel Mailing List , Matthias Kaehlcke , Linus Walleij , Jonathan Cameron , Amit Kucheria , smohanad@codeaurora.org, kgunda@codeaurora.org, aghayal@codeaurora.org, Jonathan Cameron , Hartmut Knaack , Lars-Peter Clausen , Peter Meerwald-Stadler , linux-arm-msm@vger.kernel.org, linux-iio , linux-arm-msm-owner@vger.kernel.org References: <1590157452-27179-1-git-send-email-jprakash@codeaurora.org> <1590157452-27179-6-git-send-email-jprakash@codeaurora.org> From: Jishnu Prakash Message-ID: <96c607e2-59e0-0d7b-92b4-5baa86c19ac2@codeaurora.org> Date: Thu, 28 May 2020 22:19:01 +0530 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Andy, On 5/22/2020 9:11 PM, Andy Shevchenko wrote: > On Fri, May 22, 2020 at 5:25 PM Jishnu Prakash wrote: >> This commit includes the following changes: >> >> Add a common function used for read_raw callback for both PMIC5 >> and PMIC7 ADCs. >> >> Add exit function for ADC. >> >> Add info_property under adc_data to more efficiently distinguish >> PMIC5 and PMIC7 ADCs. > ... > >> - if (of_device_is_compatible(node, "qcom,spmi-adc7")) >> - indio_dev->info = &adc7_info; >> - else >> - indio_dev->info = &adc5_info; >> + platform_set_drvdata(pdev, adc); > Ping-pong style of series. Can we convert to .info before we introduce > above check for compatibility? Yes, I'll add the .info property in a different patch before adding the PMIC7 support, that way it can be used directly instead of the above check being removed. > >