Received: by 2002:a25:ef43:0:0:0:0:0 with SMTP id w3csp604756ybm; Thu, 28 May 2020 10:30:02 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxDIqf9GlwOTU50Y7E9W1WX3zZQYZKg7mJUB3vmk1PV3aApx8J3s+ut3FMdU8BsukAIx09Y X-Received: by 2002:a50:8707:: with SMTP id i7mr4223227edb.180.1590687002825; Thu, 28 May 2020 10:30:02 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1590687002; cv=none; d=google.com; s=arc-20160816; b=jK9scxvkrbFmqUPSFsReltchEWTV+uFbV9Q45pAGNK220bYbyDog/Gi4tUoYTJNfYt ggwnR1EwkD8slKN67VJgxckzRXwRuQIlznQO2tNz2ACPygtxFd4H6sM6xQZGWgFtsw/Z uuPnwcDOgUwNNGLk8s1TeHHrqeOIjwytdynZzq5DYKMGbfvr0ISEzDdn7vjOgGFczih+ 7jZEfYVQj45+btWTbax2Ngg7SwTUZ/igKYn2afQIUW/MA4HCHSA1HDymK8HWNvcTpDjX /RzKyxN+fabpwMtMuXbkITMP11HEpgZhNFLDm4p3J8JJkbVGYfzdURqorNRWMPKHkotU +bHg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=TT6iOUCDTdCEqWX5uOCC84ONMr6eORo4r3zov95wBEY=; b=luikhVIlj5W1w5qdsj1IwEKEBJmZehSg0ygCPB3ge7KzVuw78gQ9bAprpjRgK+SsDg Dumoyif+88MLkgyPjggBa2OgU7upWqVVZOF6Mrgy5eAbueIYF9h1p363YxtE8reql28x 4xGgg8ngzmaknH2W+92SRlz/scRI7sxQ+pQGr0G3GTQQkLQ1Zr0pkIPsDK+Hyl08dKjE rViXxKdGUSWzBSkFbNlvgpysCn+/NQqxqHjeVvLfr0k5Upul4z2eig+GvTA8bBKghJwR 5Ko2nnFkQBh520m9ZMAJNYKVdzo5vi4eGhmUEwKDtG6TQKP+BP646smjhyNV7LrVC5mj kbmA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@alien8.de header.s=dkim header.b=cEy5CSts; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=alien8.de Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id d12si4241923ejb.308.2020.05.28.10.29.36; Thu, 28 May 2020 10:30:02 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@alien8.de header.s=dkim header.b=cEy5CSts; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=alien8.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2405589AbgE1R1b (ORCPT + 99 others); Thu, 28 May 2020 13:27:31 -0400 Received: from mail.skyhub.de ([5.9.137.197]:58696 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2405523AbgE1R1a (ORCPT ); Thu, 28 May 2020 13:27:30 -0400 Received: from zn.tnic (p200300ec2f0be200582218a51ad225b9.dip0.t-ipconnect.de [IPv6:2003:ec:2f0b:e200:5822:18a5:1ad2:25b9]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id B7AC01EC0322; Thu, 28 May 2020 19:27:28 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1590686848; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=TT6iOUCDTdCEqWX5uOCC84ONMr6eORo4r3zov95wBEY=; b=cEy5CStsvFUpS3c8QX8E6GDBXFZozwm56VfXCuDEjedD3oCuJf43tUzWSnT/yqDzbGPolg lg9VGXXFMG8CAluTzZ2tynq5fHHOuRiu0AxQNNaAYa1BDHD+pFlqO/IPNIAO/CGKGfW9Z5 e+qwPlZJSNd+N4yjjfNHkx6IYls5d/w= Date: Thu, 28 May 2020 19:27:24 +0200 From: Borislav Petkov To: Sean Christopherson Cc: Jarkko Sakkinen , linux-kernel@vger.kernel.org, x86@kernel.org, linux-sgx@vger.kernel.org, akpm@linux-foundation.org, dave.hansen@intel.com, nhorman@redhat.com, npmccallum@redhat.com, haitao.huang@intel.com, andriy.shevchenko@linux.intel.com, tglx@linutronix.de, kai.svahn@intel.com, josh@joshtriplett.org, luto@kernel.org, kai.huang@intel.com, rientjes@google.com, cedric.xing@intel.com, puiterwijk@redhat.com, Jethro Beekman Subject: Re: [PATCH v30 08/20] x86/sgx: Add functions to allocate and free EPC pages Message-ID: <20200528172724.GC382@zn.tnic> References: <20200515004410.723949-1-jarkko.sakkinen@linux.intel.com> <20200515004410.723949-9-jarkko.sakkinen@linux.intel.com> <20200526125207.GE28228@zn.tnic> <20200527042111.GI31696@linux.intel.com> <20200527204638.GG1721@zn.tnic> <20200528012319.GA7577@linux.intel.com> <20200528013617.GD25962@linux.intel.com> <20200528065223.GB188849@linux.intel.com> <20200528171635.GB382@zn.tnic> <20200528171937.GB30353@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20200528171937.GB30353@linux.intel.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, May 28, 2020 at 10:19:37AM -0700, Sean Christopherson wrote: > On Thu, May 28, 2020 at 07:16:35PM +0200, Borislav Petkov wrote: > > * sgx_alloc_page - allocates an EPC page > > Did you want this to be sgx_alloc_epc_page? Whatever you guys prefer. I'd use "sgx_alloc_page" because it returns struct sgx_epc_page * but having "epc" in the name makes it even more explicit so either is just fine. Thx. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette