Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 28 May 2020 12:15:50 -0700
From:   Matt Helsley <mhelsley@vmware.com>
To:     Josh Poimboeuf <jpoimboe@redhat.com>
CC:     <linux-kernel@vger.kernel.org>,
        Peter Zijlstra <peterz@infradead.org>,
        Steven Rostedt <rostedt@goodmis.org>
Subject: Re: [RFC][PATCH 2/3] objtool: Find relocation base section using
 sh_info
Message-ID: <20200528191550.GY9040@rlwimi.vmware.com>
Mail-Followup-To: Matt Helsley <mhelsley@vmware.com>,
        Josh Poimboeuf <jpoimboe@redhat.com>, linux-kernel@vger.kernel.org,
        Peter Zijlstra <peterz@infradead.org>,
        Steven Rostedt <rostedt@goodmis.org>
References: <cover.1590597288.git.mhelsley@vmware.com>
 <d848189dac6c41193a6c55c3588b78114bbcb0f8.1590597288.git.mhelsley@vmware.com>
 <20200528140916.6crguzfpehf6lext@treble>
 <20200528160247.GW9040@rlwimi.vmware.com>
 <20200528170010.xe46x3tvz4npvovj@treble>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20200528170010.xe46x3tvz4npvovj@treble>
Received-SPF: None (EX13-EDG-OU-002.vmware.com: mhelsley@vmware.com does not
 designate permitted sender hosts)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Thu, May 28, 2020 at 12:00:10PM -0500, Josh Poimboeuf wrote:
> On Thu, May 28, 2020 at 09:02:47AM -0700, Matt Helsley wrote:
> > On Thu, May 28, 2020 at 09:09:16AM -0500, Josh Poimboeuf wrote:
> > > On Wed, May 27, 2020 at 09:42:32AM -0700, Matt Helsley wrote:
> > > > Currently objtool uses a naming heuristic to find the "base"
> > > > section to apply the relocation(s) to. The standard defines
> > > > the SHF_INFO_LINK flag (SHF => in the section header flags)
> > > > which indicates when the section header's sh_info field can
> > > > be used to find the necessary section.
> > > > 
> > > > Warns when the heuristic is used as a fallback and changes
> > > > the name heuristic calculation to handle rela (explicit
> > > > addend) and now rel (implicit addend) relocations.
> > > 
> > > Does this fallback case actually happen?
> > 
> > Not that I could see. I was thinking about taking it out but
> > I haven't tried this set with clang or other toolchains. So
> > I was wondering if you think holding off before removing it
> > would be wise or if you'd rather just remove it.
> 
> I just realized somebody already submitted an almost identical patch:
> 
>   https://lkml.kernel.org/r/20200421182501.149101-1-samitolvanen@google.com
> 
> Which I'll be merging soon... so you can just drop this one.

OK, I'll drop this patch.

Cheers,
	-Matt