Received: by 2002:a25:ef43:0:0:0:0:0 with SMTP id w3csp689207ybm; Thu, 28 May 2020 12:39:58 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz8hs/KwW1bsygAkscPh8D4Dgl3rD9f2LPmkUrPjGaH+OouPLmcIJHn6yEqY+C49jgAOHPo X-Received: by 2002:a17:906:4442:: with SMTP id i2mr4823011ejp.509.1590694798501; Thu, 28 May 2020 12:39:58 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1590694798; cv=none; d=google.com; s=arc-20160816; b=n7XAphMKEA7BWo97FQpMzsnTCK3d0/rLQfkxOFUFhGD14XZymuSl9+p58p1EJTkNdL 0xlM4T7Ob3GdlK6ZQnwUE6XFfkKDOBx1kP3GxB4NTbXzbYp/L84n/PVi7KSOibPZZ7m3 d5Mtp3wmDjEkRdBKiW8VzUdD2L+fLdGjiLmx47Gk/a/vJmEGIp/eJGQAbxgL4pDO2x0e tdk7PSeJasgPTRB3SjQeW2xcrkSyNTrpDHKIzrZJwyBjtl/yCyePbOwKmkXB2fFPpaCg +E7OCKXNVObQmEiVK42J4Qq+rmEi3t7ldij2TDu4WQE0ZodkJxOdZdNm1BonkoP7OBMN 6ZeQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=LQMdgZ0vTXsQeu/SrBScEVdmWLwOzVm20o5DiCb8Itg=; b=agHAlSe/FAxLsG5p3yaxYpTQY2DH5TJjUawP3U2pI4mz4l+EJHaMafC4/bb9ndPVRQ HJrpJ+rQvSAxQoMD4uJzkbx8jB8JqP306CKyd9SEEHAgBsH3XUZvkgD8mehZ1NbkWys0 0fuALbi/DT2YK8fRtK0B+fFAE+/tA46JhPA5VnoapzsBKuP92LbCfrA4pt3YM3ET1OaO T4hmwr0Jd830WKLupRqo4GlkRgXZUMZe8eCUhbs5k+D47IJiCbG8GjQZ6bCM/jFTotHK Vdnhp+FgWV4fRbM8k3xTNj0uXF/q2lyfaaRLJallHwwqli8/E+q4sUF2SQBI2/1JXhsd MKcA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=zNztFQPN; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id se24si4397403ejb.652.2020.05.28.12.39.35; Thu, 28 May 2020 12:39:58 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=zNztFQPN; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2406656AbgE1TfN (ORCPT + 99 others); Thu, 28 May 2020 15:35:13 -0400 Received: from mail.kernel.org ([198.145.29.99]:58016 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2406647AbgE1TfI (ORCPT ); Thu, 28 May 2020 15:35:08 -0400 Received: from kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net (unknown [163.114.132.6]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 6936A2078C; Thu, 28 May 2020 19:35:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1590694507; bh=OWLKCU7KQGNacnB15hHj6riNDAs958qPxB6r1+7vpiA=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=zNztFQPNPfdwkX38qiOCaeviJApt7/pupinol4AlwxiOHdYbDQzgoX/mP7c96myzf W3nNb1HHGaBFCIuubWJFACKdwwD2uXJJz/WW7tyFgSzUxRSwbqn/4VufQAxYLf7eON 8nhTXLmBDCD0rWHCXMRL81JAZFgyA+0YfGDi4gao= Date: Thu, 28 May 2020 12:35:05 -0700 From: Jakub Kicinski To: Ronak Doshi Cc: , "VMware, Inc." , "David S. Miller" , open list Subject: Re: [PATCH v2 net-next 3/4] vmxnet3: add geneve and vxlan tunnel offload support Message-ID: <20200528123505.25baf888@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net> In-Reply-To: <20200528183615.27212-4-doshir@vmware.com> References: <20200528183615.27212-1-doshir@vmware.com> <20200528183615.27212-4-doshir@vmware.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 28 May 2020 11:36:14 -0700 Ronak Doshi wrote: > @@ -1168,13 +1220,21 @@ vmxnet3_rx_csum(struct vmxnet3_adapter *adapter, > (le32_to_cpu(gdesc->dword[3]) & > VMXNET3_RCD_CSUM_OK) == VMXNET3_RCD_CSUM_OK) { > skb->ip_summed = CHECKSUM_UNNECESSARY; > - BUG_ON(!(gdesc->rcd.tcp || gdesc->rcd.udp)); > - BUG_ON(gdesc->rcd.frg); > + BUG_ON(!(gdesc->rcd.tcp || gdesc->rcd.udp) && > + !(le32_to_cpu(gdesc->dword[0]) & > + (1UL << VMXNET3_RCD_HDR_INNER_SHIFT))); > + BUG_ON(gdesc->rcd.frg && > + !(le32_to_cpu(gdesc->dword[0]) & > + (1UL << VMXNET3_RCD_HDR_INNER_SHIFT))); > } else if (gdesc->rcd.v6 && (le32_to_cpu(gdesc->dword[3]) & > (1 << VMXNET3_RCD_TUC_SHIFT))) { > skb->ip_summed = CHECKSUM_UNNECESSARY; > - BUG_ON(!(gdesc->rcd.tcp || gdesc->rcd.udp)); > - BUG_ON(gdesc->rcd.frg); > + BUG_ON(!(gdesc->rcd.tcp || gdesc->rcd.udp) && > + !(le32_to_cpu(gdesc->dword[0]) & > + (1UL << VMXNET3_RCD_HDR_INNER_SHIFT))); > + BUG_ON(gdesc->rcd.frg && > + !(le32_to_cpu(gdesc->dword[0]) & > + (1UL << VMXNET3_RCD_HDR_INNER_SHIFT))); > } else { > if (gdesc->rcd.csum) { > skb->csum = htons(gdesc->rcd.csum); Seems fairly extreme to trigger BUG_ONs if rx descriptor doesn't contain valid checksum offload flags :S WARN_ON_ONCE() and ignore checsum or drop packet would be more than sufficient.