Received: by 2002:a25:ef43:0:0:0:0:0 with SMTP id w3csp696106ybm; Thu, 28 May 2020 12:51:34 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwEwuCNtJXne9nMJZRNoxDNe60H3LX2jIt63atKfOrpljbWpFlTo+Iejt6J/5hsyWrao+EG X-Received: by 2002:a50:fa8d:: with SMTP id w13mr4697264edr.280.1590695494163; Thu, 28 May 2020 12:51:34 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1590695494; cv=none; d=google.com; s=arc-20160816; b=SSB+mrKp9AX6f38da/RRLp1RY9qEmPUidmS7qDAs6i2WphYyTklJLPtEx2XY/WORlw 4aviv3YBt8f9s/iVJkmJmWx6mFEQMpo/oWB/MNd61Hg9ZczssL2681HJZDHchbhgWr/l V1UGB5t7IyeE+43wZK1/e6aBNWJ2wjVo7F/jzImo2ZyHPcM3MyGR+dzUMJnwcP5RYBhK nrnZNiZAdqRrBk6LnLPB0/27PTnA/qPP2acNlCZq8z9cZlOj0obGUceIB5PJB1Iv5546 iln43JXL1fopWc9EakMxMwqbLPGI/dk+FMDmgybHvEBpirNiYFpW7QFV+0VX/H9NTO2+ Qeng== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date :dkim-signature; bh=ukUKsMQtJQ/POklgv6hxv6yQhdAjZ+dAaodZMEeHyDI=; b=Tsr6YJQ+PGvWyEO8fDi8bq9InJy1r9/fvOW1IPDGWNTRUiLWCLUvoX7ZDJYNPlW66f S+TebAAkXtRz2y45tVvqELYcTImbT3njym/qQ1Gqvf6386nt5hOzLoKwF/vq+a8AgGhV MZXYkgpIh6XaEOIl6rSI0rUXAfoYEGBQk05yB0Ut6lU0E95gmV1/2BgIFrXlSr9RPyey lsveOmkUgvZScdwh/LbE9kHYSZfKvEHTN/tTYqTwKrpVDcQzKgDNnY/h6d3bbi5T5fA1 +Jc/KDYJxwYlBna73WrUORyLeH3pdCOQae9jlwvVhAnL9qLmStpaEoTwIqRTGJnL2GNo fj7A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=eVSemKwO; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id lu4si4520274ejb.19.2020.05.28.12.51.10; Thu, 28 May 2020 12:51:34 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=eVSemKwO; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2406761AbgE1TsV (ORCPT + 99 others); Thu, 28 May 2020 15:48:21 -0400 Received: from us-smtp-1.mimecast.com ([207.211.31.81]:55694 "EHLO us-smtp-delivery-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1728525AbgE1TsC (ORCPT ); Thu, 28 May 2020 15:48:02 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1590695280; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ukUKsMQtJQ/POklgv6hxv6yQhdAjZ+dAaodZMEeHyDI=; b=eVSemKwO6kCTNHyF+POjTM7ZDuWYK7xdfwJFzW1kFGRUnZ/ztHDlUHvafuYxmIvrTVJ7TK KO9dyGnLvvy4NgmxqfRAnTfKpisRB5ieQbm2ZLV7LMqp1NQ2Cl7gPxF35F2NbQ+Vlrr2pp YduXOhIhiJKOpLs5rlgJLD/GTgk/ncU= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-257-FB6j3GvTObqL524yhdStPg-1; Thu, 28 May 2020 15:47:58 -0400 X-MC-Unique: FB6j3GvTObqL524yhdStPg-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id D0759EC1A0; Thu, 28 May 2020 19:47:55 +0000 (UTC) Received: from localhost (unknown [10.10.110.53]) by smtp.corp.redhat.com (Postfix) with ESMTP id 664A19F9BA; Thu, 28 May 2020 19:47:52 +0000 (UTC) Date: Thu, 28 May 2020 12:47:51 -0700 (PDT) Message-Id: <20200528.124751.1622700747294014742.davem@redhat.com> To: jonas.falkevik@gmail.com Cc: marcelo.leitner@gmail.com, lucien.xin@gmail.com, nhorman@tuxdriver.com, vyasevich@gmail.com, kuba@kernel.org, linux-sctp@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] sctp: check assoc before SCTP_ADDR_{MADE_PRIM,ADDED} event From: David Miller In-Reply-To: <20200527095640.270986-1-jonas.falkevik@gmail.com> References: <20200527095640.270986-1-jonas.falkevik@gmail.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Jonas Falkevik Date: Wed, 27 May 2020 11:56:40 +0200 > Make sure SCTP_ADDR_{MADE_PRIM,ADDED} are sent only for associations > that have been established. > > These events are described in rfc6458#section-6.1 > SCTP_PEER_ADDR_CHANGE: > This tag indicates that an address that is > part of an existing association has experienced a change of > state (e.g., a failure or return to service of the reachability > of an endpoint via a specific transport address). > > Signed-off-by: Jonas Falkevik > --- > Changes in v2: > - Check asoc state to be at least established. > Instead of associd being SCTP_FUTURE_ASSOC. > - Common check for all peer addr change event Applied and queued up for -stable, thanks.