Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <1585313122-26441-1-git-send-email-alan.maguire@oracle.com> <1585313122-26441-3-git-send-email-alan.maguire@oracle.com>
In-Reply-To: <1585313122-26441-3-git-send-email-alan.maguire@oracle.com>
From:   Brendan Higgins <brendanhiggins@google.com>
Date:   Thu, 28 May 2020 12:47:43 -0700
Message-ID: <CAFd5g46uNRwDnKHjukU2gBu6wM0kzBragaWBJigbfJkFuQvsFw@mail.gmail.com>
Subject: Re: [PATCH v3 kunit-next 2/2] kunit: add support for named resources
To:     Alan Maguire <alan.maguire@oracle.com>
Cc:     shuah <shuah@kernel.org>,
        Patricia Alfonso <trishalfonso@google.com>,
        "open list:KERNEL SELFTEST FRAMEWORK" 
        <linux-kselftest@vger.kernel.org>,
        KUnit Development <kunit-dev@googlegroups.com>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Fri, Mar 27, 2020 at 5:46 AM Alan Maguire <alan.maguire@oracle.com> wrote:
>
> The kunit resources API allows for custom initialization and
> cleanup code (init/fini); here a new resource add function sets
> the "struct kunit_resource" "name" field, and calls the standard
> add function.  Having a simple way to name resources is
> useful in cases such as multithreaded tests where a set of
> resources are shared among threads; a pointer to the
> "struct kunit *" test state then is all that is needed to
> retrieve and use named resources.  Support is provided to add,
> find and destroy named resources; the latter two are simply
> wrappers that use a "match-by-name" callback.
>
> If an attempt to add a resource with a name that already exists
> is made kunit_add_named_resource() will return -EEXIST.
>
> Signed-off-by: Alan Maguire <alan.maguire@oracle.com>

FYI, I already gave a reviewed-by for this commit back in v1, so:

Reviewed-by: Brendan Higgins <brendanhiggins@google.com>