Received: by 2002:a25:ef43:0:0:0:0:0 with SMTP id w3csp716518ybm; Thu, 28 May 2020 13:18:08 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw646W7/wTp1bVCsFBGsoDEeiP/TcLIENQ0fXUOyk5IC8X9f27FXPDSQkZ8di96vneCkwQn X-Received: by 2002:aa7:dad0:: with SMTP id x16mr5119759eds.354.1590697088089; Thu, 28 May 2020 13:18:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1590697088; cv=none; d=google.com; s=arc-20160816; b=uEWDgss3r9+uHFoauJLe+BPLuGvRfjxcgFiNm63axhTry0IOjm1a2014E/Aehl4rje 2KBtkR2mRY2f7apZYfrEWCnnf7sY1k9/SgzI8g8LIEkPP7F+SaDc1NFcJ+JnMMWZSqLw V4xqJNfDwxrcylHXT4SITVJwM8QrjusU3H6S6OwrdkmRW9YpLkjplsch0XDI5ilHkWZu OLufrZXiG2pw7KpLydRN7YeJaYrBUdByIVHQiOP3KbZgMMJkM7zhSFzvRQkEI1L8299v /CD98Y/XidUBILR5ztqANCCQSwsJVnxSC3azIJNMZJclwfQou72LWXXNb3LPLqAQ69Xd /8tA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=rHGdRnuyS2BqV23VUrMV0RqVdXd2i2Nm6oPpVn8paw4=; b=ZbedJUaSGpE1lkIqwJdwlHiMHcNyPpuJdK9zcwz2VEFSExeGKJaMpVeL9xmvS4Bbx3 eVt8Hp1l7tiVa1J99kdeJxIA/xxfEg19STCtNJ3SOoOZW4K5J4rOQsMhJ+RxcWFDhqAh GL7ttzlH9sqyq9R4ggvcUMO8+/Dt4R8ZZ94sHGHa097XkxuC+VfECxT7+3CuDJAVdiai Z56gFd9hUmp9VrSxpWoevGAqIYvPGZCn6BUQi2C+IVs1lAk405FACrerXH2QBmO9YmkP SPz0lAC9Uku4OB0TC4xW0GB3Lp1L6MfiIfpN96vZJsA8XSetMZUgdOyiRa9+Qj4s2rvv H4jA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=QQgLU7e3; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id w22si4252671eds.426.2020.05.28.13.17.45; Thu, 28 May 2020 13:18:08 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=QQgLU7e3; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2407116AbgE1UPU (ORCPT + 99 others); Thu, 28 May 2020 16:15:20 -0400 Received: from mail.kernel.org ([198.145.29.99]:42216 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2407041AbgE1UOi (ORCPT ); Thu, 28 May 2020 16:14:38 -0400 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 15084214F1; Thu, 28 May 2020 20:14:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1590696877; bh=eqDhsel+wx9Xwh3S9ckZIPc89gBMzXxJ0/M5naXYuzo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=QQgLU7e3JN5ZO/0TgiJzccjrUaoxAAEoRAav+g1I2BElg8CgQtZLfdJmHTD+y1ys1 bR+zsvTIm85rkjlaExYTM77153cjs85hFe6nf3hBuV8omfTvYVuUNXUBNKvelvnxVT 3Li9jwGonnuf1ht2HrcZZwXFZVu+BWtAAruzDtmo= From: Sasha Levin To: tglx@linutronix.de, luto@kernel.org, ak@linux.intel.com Cc: corbet@lwn.net, mingo@redhat.com, bp@alien8.de, x86@kernel.org, shuah@kernel.org, gregkh@linuxfoundation.org, tony.luck@intel.com, chang.seok.bae@intel.com, dave.hansen@linux.intel.com, peterz@infradead.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, jarkko.sakkinen@linux.intel.com, Ravi Shankar , "H . Peter Anvin" , Sasha Levin Subject: [PATCH v13 13/16] x86/elf: Enumerate kernel FSGSBASE capability in AT_HWCAP2 Date: Thu, 28 May 2020 16:13:59 -0400 Message-Id: <20200528201402.1708239-14-sashal@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200528201402.1708239-1-sashal@kernel.org> References: <20200528201402.1708239-1-sashal@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Andi Kleen The kernel needs to explicitly enable FSGSBASE. So, the application needs to know if it can safely use these instructions. Just looking at the CPUID bit is not enough because it may be running in a kernel that does not enable the instructions. One way for the application would be to just try and catch the SIGILL. But that is difficult to do in libraries which may not want to overwrite the signal handlers of the main application. Enumerate the enabled FSGSBASE capability in bit 1 of AT_HWCAP2 in the ELF aux vector. AT_HWCAP2 is already used by PPC for similar purposes. The application can access it open coded or by using the getauxval() function in newer versions of glibc. [ tglx: Massaged changelog ] Signed-off-by: Andi Kleen Signed-off-by: Chang S. Bae Signed-off-by: Thomas Gleixner Cc: Andy Lutomirski Cc: Ravi Shankar Cc: H. Peter Anvin Link: https://lkml.kernel.org/r/1557309753-24073-18-git-send-email-chang.seok.bae@intel.com Signed-off-by: Sasha Levin --- arch/x86/include/uapi/asm/hwcap2.h | 3 +++ arch/x86/kernel/cpu/common.c | 4 +++- 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/arch/x86/include/uapi/asm/hwcap2.h b/arch/x86/include/uapi/asm/hwcap2.h index 8b2effe6efb8..5fdfcb47000f 100644 --- a/arch/x86/include/uapi/asm/hwcap2.h +++ b/arch/x86/include/uapi/asm/hwcap2.h @@ -5,4 +5,7 @@ /* MONITOR/MWAIT enabled in Ring 3 */ #define HWCAP2_RING3MWAIT (1 << 0) +/* Kernel allows FSGSBASE instructions available in Ring 3 */ +#define HWCAP2_FSGSBASE BIT(1) + #endif diff --git a/arch/x86/kernel/cpu/common.c b/arch/x86/kernel/cpu/common.c index 0d480cbadc7d..b5a086ea3425 100644 --- a/arch/x86/kernel/cpu/common.c +++ b/arch/x86/kernel/cpu/common.c @@ -1495,8 +1495,10 @@ static void identify_cpu(struct cpuinfo_x86 *c) setup_umip(c); /* Enable FSGSBASE instructions if available. */ - if (cpu_has(c, X86_FEATURE_FSGSBASE)) + if (cpu_has(c, X86_FEATURE_FSGSBASE)) { cr4_set_bits(X86_CR4_FSGSBASE); + elf_hwcap2 |= HWCAP2_FSGSBASE; + } /* * The vendor-specific functions might have changed features. -- 2.25.1