Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: JJGIvi9PCVXNK93bl/T4jC1Y+ny+E0xSY9j/uHTdnkffk1uYwVV4FrdXp854T7fiWQqzCCSjoM
 9e+6aLKVdFqw==
IronPort-SDR: fPDNBbfFahyufJij4QOlDmjp2fg8jPjaN8CW2W53KtUcO8Zc89rNaJZCppE65v+OvKoXmVg91Y
 AoD68vLhmB4A==
Subject: Re: [PATCH v4 09/10] x86/resctrl: Add arch_has_{sparse,empty}_bitmaps
 to explain CAT differences
To:     James Morse <james.morse@arm.com>, x86@kernel.org,
        linux-kernel@vger.kernel.org
Cc:     Fenghua Yu <fenghua.yu@intel.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
        H Peter Anvin <hpa@zytor.com>,
        Babu Moger <Babu.Moger@amd.com>
References: <20200526134059.1690-1-james.morse@arm.com>
 <20200526134059.1690-10-james.morse@arm.com>
From:   Reinette Chatre <reinette.chatre@intel.com>
Message-ID: <5ea41011-512f-48f0-ad57-e564b2f2982d@intel.com>
Date:   Thu, 28 May 2020 13:43:30 -0700
User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:68.0) Gecko/20100101
 Thunderbird/68.8.0
MIME-Version: 1.0
In-Reply-To: <20200526134059.1690-10-james.morse@arm.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi James,

On 5/26/2020 6:40 AM, James Morse wrote:
> Intel CPUs expect the cache bitmap provided by user-space to have on
> a single span of 1s, whereas AMD can support bitmaps like 0xf00f.
> Arm's MPAM support also allows sparse bitmaps.
> 
> Similarly, Intel CPUs check at least one bit set, whereas AMD CPUs
> are quite happy with an empty bitmap. Arm's MPAM allows an empty
> bitmap.
> 
> To move resctrl out to /fs/ we need to explain platform differences
> like this. Add two resource properties arch_has_{empty,sparse}_bitmaps.
> Test these around the relevant parts of cbm_validate().
> 
> Merging the validate calls causes AMD to gain the min_cbm_bits test
> needed for Haswell, but as it always sets this value to 1, it will
> never match.
> 
> CC: Reinette Chatre <reinette.chatre@intel.com>
> Signed-off-by: James Morse <james.morse@arm.com>
> Reviewed-by: Babu Moger <babu.moger@amd.com>

Thank you for adding handling of empty bitmaps.

Reviewed-by: Reinette Chatre <reinette.chatre@intel.com>

Reinette