Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: y7+YuBGDZXMu1WGHEjYZfjO4UQzutBxw+Gx+mdGaLXgJnFFICsMzP8h+FcNUIHek5Ofot+7RyJ
 ANsAud8DwhnA==
IronPort-SDR: fdrY26aHiOHES6o3A3++/DhfQpP5qC/qbzmt11Lh9om46dWEDFKZYbh3zSHSYR7CvGE0kSTwBj
 DSBd6JIadlXQ==
Subject: Re: [PATCH v4 10/10] cacheinfo: Move resctrl's get_cache_id() to the
 cacheinfo header file
To:     James Morse <james.morse@arm.com>, x86@kernel.org,
        linux-kernel@vger.kernel.org
Cc:     Fenghua Yu <fenghua.yu@intel.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
        H Peter Anvin <hpa@zytor.com>,
        Babu Moger <Babu.Moger@amd.com>
References: <20200526134059.1690-1-james.morse@arm.com>
 <20200526134059.1690-11-james.morse@arm.com>
From:   Reinette Chatre <reinette.chatre@intel.com>
Message-ID: <3b1babde-b439-3cb4-e819-40f54263f46f@intel.com>
Date:   Thu, 28 May 2020 13:46:32 -0700
User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:68.0) Gecko/20100101
 Thunderbird/68.8.0
MIME-Version: 1.0
In-Reply-To: <20200526134059.1690-11-james.morse@arm.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi James,

On 5/26/2020 6:40 AM, James Morse wrote:
> resctrl/core.c defines get_cache_id() for use in its cpu-hotplug
> callbacks. This gets the id attribute of the cache at the corresponding
> level of a cpu.
> 
> Later rework means this private function needs to be shared. Move
> it to the header file.
> 
> The name conflicts with a different definition in intel_cacheinfo.c,
> name it get_cpu_cacheinfo_id() to show its relation with
> get_cpu_cacheinfo().
> 
> Now this is visible on other architectures, check the id attribute
> has actually been set.
> 
> Signed-off-by: James Morse <james.morse@arm.com>
> Reviewed-by: Babu Moger <babu.moger@amd.com>
> ---

Moving this out of resctrl seems appropriate, thank you.

For the resctrl portions:
Reviewed-by: Reinette Chatre <reinette.chatre@intel.com>

Reinette