Received: by 2002:a25:ef43:0:0:0:0:0 with SMTP id w3csp12076ybm; Thu, 28 May 2020 14:49:04 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyTUwSStWvfsBwSDysJsoR11c7dyBi/E0MQipPR0MhZwZL3Nrp6RpN9agp1YSMNUx/E1sJw X-Received: by 2002:a50:f087:: with SMTP id v7mr5179902edl.225.1590702544739; Thu, 28 May 2020 14:49:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1590702544; cv=none; d=google.com; s=arc-20160816; b=sJvUPZTtExwG4pLVHLTeGp6bWvmUpWup9A6zzM/vXHD4QAqH/s8GAM7+89lRx2lNRs eVw4TEek7RQUUPGVKl+CUSl5XAHbFjbitF0NA7MIh65mVtzSoOfWg8qFM8ohh1lYJu7o K/VGBbZ41X+wYE1uibjTLwjFgcgS/iHrcQ/3VK5KGs/6VuZm4wy0dHuF5rVIbc/xzEjk 1Zzzlbd7hPmjsUdLxeezINt7gYw2xs2DBR6aHN+S14XT+fv1u1jAi+StJpu7H3QIRZ/C jbBB69BldJOX5Ut/2fgNgv5ZqLH7DOu25YtHE0ebji1wMw/b14YsDKigVoZL8TVHi/mU NGMQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date; bh=U4r83n/fX9NlAtx46UvGZV55fL9b/1svkG0jqZlJdf0=; b=j540qcXuKZIMNw1IAKLK6mgacVBsvcbnic4Fvv5YwJSwI6daYMsDn+1syy2x2+hd5T Eex0anV0RjO/bzhBdD1poxVaSb4XU20NeogJ1S106lc2dkuur81T4ZizS+8O91Hsosgp Ll5YQ2YjvY6vmlnBHbhI+kK/jI0CBiSLVQjPWcZvjAa//2zBWK5NofHdctLxNH55vrkg YLVf2E9osf4mojV8ldgjLnNP6L12EJnwyWNWpBXrxHGDJRwHoTS7yPjEg4eURO/GGDxI UiecH5lG+lMhvtUpxOVufgpvRt+sN/f/YH4pikDBwdMViz/uui7b0qJOIPWHIWEkWE1I Tzlg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id os22si4574124ejb.620.2020.05.28.14.48.42; Thu, 28 May 2020 14:49:04 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2436715AbgE1VoG (ORCPT + 99 others); Thu, 28 May 2020 17:44:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53478 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2436581AbgE1VoA (ORCPT ); Thu, 28 May 2020 17:44:00 -0400 Received: from shards.monkeyblade.net (shards.monkeyblade.net [IPv6:2620:137:e000::1:9]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C30FFC08C5C6; Thu, 28 May 2020 14:43:59 -0700 (PDT) Received: from localhost (unknown [IPv6:2601:601:9f00:477::3d5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 4CBEE129654F2; Thu, 28 May 2020 14:43:59 -0700 (PDT) Date: Thu, 28 May 2020 14:43:58 -0700 (PDT) Message-Id: <20200528.144358.1981651162176500485.davem@davemloft.net> To: doshir@vmware.com Cc: netdev@vger.kernel.org, pv-drivers@vmware.com, kuba@kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 net-next 3/4] vmxnet3: add geneve and vxlan tunnel offload support From: David Miller In-Reply-To: <20200528213204.29803-4-doshir@vmware.com> References: <20200528213204.29803-1-doshir@vmware.com> <20200528213204.29803-4-doshir@vmware.com> X-Mailer: Mew version 6.8 on Emacs 26.3 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Thu, 28 May 2020 14:43:59 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Ronak Doshi Date: Thu, 28 May 2020 14:32:02 -0700 > + BUG_ON(!(gdesc->rcd.tcp || gdesc->rcd.udp) && > + !(le32_to_cpu(gdesc->dword[0]) & > + (1UL << VMXNET3_RCD_HDR_INNER_SHIFT))); > + BUG_ON(gdesc->rcd.frg && > + !(le32_to_cpu(gdesc->dword[0]) & > + (1UL << VMXNET3_RCD_HDR_INNER_SHIFT))); ... > + BUG_ON(!(gdesc->rcd.tcp || gdesc->rcd.udp) && > + !(le32_to_cpu(gdesc->dword[0]) & > + (1UL << VMXNET3_RCD_HDR_INNER_SHIFT))); > + BUG_ON(gdesc->rcd.frg && > + !(le32_to_cpu(gdesc->dword[0]) & > + (1UL << VMXNET3_RCD_HDR_INNER_SHIFT))); Just to be clear I'm not applying stuff like this.