Received: by 2002:a25:ef43:0:0:0:0:0 with SMTP id w3csp225625ybm; Thu, 28 May 2020 21:28:05 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzsuqNjFSqQcp5kwFKYUUnihALV3O+ao6IomTMsDCJ1hZUxiN3gm0Z3vnbFIPZrndIlFoMQ X-Received: by 2002:a17:906:3441:: with SMTP id d1mr5741242ejb.489.1590726485334; Thu, 28 May 2020 21:28:05 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1590726485; cv=none; d=google.com; s=arc-20160816; b=lD9UR40cel08DQZ46Pye8tyIN++Croyge4kUCoIRIEh7NCzBQQ7MecFgJmIQJjmgB0 VwIqeIW9cZamQS7NrwKdC848q/h9wcUEpZxMsFI6r76qGJr7HmOkmks/wBOcek+VHsaU /JCmWK9yNetUlzDCdZxadimnv0sN3Cw22yYpmyD2nOPB37JxsWHP/WH522JEOoBAhNn0 sAoOLoa7yFQ++XsCYwD1QH0jxZlf3B0QUWvpgGvPhbfIfkV3pXvV6n6nZSflLjmz5sLW QL7Gua7Yfa8+o47Nrrx4vlmzNVmciZaxpkRsttw6DsGym78CtILCIJxJ6gMKb07gC1hG pSAw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:date:message-id:subject:cc:from:to :in-reply-to; bh=rOcwS5g63kiUhslSowLW0Gp05upZtfN+f/6c+2kP9ng=; b=rC8640YM/KQ24SUDXDf9SoodBdCoiL1z27myQ0w6wdW2/Mbz85YEG1/NJLlERIVvT+ KaBNvaAfKP47Hozpsgtb9v+66jL5K7sVc+Y9qJYAKojJBw3ekFrvGi41iK+6G/9L6lm3 ly/Rq51eYWwOEH8EmsC1y1H69UerQYoCDZ/KVwKhElkL5y6oAqnIR+nlV9ec0a0vceAU NM298fjGVhiHYAExkiwBY6hKZoINO5uLkbJ7818uRRfOLvvcWXRRu6OLXj52MVsioJhm HcyP3th7sDyzUGSCpq5S+kH+BKU9i90efIrWXaaJZrCt1H0mK1GIRerJW0au/f5dtP/C R0HA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id r9si4138043edx.535.2020.05.28.21.27.42; Thu, 28 May 2020 21:28:05 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728104AbgE2EY0 (ORCPT + 99 others); Fri, 29 May 2020 00:24:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59422 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727913AbgE2EYW (ORCPT ); Fri, 29 May 2020 00:24:22 -0400 Received: from ozlabs.org (ozlabs.org [IPv6:2401:3900:2:1::2]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BF4F6C08C5C6 for ; Thu, 28 May 2020 21:24:21 -0700 (PDT) Received: by ozlabs.org (Postfix, from userid 1034) id 49YBKY13Szz9sT4; Fri, 29 May 2020 14:24:16 +1000 (AEST) X-powerpc-patch-notification: thanks X-powerpc-patch-commit: 334710b1496af8a0960e70121f850e209c20958f In-Reply-To: <23e680624680a9a5405f4b88740d2596d4b17c26.1587143308.git.christophe.leroy@c-s.fr> To: Christophe Leroy , Benjamin Herrenschmidt , Paul Mackerras , npiggin@gmail.com, segher@kernel.crashing.org From: Michael Ellerman Cc: linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 1/2] powerpc/uaccess: Implement unsafe_put_user() using 'asm goto' Message-Id: <49YBKY13Szz9sT4@ozlabs.org> Date: Fri, 29 May 2020 14:24:16 +1000 (AEST) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2020-04-17 at 17:08:51 UTC, Christophe Leroy wrote: > unsafe_put_user() is designed to take benefit of 'asm goto'. > > Instead of using the standard __put_user() approach and branch > based on the returned error, use 'asm goto' and make the > exception code branch directly to the error label. There is > no code anymore in the fixup section. > > This change significantly simplifies functions using > unsafe_put_user() ... > > Signed-off-by: Christophe Leroy > Reviewed-by: Segher Boessenkool Applied to powerpc topic/uaccess-ppc, thanks. https://git.kernel.org/powerpc/c/334710b1496af8a0960e70121f850e209c20958f cheers