Received: by 2002:a25:ef43:0:0:0:0:0 with SMTP id w3csp225914ybm; Thu, 28 May 2020 21:28:45 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyrqXvZ2yzR7IfzaxYg2AwlHsYiGto+vS5GW/7UDNJ3Ea8WmbQOdYhva/9x3qYvoOiForF0 X-Received: by 2002:a17:906:1907:: with SMTP id a7mr5928845eje.251.1590726525029; Thu, 28 May 2020 21:28:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1590726525; cv=none; d=google.com; s=arc-20160816; b=h95BVzfYY19wtNg8q7gqdoIlp4eCicikP0PnC07kbQ9vnpnbfG+GIQ+fnX3QGqy2SF 8H7cjfZHzsIjI3QsL3EdIJQTdUPTrlxXtgcwjSVv3tvkKKbpgMEsRscwd6ZNJaEXZYaw X/PeLOQdJlrT1xu8aT8IaUiYdqsB8URUowtmLmMLkDrVjX2ncLjQQFyYsPJdSGvUQMu5 9Lq3qZ0eIhvZuBC3NTGOBMlsbK+2f9qp4F9oh0FiYLwYEMDHplMngQEhB367Yyq1ruPp E4CS0wSsuqxr7FCSIDdUHdB3VM4h25KP48+iNF1r4rx9M0WTt8MP8y2ITILjIoh8xcpB kxqQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:message-id:date:to:cc:from :subject:references:in-reply-to:content-transfer-encoding :mime-version:dkim-signature; bh=biY26RlQtZl+eOvAa3r0qNI+95AZPiHE6MWy69incsQ=; b=tavYSjKmfJ0Tvub9WedkM26ysXa6JRYXdZ+MIhyI50pZx70MfsK1BFQesVAXm8+sIg O7xPck0tLnhIEzzYy8MZiobjXWG9J0WfKNmHdhacHfh0HX5T7bdiOuIywyA9i7YBeOHi +XZLXIK+vWMTuDogkwf27EVKSugMMS0onztZo2abF/ZHmZO3Foaey4L0BtwVvZZ4ljqz PAYn7T7oJFyM8VbXUWVhQoLVrLqyPi0AWzmqE6XAHwd3aAm2WaZ3BH+S+HfBtDKVJf54 Nhib9XuTBzxdisJWLVS3JxmYb8WnFczQ4sjtWnkSeAdUWCCCW134p17P01TRyBNRvzHF sOzQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="uR/4VKmj"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id dx23si4864332ejb.474.2020.05.28.21.28.22; Thu, 28 May 2020 21:28:45 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="uR/4VKmj"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726441AbgE2E0i (ORCPT + 99 others); Fri, 29 May 2020 00:26:38 -0400 Received: from mail.kernel.org ([198.145.29.99]:48556 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725817AbgE2E0h (ORCPT ); Fri, 29 May 2020 00:26:37 -0400 Received: from kernel.org (unknown [104.132.0.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id F0B7E2074D; Fri, 29 May 2020 04:26:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1590726397; bh=biY26RlQtZl+eOvAa3r0qNI+95AZPiHE6MWy69incsQ=; h=In-Reply-To:References:Subject:From:Cc:To:Date:From; b=uR/4VKmjPeu7nUm0lkHtc5fQuVyg9Cv8k9mjBTofLk9uGIZ+gv7NcC1inBtBriBu5 ydFYWUvxalNlqlw/nKCPjTvH8jWZ1TRiCEu7pDvB5+NSVdzR97iRZSQekgx7ct8aTp 2NgFtT9YMZWTQ17NB/enzc0fLu2TBOXJ+pMrMYyw= Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: <1590560749-29136-1-git-send-email-weiyi.lu@mediatek.com> References: <1590560749-29136-1-git-send-email-weiyi.lu@mediatek.com> Subject: Re: [PATCH v2] clk: mediatek: assign the initial value to clk_init_data of mtk_mux From: Stephen Boyd Cc: James Liao , Fan Chen , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-clk@vger.kernel.org, srv_heupstream@mediatek.com, stable@vger.kernel.org, Weiyi Lu , Owen Chen To: Matthias Brugger , Nicolas Boichat , Weiyi Lu Date: Thu, 28 May 2020 21:26:36 -0700 Message-ID: <159072639634.69627.7492835408539422310@swboyd.mtv.corp.google.com> User-Agent: alot/0.9 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Quoting Weiyi Lu (2020-05-26 23:25:49) > When some new clock supports are introduced, e.g. [1] > it might lead to an error although it should be NULL because > clk_init_data is on the stack and it might have random values > if using without initialization. > Add the missing initial value to clk_init_data. >=20 > [1] https://android-review.googlesource.com/c/kernel/common/+/1278046 >=20 > Fixes: a3ae549917f1 ("clk: mediatek: Add new clkmux register API") > Cc: > Signed-off-by: Weiyi Lu > Reviewed-by: Matthias Brugger > --- Applied to clk-next