Received: by 2002:a25:ef43:0:0:0:0:0 with SMTP id w3csp325368ybm; Fri, 29 May 2020 00:48:21 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz0ofkVXF45GbIBJrHlSjsBolYmlb7j4wlMLSHGbEtDg2kvRPkKq3951C4Je+eqDRQblodI X-Received: by 2002:a17:906:4088:: with SMTP id u8mr6921044ejj.500.1590738500973; Fri, 29 May 2020 00:48:20 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1590738500; cv=none; d=google.com; s=arc-20160816; b=F0IEXnD1JhS9Wu4YTEtfe48v19dyatPvMkr0toJt3QRPS6+LHs4vemqNUP68OjK+mG vRC81RmbQp3ZIaYZj0VnvLUmS4qu/vcYSnxvyvO8AUSBUB4rzWfUt7aEVexv32xOzvA9 SSiH5I+EJcrL8NMR/JH6U9IzaSzoxVHaVjUHX7yMjHwArmKCZrZyI5xHADnrpkwvmhVR r23XELiXoB2b5lZ0cCwHTBPcDudNZ1eb3ECPrcwnXdGHlMxNh/qR35fnj+FLjnJetYrg qcLRa/1ASoJ5I3cNmp7gGdPmaT6VtFfM8dVs9TtGdG9r0ZnwrZx6O5g0aILsWcYrwvYV ZKhg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=v0WL43ZgClHvK63U8tJSQHhuv1IY+XGJwk9TrYHJBpQ=; b=s2RgMSY3G9c2XSlvwikk5r3USZqDqrZ7bJR5nbaj2caw0aIax590/YxaxRAH0/T+5a kpFI/RJZX9VT+nvHlsnTVuMDHJzYslrsp4TyK70qBgrKTkDhrIbSYKJuTHnYiRgtd/26 HNmZU1hpgajSwB1w7Pp+3zvs1MfrWlArQT+k1eoXoIvZh8S7Hxme+ezEItxkVPFvBN4L j1fWEhITgjBz61LBxOWcwHXCtxexPqIljVMV+A1QpYIJX6BS8pqRRr8lAsw2pcgFwHIY 9BUZdAR5jJv+X74a0ea+y4FSLp7zce9yBVBQ2DNJ5b8QQ4r9kn1LnuyLt1NAtpnVdzmV ubOw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=O4x09lmr; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id p1si5588865ejr.296.2020.05.29.00.47.58; Fri, 29 May 2020 00:48:20 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=O4x09lmr; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726518AbgE2Hph (ORCPT + 99 others); Fri, 29 May 2020 03:45:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34126 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725601AbgE2Hpg (ORCPT ); Fri, 29 May 2020 03:45:36 -0400 Received: from mail-pf1-x441.google.com (mail-pf1-x441.google.com [IPv6:2607:f8b0:4864:20::441]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6470CC08C5C6 for ; Fri, 29 May 2020 00:45:36 -0700 (PDT) Received: by mail-pf1-x441.google.com with SMTP id z64so905492pfb.1 for ; Fri, 29 May 2020 00:45:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=v0WL43ZgClHvK63U8tJSQHhuv1IY+XGJwk9TrYHJBpQ=; b=O4x09lmrpd35ttX4RvYlwthcP4XZDSh1wmXrWDdHgrwpzBD/ZZhH6KfxLQQJVRMSUT ksgx+s0fuOzYCaoj9NftFtYGCVyX2658+SqHPIgc0GBGp2+HF6OOy3DVu2+RhUov7nNo kF/ooebTjEWP/zFkJmzhMTRXeqdsXI6SpoiVE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=v0WL43ZgClHvK63U8tJSQHhuv1IY+XGJwk9TrYHJBpQ=; b=X5fnz5wXB1cJ/lvvENfzdOuxSwIvkaJWZDodUukxG2hUfuzp0BMBcn3y2OGth1EH9J IwUZoGPnAiazPZ6WCwPrjpldX2O1+5If1z8dgg6+zGgP9jbEztPl9D8sogquAYfnhhRq 4h5PoIy0rMhvLhsfy/jCj7IPdzRq+CRbr+SDutlqq8YME7cwYPCK63bhSRKA4fU0V1Sk chihQBIk3LFOtRgFoO01PBtLAqG3x5cQJqEcCmOkg841Fkzyt2WwILbMjTu5e0QgfT+I +Sk0MVSKKNlw722XB8DBuuWc/IM6d/kdLgfa6+6C2EccGbZl7EryOBWiocppU5oOo3Gp Pk8g== X-Gm-Message-State: AOAM530UoFV+pbTmT3pX1AHOWlnSeeftD12EGhR0gX8mNozkvFvXItRI Lmo/kAp+W6gBlBt5bEE9cNandQ== X-Received: by 2002:a63:1165:: with SMTP id 37mr7327753pgr.424.1590738336044; Fri, 29 May 2020 00:45:36 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id 74sm3284357pfa.87.2020.05.29.00.45.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 29 May 2020 00:45:35 -0700 (PDT) Date: Fri, 29 May 2020 00:45:34 -0700 From: Kees Cook To: Christian Brauner Cc: Sargun Dhillon , containers@lists.linux-foundation.org, cyphar@cyphar.com, jannh@google.com, jeffv@google.com, linux-api@vger.kernel.org, linux-kernel@vger.kernel.org, palmer@google.com, rsesek@google.com, tycho@tycho.ws, Matt Denton Subject: Re: [PATCH v2 2/3] seccomp: Introduce addfd ioctl to seccomp user notifier Message-ID: <202005290043.A402A7514@keescook> References: <20200528110858.3265-1-sargun@sargun.me> <20200528110858.3265-3-sargun@sargun.me> <202005282345.573B917@keescook> <20200529073828.avywvdfprhupbkql@wittgenstein> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200529073828.avywvdfprhupbkql@wittgenstein> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, May 29, 2020 at 09:38:28AM +0200, Christian Brauner wrote: > On Fri, May 29, 2020 at 12:31:37AM -0700, Kees Cook wrote: > > Nit: please use BIT() > > Fwiw, I don't think we can use BIT() in uapi headers, see: Argh. How many times do I get to trip over this? :P Thank you; yes, please ignore my suggestion. :) -- Kees Cook