Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <1590654459-10827-1-git-send-email-yangtiezhu@loongson.cn>
 <CAAhV-H7W7iXJOmJ8yT7kfuMN2Y8VhzcOUQXrnkytEEqrQZtWmQ@mail.gmail.com> <20200529075643.GA7031@alpha.franken.de>
In-Reply-To: <20200529075643.GA7031@alpha.franken.de>
From:   Huacai Chen <chenhuacai@gmail.com>
Date:   Fri, 29 May 2020 16:23:16 +0800
Message-ID: <CAAhV-H5Qcbig+n604xHoj70ObKQRhQoSysGStngfxO9ZhrcqFA@mail.gmail.com>
Subject: Re: [PATCH] MIPS: Fix build warning about "PTR_STR" redefined under CONFIG_TEST_PRINTF
To:     Thomas Bogendoerfer <tsbogend@alpha.franken.de>
Cc:     Tiezhu Yang <yangtiezhu@loongson.cn>,
        "open list:MIPS" <linux-mips@vger.kernel.org>,
        LKML <linux-kernel@vger.kernel.org>,
        Xuefeng Li <lixuefeng@loongson.cn>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi, Thomas,

On Fri, May 29, 2020 at 4:05 PM Thomas Bogendoerfer
<tsbogend@alpha.franken.de> wrote:
>
> On Fri, May 29, 2020 at 09:24:06AM +0800, Huacai Chen wrote:
> > Hi, Tiezhu,
> >
> > On Thu, May 28, 2020 at 4:28 PM Tiezhu Yang <yangtiezhu@loongson.cn> wrote:
> > >
> > > Replace PTR_STR with INST_PTR_STR to fix the following build warning when
> > > CONFIG_TEST_PRINTF is set:
> > >
> > >   CC      lib/test_printf.o
> > > lib/test_printf.c:214:0: warning: "PTR_STR" redefined
> > >  #define PTR_STR "ffff0123456789ab"
> > >  ^
> > > In file included from ./arch/mips/include/asm/dsemul.h:11:0,
> > >                  from ./arch/mips/include/asm/processor.h:22,
> > >                  from ./arch/mips/include/asm/thread_info.h:16,
> > >                  from ./include/linux/thread_info.h:38,
> > >                  from ./include/asm-generic/preempt.h:5,
> > >                  from ./arch/mips/include/generated/asm/preempt.h:1,
> > >                  from ./include/linux/preempt.h:78,
> > >                  from ./include/linux/spinlock.h:51,
> > >                  from ./include/linux/seqlock.h:36,
> > >                  from ./include/linux/time.h:6,
> > >                  from ./include/linux/stat.h:19,
> > >                  from ./include/linux/module.h:13,
> > >                  from lib/test_printf.c:10:
> > > ./arch/mips/include/asm/inst.h:20:0: note: this is the location of the previous definition
> > >  #define PTR_STR  ".dword"
> > >  ^
> > >
> > > Fixes: e701656ec4db ("MIPS: inst.h: Stop including asm.h to avoid various build failures")
> > > Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn>
> > Thank you for catching this issue, but I think this is not the best
> > solution. Maciej suggest another solution, and I will send a patch to
> > fix it.
>
> thank you, I was about to fix it myself. Not sure about your plan,
> but my idea would be to move the unaligned stuff into it's another
> or a new header file.
Yes, this is also Maciej's suggestion, and I have sent the patch one
minute ago...

Huacai
>
> Thomas.
>
> --
> Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
> good idea.                                                [ RFC1925, 2.3 ]