Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932156AbWCSShO (ORCPT ); Sun, 19 Mar 2006 13:37:14 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751587AbWCSShO (ORCPT ); Sun, 19 Mar 2006 13:37:14 -0500 Received: from main.gmane.org ([80.91.229.2]:29655 "EHLO ciao.gmane.org") by vger.kernel.org with ESMTP id S1751569AbWCSShM (ORCPT ); Sun, 19 Mar 2006 13:37:12 -0500 X-Injected-Via-Gmane: http://gmane.org/ To: linux-kernel@vger.kernel.org From: =?iso-8859-1?Q?M=E5ns_Rullg=E5rd?= Subject: Re: [PATCH 001/001] PCI: PCI quirk for Asus A8V and A8V Deluxe motherboards Date: Sun, 19 Mar 2006 18:36:33 +0000 Message-ID: References: <20060305192709.GA3789@skyscraper.unix9.prv> <20060317143303.GR20746@lug-owl.de> <20060317144920.GS20746@lug-owl.de> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit X-Complaints-To: usenet@sea.gmane.org X-Gmane-NNTP-Posting-Host: 82.153.166.94 User-Agent: Gnus/5.1007 (Gnus v5.10.7) XEmacs/21.4.15 (Security Through Obscurity, linux) Cancel-Lock: sha1:fBaonB39wn3Atnu0wtZHMz6tIaQ= Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1397 Lines: 30 Andras Mantia writes: >>> Anyway, my suggestion remains, that the >>> + if (dev->subsystem_vendor != PCI_VENDOR_ID_ASUSTEK) >>> + return; >>> + if (dev->device != PCI_DEVICE_ID_VIA_8237) >>> + return; >>> >>> might be not needed at all as it is not ASUS specific. >> >> Doesn't it depend on the BIOS? My BIOS lets me choose between >> "automatic" and "disabled" for the onboard sound. > > I don't see how that setting could change the device ID or the vendor ID. As > I understood the above code will simply not try to enable the sound device > if: > a) the vendor is not ASUSTEK > b) the device is not ID is not PCI_DEVICE_ID_VIA_8237 > > For a) it means that an MSI/Epox/whatever board with the same VIA chipset > and the same problem will not be handled. For b) see my previous comment It is the BIOS that disables the onboard sound if it detects a PCI sound card. Chances are other vendors use different BIOS configurations that do not automatically disable things. I don't know if messing with those bits might do something bad on another board. -- M?ns Rullg?rd mru@inprovide.com - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/