Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Fri, 29 May 2020 11:54:11 +0100
From:   Mark Brown <broonie@kernel.org>
To:     Sumit Semwal <sumit.semwal@linaro.org>
Cc:     agross@kernel.org, bjorn.andersson@linaro.org, lgirdwood@gmail.com,
        robh+dt@kernel.org, nishakumari@codeaurora.org,
        linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
        devicetree@vger.kernel.org, kgunda@codeaurora.org,
        rnayak@codeaurora.org
Subject: Re: [PATCH v3 1/5] regulator: Allow regulators to verify enabled
 during enable()
Message-ID: <20200529105411.GF4610@sirena.org.uk>
References: <20200528154625.17742-1-sumit.semwal@linaro.org>
 <20200528154625.17742-2-sumit.semwal@linaro.org>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="O98KdSgI27dgYlM5"
Content-Disposition: inline
In-Reply-To: <20200528154625.17742-2-sumit.semwal@linaro.org>
User-Agent: Mutt/1.10.1 (2018-07-13)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


--O98KdSgI27dgYlM5
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Thu, May 28, 2020 at 09:16:21PM +0530, Sumit Semwal wrote:

> +		while (time_remaining > 0) {
> +			/* We've already waited for enable_time above;
> +			 * so we can start with immediate check of the
> +			 * status of the regulator.
> +			 */
> +			if (rdev->desc->ops->is_enabled(rdev))
> +				break;

I'd expect to prefer to get_status() if it's available.

--O98KdSgI27dgYlM5
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAl7Q6dIACgkQJNaLcl1U
h9DsdQf/XvF7XSA3+wsHApX3Vw3vgnDX0EIbdCj+mAhN4yXaRDNBh9h+nYatUqVI
4IuubtGTRY0RtBsggRNfd51POUPwItWmPkQNGi50gaYlXCUFTS9DFAxPw+L3HwQS
8DXWUoESsD+kkk6gnbz7cYxbvojECkeyDERrAYXaXbbYCU037zNhr42FrYI+owAm
T+3BDj0hsuaDBYbcbzDGntieQ/eedOPfz2XAbm6bGZH95NcT13VYEBXhTxGgtdyP
6x4Tv7B5/G82rWeWn4+SI6SfWva3ZP81c4JPZnZ6alG+8csxR1qz2nnGCg+x53H3
JMHXL8TmkGhD5LB7bLIp8whI9v5Yiw==
=33t3
-----END PGP SIGNATURE-----

--O98KdSgI27dgYlM5--