Received: by 2002:a25:ef43:0:0:0:0:0 with SMTP id w3csp437765ybm;
        Fri, 29 May 2020 04:00:54 -0700 (PDT)
X-Google-Smtp-Source: ABdhPJy1bPSJ1q3kgCamdWv6Iw/4vRYx57XHxEDE+2BCHCsBlatzfd6clkApBUQtnR/cPunk55Bh
X-Received: by 2002:a17:906:a843:: with SMTP id dx3mr6784119ejb.396.1590750054308;
        Fri, 29 May 2020 04:00:54 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1590750054; cv=none;
        d=google.com; s=arc-20160816;
        b=cgjLtZf2LBFr7sOHqWLjewZgRg8wlBSfIjoW/Mnn3oU6H6rShgKFz4VelDpPqtyNDu
         V6w+H5uOXwNjHYLqWYcNpg/hEwFVd+OupJx2H3IMqlfO7ChZ56VL8WqbX43JEtOtXh0y
         FJPoBEucDjbMqyxBAm3ybqeSmiSZHHmbDEZTM8mDkgOumY8u07uVj1zdxaOV3y5c4e5R
         cPwfczW9DGy1Cu3i2cu/ZGqze8NP5iwgYmO+Rxh+NraT2OHf7QFvh4CJ6p5/DBZvmjQY
         wAziduenHjxm3VrFkC/pgnVjArMVbAnLKtzO+Xagyr1zHG7CCINjKDd6mxUVRRB2VzJQ
         5zNg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:sender:dkim-signature:content-transfer-encoding
         :content-language:in-reply-to:mime-version:user-agent:date
         :message-id:from:references:cc:to:subject;
        bh=06/Fdr3bA+ciLNMseJ/kn2hvnWdtUgAwTL8Ebufl9cc=;
        b=0d323mTwWPwtvjsNKm0fct+wW63hRFgeXYFyOp4NvWavQe1D+cElDPZUd/T2dZH2FM
         hAncrZHux6k+xjJ/YU0vXaoRUl2u6+sIBcXOUPR+gHLS6pytaA7o7wATKoDiaLPXljfk
         bEtC3jXc5cTl4i52/uRC6+T+WhUREIwOKvoqyaY7fK08AcuMTpBrq911cNMk2+y7/uPR
         LoI6iXVzju8Xmkd5EeTGNxw65GPMfRFtNRFYwcCdxbK/ByOnEfuuW4eN5ovx8gOhsc3o
         7nA2LwaPxJBe2zL2khuEiXTuipQhO5dBHOzZ7hwFPZwtLoMbJNPYfDon0HjjYcF3f6In
         9xGg==
ARC-Authentication-Results: i=1; mx.google.com;
       dkim=pass header.i=@nvidia.com header.s=n1 header.b=HEnxrdPa;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18])
        by mx.google.com with ESMTP id d8si4974585ejk.317.2020.05.29.04.00.31;
        Fri, 29 May 2020 04:00:54 -0700 (PDT)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Authentication-Results: mx.google.com;
       dkim=pass header.i=@nvidia.com header.s=n1 header.b=HEnxrdPa;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1726495AbgE2K6k (ORCPT <rfc822;hackukernel@gmail.com>
        + 99 others); Fri, 29 May 2020 06:58:40 -0400
Received: from hqnvemgate24.nvidia.com ([216.228.121.143]:19845 "EHLO
        hqnvemgate24.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1725306AbgE2K6j (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 29 May 2020 06:58:39 -0400
Received: from hqpgpgate101.nvidia.com (Not Verified[216.228.121.13]) by hqnvemgate24.nvidia.com (using TLS: TLSv1.2, DES-CBC3-SHA)
        id <B5ed0ea830000>; Fri, 29 May 2020 03:57:07 -0700
Received: from hqmail.nvidia.com ([172.20.161.6])
  by hqpgpgate101.nvidia.com (PGP Universal service);
  Fri, 29 May 2020 03:58:38 -0700
X-PGP-Universal: processed;
        by hqpgpgate101.nvidia.com on Fri, 29 May 2020 03:58:38 -0700
Received: from [10.25.76.239] (10.124.1.5) by HQMAIL107.nvidia.com
 (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Fri, 29 May
 2020 10:58:28 +0000
Subject: Re: [PATCH] PCI: tegra: fix runtime pm imbalance on error
To:     Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
        Thierry Reding <thierry.reding@gmail.com>
CC:     Bjorn Helgaas <helgaas@kernel.org>,
        Dinghao Liu <dinghao.liu@zju.edu.cn>, <kjlu@umn.edu>,
        Rob Herring <robh@kernel.org>,
        Bjorn Helgaas <bhelgaas@google.com>,
        Jonathan Hunter <jonathanh@nvidia.com>,
        Andrew Murray <amurray@thegoodpenguin.co.uk>,
        <linux-pci@vger.kernel.org>, <linux-tegra@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>
References: <20200520163739.GA1100601@bjorn-Precision-5520>
 <e7c967a0-c285-450a-bbad-f6456c661d41@nvidia.com>
 <20200529102317.GA12270@e121166-lin.cambridge.arm.com>
X-Nvconfidentiality: public
From:   Vidya Sagar <vidyas@nvidia.com>
Message-ID: <74c911ac-95ab-d2a0-8604-1ef19c2f997d@nvidia.com>
Date:   Fri, 29 May 2020 16:28:23 +0530
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:68.0) Gecko/20100101
 Thunderbird/68.8.0
MIME-Version: 1.0
In-Reply-To: <20200529102317.GA12270@e121166-lin.cambridge.arm.com>
X-Originating-IP: [10.124.1.5]
X-ClientProxiedBy: HQMAIL101.nvidia.com (172.20.187.10) To
 HQMAIL107.nvidia.com (172.20.187.13)
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1;
        t=1590749827; bh=06/Fdr3bA+ciLNMseJ/kn2hvnWdtUgAwTL8Ebufl9cc=;
        h=X-PGP-Universal:Subject:To:CC:References:X-Nvconfidentiality:From:
         Message-ID:Date:User-Agent:MIME-Version:In-Reply-To:
         X-Originating-IP:X-ClientProxiedBy:Content-Type:Content-Language:
         Content-Transfer-Encoding;
        b=HEnxrdPaTamFwHVwP3lcJImL81/SCDFEZkJuQc5KwaxVLRLmvWOEP351hf9uYUYGJ
         FxwSBmNrfIAzLYGFbDJT5OY9gPtBxbkJyjCnVBW+S4HT+Cw8+mKmlr/p8ReSOtrIm9
         g/BxOqEHeNyosTal4A9G3kN20WAE3xigboj76gQXb8rT6x2CqIJhHhdeedqYWeFh+z
         vrza/JEBnhtiQQeq7C/fMvcogEvwtpUNpTi1tHWWtNwjT8NRsvR3cRa2aTFDXKOku3
         Iqh+VT++jpyYnJP+D++u8eh+IZN/o//C4jY6vCAcQbfgjnZcLOG6o1ufzZdP0qQxCv
         lAmu3X47o+AMg==
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org



On 29-May-20 3:53 PM, Lorenzo Pieralisi wrote:
> External email: Use caution opening links or attachments
> 
> 
> On Wed, May 20, 2020 at 11:39:08PM +0530, Vidya Sagar wrote:
>> Thanks for pushing a patch to fix it. I've been under the wrong assumption
>> that a failing pm_runtime_get_sync() wouldn't increment the usage counter.
>> With Thierry's and Bjorn's comments addressed
>>
>> Acked-by: Vidya Sagar <vidyas@nvidia.com>
> 
> Thierry, Vidya,
> 
> are your ACKs applying also to:
> 
> https://patchwork.kernel.org/patch/11562109/
I just took a look at this change and it looks good to me.
So, I'm fine with extending my 'Acked-by' to this patch as well.

Thanks,
Vidya Sagar
> 
> Dinghao did not carry them over and I could not understand from this
> thread if your ACKs apply to both tegra and tegra194.
> 
> Thanks,
> Lorenzo
> 
>> On 20-May-20 10:07 PM, Bjorn Helgaas wrote:
>>> External email: Use caution opening links or attachments
>>>
>>>
>>> On Wed, May 20, 2020 at 11:59:08AM +0200, Thierry Reding wrote:
>>>> On Wed, May 20, 2020 at 04:52:23PM +0800, Dinghao Liu wrote:
>>>>> pm_runtime_get_sync() increments the runtime PM usage counter even
>>>>> it returns an error code. Thus a pairing decrement is needed on
>>>>
>>>> s/even it/even when it/
>>>>
>>>> Might also be a good idea to use a different subject prefix because I
>>>> was almost not going to look at the other patch, taking this to be a
>>>> replacement for it.
>>>
>>> Amen.  This would be a good change to start using "PCI: tegra194" or
>>> something for pcie-tegra194.c.  Or will there be tegra195, tegra 196,
>>> etc added to this driver?
>>>
>>> Also, please capitalize the first word and "PM" in the subjects:
>>>
>>>     PCI: tegra194: Fix runtime PM imbalance on error
>>>
>>> Bjorn
>>>