Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [Patch 1/2] media: v4l2-rect.h: add enclosed rectangle helper
To:     Benoit Parrot <bparrot@ti.com>, Hans Verkuil <hverkuil@xs4all.nl>,
        Prabhakar Lad <prabhakar.csengg@gmail.com>,
        Kyungmin Park <kyungmin.park@samsung.com>,
        Kukjin Kim <kgene@kernel.org>,
        Sylwester Nawrocki <s.nawrocki@samsung.com>,
        Krzysztof Kozlowski <krzk@kernel.org>,
        Jacek Anaszewski <jacek.anaszewski@gmail.com>
Cc:     linux-media@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20200528132605.18339-1-bparrot@ti.com>
 <20200528132605.18339-2-bparrot@ti.com>
From:   Andrzej Pietrasiewicz <andrzejtp2010@gmail.com>
Message-ID: <6b88258e-4567-3c0b-8c90-6053dbb7634a@gmail.com>
Date:   Fri, 29 May 2020 13:57:51 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.8.0
MIME-Version: 1.0
In-Reply-To: <20200528132605.18339-2-bparrot@ti.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi Benoit,

Thank you for the patch,

W dniu 28.05.2020 o 15:26, Benoit Parrot pisze:
> Add a helper function to check if one rectangle is enclosed inside
> another.
> 
> Signed-off-by: Benoit Parrot <bparrot@ti.com>

Acked-by: Andrzej Pietrasiewicz <andrzejtp2010@gmail.com>

> ---
>   include/media/v4l2-rect.h | 20 ++++++++++++++++++++
>   1 file changed, 20 insertions(+)
> 
> diff --git a/include/media/v4l2-rect.h b/include/media/v4l2-rect.h
> index 8800a640c224..bd587d0c0dc3 100644
> --- a/include/media/v4l2-rect.h
> +++ b/include/media/v4l2-rect.h
> @@ -184,4 +184,24 @@ static inline bool v4l2_rect_overlap(const struct v4l2_rect *r1,
>   	return true;
>   }
>   
> +/**
> + * v4l2_rect_enclosed() - is r1 enclosed in r2?
> + * @r1: rectangle.
> + * @r2: rectangle.
> + *
> + * Returns true if @r1 is enclosed in @r2.
> + */
> +static inline bool v4l2_rect_enclosed(struct v4l2_rect *r1,
> +				      struct v4l2_rect *r2)
> +{
> +	if (r1->left < r2->left || r1->top < r2->top)
> +		return false;
> +	if (r1->left + r1->width > r2->left + r2->width)
> +		return false;
> +	if (r1->top + r1->height > r2->top + r2->height)
> +		return false;
> +
> +	return true;
> +}
> +
>   #endif
>