Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH 00/10] iommu/amd: Updates and Cleanups
To:     Joerg Roedel <joro@8bytes.org>
Cc:     linux-kernel@vger.kernel.org, iommu@lists.linux-foundation.org,
        jroedel@suse.de
References: <20200527115313.7426-1-joro@8bytes.org>
From:   Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>
Message-ID: <855af88c-66b2-29c1-a184-40d52592e38e@amd.com>
Date:   Fri, 29 May 2020 19:15:13 +0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101
 Thunderbird/68.8.0
In-Reply-To: <20200527115313.7426-1-joro@8bytes.org>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
Received: from [192.168.1.64] (124.121.4.249) by SG2PR01CA0145.apcprd01.prod.exchangelabs.com (2603:1096:4:8f::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3045.18 via Frontend Transport; Fri, 29 May 2020 12:15:21 +0000
X-Originating-IP: [124.121.4.249]
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-HT: Tenant
X-MS-Office365-Filtering-Correlation-Id: 631211be-2b6c-445c-c80c-08d803c9f63e
X-MS-TrafficTypeDiagnostic: DM5PR12MB1305:
X-Microsoft-Antispam-PRVS: <DM5PR12MB1305AE2A42738EFDC918B84DF38F0@DM5PR12MB1305.namprd12.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:8882;
X-Forefront-PRVS: 04180B6720
X-MS-Exchange-SenderADCheck: 1
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: B3kunAOw4Q/vVOk8BTOeKMF9VHxJjrx1wbf7kh+QQdWl3OyVMnG5B4eXQXeON/dKwccmmJsocmtBGkaxgjVxvmPQYYQ341p2JKLwvH7mv+1oPeM5sPDfeH8jV6tlfWGEmPNutrvOy4cDZGEGVIcjG516TGQCJ5XMGOPbXJAmta19AsZr5NRHPH6xxSH60jiTuNRSvZWepb80hGpTIzm08WBPf46aGSYwsBsfYrw1Whph93IDSAWFgvy0M11F6VsIQquLglWylh42e9TksgrDIq01/QXBmv5c2ohmSkbn3e1o5U/1m2YjEyW8dUiwfVJBat7BbaXatrauo48zHrBstreb7W/L6hysEEmdJlmX5scvnRjL0eN6dozG0PVpdvZi
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM5PR12MB1163.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(4636009)(346002)(396003)(136003)(39860400002)(366004)(376002)(53546011)(83380400001)(6916009)(36756003)(26005)(16526019)(186003)(5660300002)(478600001)(31686004)(316002)(16576012)(52116002)(6666004)(44832011)(8936002)(956004)(4326008)(2616005)(31696002)(86362001)(6486002)(66946007)(8676002)(66476007)(66556008)(2906002)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData: hrxtGKOUO/Havwv2uJn+CMoeDoYU5bLfv9yvro6lvLlo40VcxDA/mSM+AJK9iaHZbLCs4aYPmFgEwfXOMxeuW2v7qmxhmtW3++vLH4btIvS3xEe/2jIjHaeHTqVx0u9wXCcTFJ6aYN54etAfzOZDBA3HJPae4DknBtdk00QMA3/SFU4SNPTcGMW/INRgtxWlXpWuQq8s44OJPpYvLf0BQtBzkZoALAnw/XoBy4x4a/oll73YNipi0pw7aCFhHkaQ63v/WV6Ac11NuLlNkm3brJZ6GvvrtcyJ1B2tqnjZBTg+9FlyZFlfgVWQzxTmt9P8R9R5tQoP0PjRCrdd6/fb8P12HL9pmqiNgRuzUPXa5px46ASPbhTDgza0MRrFToKXGuRetbirQ1ETNa67i2Jhd1UMndRt7xruyErRCRvO7JvZSYrc70ghjZHpoPmq3eJyFRJ3OtEPbczerv73NFtzgKsjcn6t2as6s2vc0Z5Clyg=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 631211be-2b6c-445c-c80c-08d803c9f63e
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 May 2020 12:15:23.0903
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 9FjkbZe283OJ84+Njgw+ZLRgvE80Muls0RCOTAouJ4Z8RRfLNbW6onKvmnw0QwKQ66jSuYdcHdPaNeUeIr9dmA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR12MB1305
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Joerg,

On 5/27/2020 6:53 PM, Joerg Roedel wrote:
> Hi,
> 
> here is a collection of patches that clean up a few things
> in the AMD IOMMU driver. Foremost, it moves all related
> files of the driver into a separate subdirectory.
> 
> But the patches also remove usage of dev->archdata.iommu and
> clean up dev_data handling and domain allocation.
> 
> Patches are runtime-tested, including device-assignment.
> 
> Please review.
> 
> Regards,
> 
> 	Joerg
> 
> Joerg Roedel (10):
>    iommu/amd: Move AMD IOMMU driver to a subdirectory
>    iommu/amd: Unexport get_dev_data()
>    iommu/amd: Let free_pagetable() not rely on domain->pt_root
>    iommu/amd: Allocate page-table in protection_domain_init()
>    iommu/amd: Free page-table in protection_domain_free()
>    iommu/amd: Consolidate domain allocation/freeing
>    iommu/amd: Remove PD_DMA_OPS_MASK
>    iommu/amd: Merge private header files
>    iommu/amd: Store dev_data as device iommu private data
>    iommu/amd: Remove redundant devid checks
> 
>   MAINTAINERS                                   |   2 +-
>   drivers/iommu/Makefile                        |   6 +-
>   .../{amd_iommu_proto.h => amd/amd_iommu.h}    |  20 +-
>   drivers/iommu/{ => amd}/amd_iommu_types.h     |   0
>   .../{amd_iommu_debugfs.c => amd/debugfs.c}    |   5 +-
>   .../iommu/{amd_iommu_init.c => amd/init.c}    |   6 +-
>   drivers/iommu/{amd_iommu.c => amd/iommu.c}    | 265 ++++++------------
>   .../iommu/{amd_iommu_v2.c => amd/iommu_v2.c}  |  14 +-
>   .../{amd_iommu_quirks.c => amd/quirks.c}      |   0
>   drivers/iommu/amd_iommu.h                     |  14 -
>   10 files changed, 117 insertions(+), 215 deletions(-)
>   rename drivers/iommu/{amd_iommu_proto.h => amd/amd_iommu.h} (88%)
>   rename drivers/iommu/{ => amd}/amd_iommu_types.h (100%)
>   rename drivers/iommu/{amd_iommu_debugfs.c => amd/debugfs.c} (89%)
>   rename drivers/iommu/{amd_iommu_init.c => amd/init.c} (99%)
>   rename drivers/iommu/{amd_iommu.c => amd/iommu.c} (95%)
>   rename drivers/iommu/{amd_iommu_v2.c => amd/iommu_v2.c} (98%)
>   rename drivers/iommu/{amd_iommu_quirks.c => amd/quirks.c} (100%)
>   delete mode 100644 drivers/iommu/amd_iommu.h
> 

Thank you for cleaning up.

Reviewed-by: Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>