Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Fri, 29 May 2020 07:49:38 -0500
From:   Patrick Williams <patrick@stwcx.xyz>
To:     Manikandan Elumalai <manikandan.hcl.ers.epl@gmail.com>
Cc:     linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org,
        openbmc@lists.ozlabs.org, manikandan.e@hcl.com, patrickw3@fb.com,
        vijaykhemka@fb.com, Guenter Roeck <linux@roeck-us.net>,
        linux-hwmon@vger.kernel.org
Subject: Re: [PATCH] hwmon:(adm1275) Enable adm1278 ADM1278_TEMP1_EN
Message-ID: <20200529124938.GE17541@heinlein>
References: <20200528141523.GA8810@cnn>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="GxcwvYAGnODwn7V8"
Content-Disposition: inline
In-Reply-To: <20200528141523.GA8810@cnn>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


--GxcwvYAGnODwn7V8
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Thu, May 28, 2020 at 07:45:23PM +0530, Manikandan Elumalai wrote:

Hi Manikandan,

Adding the PMBus maintainers...

>=20
> The adm1278 temperature sysfs attribute need it for one of the our openbm=
c platform .=20
> This functionality is not enabled by default, so PMON_CONFIG needs to be =
modified in order to enable it.

Vijay already mentioned the Signed-off-by here.

Since this is a kernel patch and your first time contributing one, please
read through:
    https://www.kernel.org/doc/html/latest/process/1.Intro.html
and the MAINTAINERS file.  Another thing you've missed is using the
get_maintainer.pl script to find out who you're suppose to CC.  It is
fine to have additional CCs but we're missing the pmbus maintainer on
this patch.

>=20
> ---
>  drivers/hwmon/pmbus/adm1275.c | 15 +++++++++++++++
>  1 file changed, 15 insertions(+)
>=20
> diff --git a/drivers/hwmon/pmbus/adm1275.c b/drivers/hwmon/pmbus/adm1275.c
> index 5caa37fb..47b293d 100644
> --- a/drivers/hwmon/pmbus/adm1275.c
> +++ b/drivers/hwmon/pmbus/adm1275.c
> @@ -681,6 +681,21 @@ static int adm1275_probe(struct i2c_client *client,
>  			}
>  		}
> =20
> +		config =3D i2c_smbus_read_byte_data(client, ADM1275_PMON_CONFIG);
> +		if (config < 0)
> +			return config;
> +
> +		/* Enable TEMP1 by defult */
> +		config |=3D ADM1278_TEMP1_EN;
> +		ret =3D i2c_smbus_write_byte_data(client,
> +					ADM1275_PMON_CONFIG,
> +					config);
> +		if (ret < 0) {
> +		dev_err(&client->dev,
> +			"Failed to enable temperature config\n");
> +		return -ENODEV;
> +		}
> +

This code might work for your design, but likely doesn't work for
everyone and isn't likely to be accepted in its current state.  I think
you need some kind of detection logic here to know if TEMP1_EN *should*
be enabled.  Do we need a device-tree entry for this?


>  		if (config & ADM1278_TEMP1_EN)
>  			info->func[0] |=3D
>  				PMBUS_HAVE_TEMP | PMBUS_HAVE_STATUS_TEMP;
> --=20
> 2.7.4
>=20

--=20
Patrick Williams

--GxcwvYAGnODwn7V8
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEEBGD9ii4LE9cNbqJBqwNHzC0AwRkFAl7RBOAACgkQqwNHzC0A
wRlUkA//cEaRIkB+xtcDWW/e7neekDz/LQI62l2pYd0sfnQQNnDNO0j86e8xO50h
mnDat8c7sEbZNn81ye0wwAX0sN2+Nba5kyl/EYH0tpLfqiqz5QSQDsECFYquZ3bZ
8Hn7ail+Z+FkZOKwOKtAiPm0cXR50DgRZKKcyvF1gHQXwUlYG9n5jxvtyll05VJr
qlr9K/2+Mljn86YyqBie9YlxwE/He+iumE1PR/gWAelB357CtoS6uAjgk0Nu4WSJ
EkMOu/GoivEfBBu/6OlLOG3/riCULgIr8q9lkabUTh6r9+xTzM9RmXckMUTia/Y5
dMXgPMkwobgA62Hs+JDO4irlSmGz8Xzl5LOG1EB3C6z+C14P1oI4K6t6TaCnW2fx
V8xcTCrlNNlbXEbKKXFJOuGGb5BCpEI2mnqcbx/yB+dTXWzgPbrYFjcO5cToZD0/
E7IU4CpQ3o26u8/dQ9irHrGQIQjdRNr9FaNwuUfKZMBcqowh6awA95ton3tpZ+Ns
qrOyAjPbmkokPglGe4BYg20Z3JNnioZzG4s+9+4unK3U+AqvHNHirz43LCXzgyCk
oeigei7klwJX9FUkUF1m2cxo2oJDX/hX07BtemWBnY25kvlL+zCJ7U/BcOfQC8T5
M8jeCwLfEl4G1oOrVND3Q0I2KKMRVxKwxRIxWJLx1qY9j0GzhaE=
=YCrf
-----END PGP SIGNATURE-----

--GxcwvYAGnODwn7V8--