Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH 2/2] m68k,nommu: fix implicit cast from __user in
 __{get,put}_user_asm()
To:     Luc Van Oostenryck <luc.vanoostenryck@gmail.com>,
        Geert Uytterhoeven <geert@linux-m68k.org>
Cc:     linux-m68k@lists.linux-m68k.org, linux-kernel@vger.kernel.org,
        kbuild test robot <lkp@intel.com>
References: <20200528202514.27175-1-luc.vanoostenryck@gmail.com>
 <20200528202514.27175-3-luc.vanoostenryck@gmail.com>
From:   Greg Ungerer <gerg@linux-m68k.org>
Message-ID: <8e2f9ac6-b277-0b80-c150-eb372fbeaf0a@linux-m68k.org>
Date:   Fri, 29 May 2020 23:21:38 +1000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.7.0
MIME-Version: 1.0
In-Reply-To: <20200528202514.27175-3-luc.vanoostenryck@gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi Luc,

On 29/5/20 6:25 am, Luc Van Oostenryck wrote:
> The assembly for __get_user_asm() & __put_user_asm() uses memcpy()
> when the size is 8.
> 
> However, the pointer is always a __user one while memcpy() expect
> a plan one and so this cast creates a lot of warnings when using     ^^^^
Did you mean "plain"?


> Sparse.
> 
> So, fix this by adding a cast to 'void __force *' at memcpy()'s
> argument.
> 
> Reported-by: kbuild test robot <lkp@intel.com>
> Signed-off-by: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
> ---
>   arch/m68k/include/asm/uaccess_no.h | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/m68k/include/asm/uaccess_no.h b/arch/m68k/include/asm/uaccess_no.h
> index 9651766a62af..f32f08a64eaa 100644
> --- a/arch/m68k/include/asm/uaccess_no.h
> +++ b/arch/m68k/include/asm/uaccess_no.h
> @@ -42,7 +42,7 @@ static inline int _access_ok(unsigned long addr, unsigned long size)
>   	__put_user_asm(__pu_err, __pu_val, ptr, l);	\
>   	break;						\
>       case 8:						\
> -	memcpy(ptr, &__pu_val, sizeof (*(ptr))); \
> +	memcpy((void __force*)ptr, &__pu_val, sizeof (*(ptr))); \
                            ^^^
checkpatch wants a ' ' space in there.

Otherwise I think it looks good.

Regards
Greg

  
>   	break;						\
>       default:						\
>   	__pu_err = __put_user_bad();			\
> @@ -85,7 +85,7 @@ extern int __put_user_bad(void);
>   	    u64 l;						\
>   	    __typeof__(*(ptr)) t;				\
>   	} __gu_val;						\
> -	memcpy(&__gu_val.l, ptr, sizeof(__gu_val.l));		\
> +	memcpy(&__gu_val.l, (const void __force*)ptr, sizeof(__gu_val.l));		\
>   	(x) = __gu_val.t;					\
>   	break;							\
>       }								\
>