Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: kc2tV3i8J4VNGJqGPMJP57LuYraXRDkQaxgYnAmL5SaVGgKG75fmt6dz1TNVKDjbiHL5whYEB8
 dT5dF3McMPEg==
IronPort-SDR: NZI9hH+nitIWPQIlbZvARn1Y9JNWrM6DlBBASubVpGXnyhpDF/GqXeTyldLKZnoV6PL0kPXqL2
 1U7OwAgTOgQg==
Subject: Re: Regression with PM / wakeup: Show wakeup sources stats in sysfs"
To:     Florian Fainelli <f.fainelli@gmail.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        trong@android.com, Greg KH <gregkh@linuxfoundation.org>,
        swboyd@chromium.org, kaleshsingh@google.com
References: <11459cde-7f57-c95b-8cac-4301f0a2390e@gmail.com>
From:   "Rafael J. Wysocki" <rafael.j.wysocki@intel.com>
Organization: Intel Technology Poland Sp. z o. o., KRS 101882, ul. Slowackiego
 173, 80-298 Gdansk
Message-ID: <9d75a67b-87f0-161c-02d7-c9fc4efe97e7@intel.com>
Date:   Fri, 29 May 2020 18:51:22 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101
 Thunderbird/68.8.1
MIME-Version: 1.0
In-Reply-To: <11459cde-7f57-c95b-8cac-4301f0a2390e@gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 5/28/2020 10:46 PM, Florian Fainelli wrote:
> Hi,
>
> Commit c8377adfa78103be5380200eb9dab764d7ca890e ("PM / wakeup: Show
> wakeup sources stats in sysfs") is causing some of our tests to fail
> because /sys/class/net/*/device/power/wakeup_count is now 0, despite
> /sys/kernel/debug/wakeup_sources clearly indicating that the Ethernet
> device was responsible for system wake-up.
>
> What's more in looking at /sys/class/wakekup/wakeup2/event_count, we
> have the number of Wake-on-LAN wakeups recorded properly, but
> wakeup_count is desperately 0, why is that?

I need to look at that commit in detail to find out what is going on.


> This is seen on 5.4.43, but it is reproducible on Linus' master as well.
>
> The Ethernet driver being used is under
> drivers/net/ethernet/broadcom/genet/ and the relevant part is in the
> function bcmgenet_set_wol().
>
> BTW, I think you want to backport
> e976eb4b91e906f20ec25b20c152d53c472fc3fd ("PM: wakeup: Show statistics
> for deleted wakeup sources again") into 5.4 and 4.19 at least.

Well, please feel free to send a request to do that to 
stable@vger.kernel.org.

Thanks!