Received: by 2002:a25:ef43:0:0:0:0:0 with SMTP id w3csp729930ybm; Fri, 29 May 2020 10:44:29 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw5Fy5pt/3KpkwhJXa0CXdr0L2L47KNjwVcuaKnDapi0qKyMP70vEiZ/Mgw+1DaVkuWbZCQ X-Received: by 2002:a17:906:1d56:: with SMTP id o22mr2921553ejh.406.1590774269685; Fri, 29 May 2020 10:44:29 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1590774269; cv=none; d=google.com; s=arc-20160816; b=f9YmsQpD6TBL4CT6WeIpPgyz4jPRjUcV0u7AT+gYxPZ/5tqn/A/FeudJDF5oEokjjk uMUoKnOIQFR12kJAuCH6bQ2X/iiHM4IqyugOQjD/7G0FdUaS3x16WiEOaYy9mgmVSnHZ uwdBcPuja7Yzo27exh+/qyNz/OWM/V8tsGh76NL+aB33lkSd2Er+Y0zz8ZNL/jqlwrcW 6XgQBog+koXJdkCgNHrgXtfcj7UlHxGrP237+ef5wIKekC3veZ+IIusCIFWgwcN1xJQh aiiChUX9cXEGgd78yN34dnL8lH3IDsRlUJ+G43oozxs2uHkixRbG2uTou51oW+30MYJO WZTQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=s3r/iapVXgrcJxtZNrIWr+N7ZCEpwcuyYvykIU8ZsW4=; b=TyodKLGw969bFOIVuY4jh06Cz5jZqsXZZBH4S7XrtiNmI7Um66U6O5NYKqppJul32N hgt2bTeIXw9sAKdVcMtGIXvnsc3R4iBqeNC/jHrhRHd0/CcnW3T/7KagfPu5aZ+XgmdU vkviwXBgICSSeg7iCUvP0TrPWRt5womjfurh992lBBYXJPfwm1PBWc+13LWr+4NO5uwN oLzNMHJWshTYI92/dFzPc0ug6PzGVTPXlMUEgjl48woYnDSVeoqNtaBPJiOWuipP/xj4 2W4zREIy+MQQP7P/bTKrXqcHszUxeDWFUuwZFD6g6f0Ntt/X4wtNjLp07TaBfbr+BKRV WJ+A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id g4si6940093edn.285.2020.05.29.10.44.06; Fri, 29 May 2020 10:44:29 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728037AbgE2Rlt (ORCPT + 99 others); Fri, 29 May 2020 13:41:49 -0400 Received: from outpost17.zedat.fu-berlin.de ([130.133.4.110]:39935 "EHLO outpost17.zedat.fu-berlin.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726974AbgE2Rls (ORCPT ); Fri, 29 May 2020 13:41:48 -0400 Received: from relay1.zedat.fu-berlin.de ([130.133.4.67]) by outpost.zedat.fu-berlin.de (Exim 4.93) with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (envelope-from ) id 1jeitq-002w2G-JN; Fri, 29 May 2020 19:34:30 +0200 Received: from z6.physik.fu-berlin.de ([160.45.32.137] helo=z6) by relay1.zedat.fu-berlin.de (Exim 4.93) with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (envelope-from ) id 1jeitq-001GCl-Gk; Fri, 29 May 2020 19:34:30 +0200 Received: from glaubitz by z6 with local (Exim 4.93) (envelope-from ) id 1jeiti-00HZHI-QL; Fri, 29 May 2020 19:34:22 +0200 From: John Paul Adrian Glaubitz To: linux-sh@vger.kernel.org Cc: Rich Felker , Yoshinori Sato , Geert Uytterhoeven , Michael Karcher , linux-kernel@vger.kernel.org, John Paul Adrian Glaubitz Subject: [PATCH] sh: Implement __get_user_u64() required for 64-bit get_user() Date: Fri, 29 May 2020 19:34:19 +0200 Message-Id: <20200529173419.4185337-2-glaubitz@physik.fu-berlin.de> X-Mailer: git-send-email 2.27.0.rc2 In-Reply-To: <20200529173419.4185337-1-glaubitz@physik.fu-berlin.de> References: <20200529173419.4185337-1-glaubitz@physik.fu-berlin.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Originating-IP: 160.45.32.137 X-ZEDAT-Hint: RV Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Trying to build the kernel with CONFIG_INFINIBAND_USER_ACCESS enabled fails ERROR: "__get_user_unknown" [drivers/infiniband/core/ib_uverbs.ko] undefined! with on SH since the kernel misses a 64-bit implementation of get_user(). Implement the missing 64-bit get_user() as __get_user_u64(), matching the already existing __put_user_u64() which implements the 64-bit put_user(). Signed-off-by: John Paul Adrian Glaubitz --- arch/sh/include/asm/uaccess_32.h | 49 ++++++++++++++++++++++++++++++++ 1 file changed, 49 insertions(+) diff --git a/arch/sh/include/asm/uaccess_32.h b/arch/sh/include/asm/uaccess_32.h index 624cf55acc27..8bc1cb50f8bf 100644 --- a/arch/sh/include/asm/uaccess_32.h +++ b/arch/sh/include/asm/uaccess_32.h @@ -26,6 +26,9 @@ do { \ case 4: \ __get_user_asm(x, ptr, retval, "l"); \ break; \ + case 8: \ + __get_user_u64(x, ptr, retval); \ + break; \ default: \ __get_user_unknown(); \ break; \ @@ -66,6 +69,52 @@ do { \ extern void __get_user_unknown(void); +#if defined(CONFIG_CPU_LITTLE_ENDIAN) +#define __get_user_u64(x, addr, err) \ +({ \ +__asm__ __volatile__( \ + "1:\n\t" \ + "mov.l %2,%R1\n\t" \ + "mov.l %T2,%S1\n\t" \ + "2:\n" \ + ".section .fixup,\"ax\"\n" \ + "3:\n\t" \ + "mov #0, %1\n\t" \ + "mov.l 4f, %0\n\t" \ + "jmp @%0\n\t" \ + " mov %3, %0\n\t" \ + ".balign 4\n" \ + "4: .long 2b\n\t" \ + ".previous\n" \ + ".section __ex_table,\"a\"\n\t" \ + ".long 1b, 3b\n\t" \ + ".previous" \ + :"=&r" (err), "=&r" (x) \ + :"m" (__m(addr)), "i" (-EFAULT), "0" (err)); }) +#else +#define __get_user_u64(x, addr, err) \ +({ \ +__asm__ __volatile__( \ + "1:\n\t" \ + "mov.l %2,%S1\n\t" \ + "mov.l %T2,%R1\n\t" \ + "2:\n" \ + ".section .fixup,\"ax\"\n" \ + "3:\n\t" \ + "mov #0, %1\n\t" \ + "mov.l 4f, %0\n\t" \ + "jmp @%0\n\t" \ + " mov %3, %0\n\t" \ + ".balign 4\n" \ + "4: .long 2b\n\t" \ + ".previous\n" \ + ".section __ex_table,\"a\"\n\t" \ + ".long 1b, 3b\n\t" \ + ".previous" \ + :"=&r" (err), "=&r" (x) \ + :"m" (__m(addr)), "i" (-EFAULT), "0" (err)); }) +#endif + #define __put_user_size(x,ptr,size,retval) \ do { \ retval = 0; \ -- 2.27.0.rc2