Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Fri, 29 May 2020 12:42:10 -0500
From:   Patrick Williams <patrick@stwcx.xyz>
To:     Guenter Roeck <linux@roeck-us.net>
Cc:     Manikandan Elumalai <manikandan.hcl.ers.epl@gmail.com>,
        linux-hwmon@vger.kernel.org, linux-aspeed@lists.ozlabs.org,
        linux-kernel@vger.kernel.org, openbmc@lists.ozlabs.org,
        manikandan.e@hcl.com, saipsdasari@fb.com, patrickw3@fb.com,
        vijaykhemka@fb.com
Subject: Re: [PATCH v2] hwmon:(adm1275) Enable adm1278 ADM1278_TEMP1_EN
Message-ID: <20200529174210.GF17541@heinlein>
References: <20200529124607.GA3469@cnn>
 <49485085-7cc7-9e29-a719-98d1e184378b@roeck-us.net>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="qp4W5+cUSnZs0RIF"
Content-Disposition: inline
In-Reply-To: <49485085-7cc7-9e29-a719-98d1e184378b@roeck-us.net>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


--qp4W5+cUSnZs0RIF
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi Guenter,

Thanks for the initial look at this.

One question for you below...

On Fri, May 29, 2020 at 10:30:16AM -0700, Guenter Roeck wrote:
> On 5/29/20 5:46 AM, Manikandan Elumalai wrote:
> > +		/* Enable TEMP1 by default */
> > +		config |=3D ADM1278_TEMP1_EN;
> > +		ret =3D i2c_smbus_write_byte_data(client,
> > +					ADM1275_PMON_CONFIG,
> > +					config);
> > +		if (ret < 0) {
> > +		dev_err(&client->dev,
> > +			"Failed to enable temperature config\n");
> > +		return -ENODEV;
> > +		}
>=20
> This can be handled in a single operation, together with ADM1278_VOUT_EN
> below. There is no need for two separate write operations.

I don't know if you noticed here but the change ends up enabling
TEMP1_EN in all cases.  Is this acceptable?  If not, do you have any
preference on how it is selected for enablement?

> >  		/* Enable VOUT if not enabled (it is disabled by default) */
> >  		if (!(config & ADM1278_VOUT_EN)) {
> > @@ -681,9 +697,6 @@ static int adm1275_probe(struct i2c_client *client,
> >  			}
> >  		}
> > =20
> > -		if (config & ADM1278_TEMP1_EN)
> > -			info->func[0] |=3D
> > -				PMBUS_HAVE_TEMP | PMBUS_HAVE_STATUS_TEMP;
> >  		if (config & ADM1278_VIN_EN)
> >  			info->func[0] |=3D PMBUS_HAVE_VIN;
> >  		break;
> >=20
>=20

--=20
Patrick Williams

--qp4W5+cUSnZs0RIF
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEEBGD9ii4LE9cNbqJBqwNHzC0AwRkFAl7RSXAACgkQqwNHzC0A
wRmWhBAAl+LdXJe7Ab9nypMWBYkhPdmwxWp+qtt+f4CFJyorYFFDNC01yFawHWIz
bBd+VP5hoLPgHaijLr44ZV/UauINiggqaqEEETcfyXymPXMCCsv9Vp1by4jIGe2h
AQRLdIMHDxBrDNgAnLRL1oBoRENn9fA+8K1c2rp/+HQxicdGdj6huxaLhqpLm1gk
g/U5uP5L5T27xER1WxYiUUgsnl0I8gxWH3Gg7trT0g+YUMVofCuwXZIeUXTD2mkN
I2wpNfA/duL+HtHyHExA7UAyOOX8m6obWFaYZ8hxuJvbM2K7ztUmCSUgNb5WIXUi
E4OCYNIhcEjd7wKtM2tWiRYHRAEH2NdPRqpcPKTHeY4aOnpZoHdDuX9pXU6nsFoo
kG9Dy/uOWUH9tzjzZs5p3Swo2FwnHhavWQV/cIycJE2akr1uPh8S0Db9WG701tQ4
BaNi/GAz97hpq37kBuNqnUtspugW4b5wVQ/N5JZD0dr9Iego7bdCd3zF5vu6fnnt
k262KDW3+x8vQT4/dWKF4IY01g6EXBmWZZiounv6Gkg/r/GOipRep2kRvGWN/Wdp
4hZFty0CH7DoNWVaMaJntIJtMW88JRKRJ49iWD5V6GhQptNcdYStgwiL4dPF2eK/
XMO3oKnuTPg5jgvbsNSSnfJlHcevHYcMD4jQ3/xj1RJLaxteEyA=
=TuCV
-----END PGP SIGNATURE-----

--qp4W5+cUSnZs0RIF--