Received: by 2002:a25:ef43:0:0:0:0:0 with SMTP id w3csp733627ybm; Fri, 29 May 2020 10:50:36 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxHZPmaD2mLQrNub+nef/gtn3knh1pgSrHIE8SRDCJRG1b++c2DkUgqh6d3MuvtlLu34+DQ X-Received: by 2002:a17:906:200a:: with SMTP id 10mr8506996ejo.294.1590774636132; Fri, 29 May 2020 10:50:36 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1590774636; cv=none; d=google.com; s=arc-20160816; b=EMmaPEF/J2okbmJrNVtg5zPn0BBw47WJO1UVOiUB5PlX+uM7epqN6o+jj7T+Sji3Ek QPISiw4Mj/5+z7VmlqMoUwdErslKt5lPe+4qcoHHL4MSZtkqH9g71CLhZiaDYKcgREIi vMPVBdyNT58jyIzNToZJu26lUPe4BvG7+Clk7/cdRN1I64/ogZdLsdFlCso0KrsG88FY PlYP9twz8Ilpy8hLWW3Vp3jmNxbvfNb97t2YD7G/E6nRlqmCGKxvb0ZOGsW/rNAouJFu AJzF+qykkkIRKVKvAc9LqbwXPKCMqWeltdNZCEMC0r34P1H/eYHU3ONA3/C+sfKTixpN xpYA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:autocrypt:from:references:cc:to:subject:dkim-signature; bh=6Rv5SA7rEEWadacdKzoRE59Y/TEcxGFe+BCDuztO2sA=; b=NQH9N+OlAL8EBH1DuuJS8dztcTkvQfpBFVglvEwLaz1GI/8ozO5JcjmtKTRLmngIEB 5wTB7Dqj0tM/Z0J02haYBUTx0J0zN3H8SlRMphxuWnZtb9jVX02JIzel92uT1zDKOZYa 3BkEdrKe0nndaiVXO7uaLX/ypqVv1RwrL4NlzeLbbdXvtKEzE2ibL5H5juWSuFbEK93R rEPL4CjG/20ZaUSY4Yr1NEbsvBmezAe8dBExunt14iqX+TL8z7xQb5bieM6ty1oY/OKs 9WiuWPSx5OvXidn+N8LxlTNVA5iuDp0lTF/nrYxbLRsbkfR7c7qRb+EMe9cJBmCg7Clh X5Mg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=Ho4IKGa0; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id ss4si2331312ejb.645.2020.05.29.10.50.12; Fri, 29 May 2020 10:50:36 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=Ho4IKGa0; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727071AbgE2RsQ (ORCPT + 99 others); Fri, 29 May 2020 13:48:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43378 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725601AbgE2RsQ (ORCPT ); Fri, 29 May 2020 13:48:16 -0400 Received: from mail-il1-x141.google.com (mail-il1-x141.google.com [IPv6:2607:f8b0:4864:20::141]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 13854C03E969; Fri, 29 May 2020 10:48:15 -0700 (PDT) Received: by mail-il1-x141.google.com with SMTP id j3so3283212ilk.11; Fri, 29 May 2020 10:48:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:autocrypt:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=6Rv5SA7rEEWadacdKzoRE59Y/TEcxGFe+BCDuztO2sA=; b=Ho4IKGa0Y8zrbcjCC83ju+HkaLsiOnRkX6NNKak/D8EtJL4k/QYJ1tvYlMwoWYkp8a 61fMcYfx09NNcpYYWSkmPOcDxgAHCdjlEipMMX2sqArH/e2zTFfLhgfgF8sgmh6eLncP gNWSpEJCvlU+H2yhUiafjeY0qB6EBTZ2+vmruXeqTsNp35e6NDG52FFU1uP7txxMESqB gseD6idw4eYwvr534fQoBNK0CtEljzGtyvwfOMI48LRaAiLzwtw5HPnbB2l0UKdQTuHy c4Xis1tfZAfJeAQID8cA8pJlJiwaYUkSWKn2GKULQBSAA6RfNBCGMa8lPA8YvBhhoVlu Jdpg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:autocrypt :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=6Rv5SA7rEEWadacdKzoRE59Y/TEcxGFe+BCDuztO2sA=; b=iI7TKEWgeRBi8qnm9AwQOIPCTsopghjlsFwP9/lTb0wlftBBYCbsdyzbQdikTYi+yP xZ+aS5PnPomYaOCqWQE61uhn7uAanxXIjkgVJYutgt5ra9s3z6ZxXnzDIY1K/OhSZevK 8t9k/oK5IbZPgmtylf8bbPcDlMSXkww5YuHSy6OnEaBGcdDwN/qXAB9mWZlzYOhb3x5D djosEXZ4CAT7RahtDdWQiq3d32qphjg8Ba+Lc7qWcY59inJMkvzzZZe05WG4khS96TDI ryCOTNw4b4UGepeYtrrMvRW07+j6aqdlZNX/KPIvPxWd/ID8KvRgCapHEGPQxxzFqQtD W8WA== X-Gm-Message-State: AOAM532wxh1ZQz9pt3JWVDO62reQNV5JK6Wo4v7nPH1mx6L38jS7Bqlq TJfs+Jov23it7nllHB/lf4c= X-Received: by 2002:a92:5fca:: with SMTP id i71mr8156390ill.306.1590774494422; Fri, 29 May 2020 10:48:14 -0700 (PDT) Received: from [10.67.49.116] ([192.19.223.252]) by smtp.googlemail.com with ESMTPSA id u20sm3975714iom.30.2020.05.29.10.48.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 29 May 2020 10:48:13 -0700 (PDT) Subject: Re: [PATCH] spi: bcm2835: Implement shutdown callback To: Lukas Wunner , Florian Fainelli Cc: linux-kernel@vger.kernel.org, Mark Brown , Ray Jui , Scott Branden , "maintainer:BROADCOM BCM281XX/BCM11XXX/BCM216XX ARM ARCHITE..." , Nicolas Saenz Julienne , "open list:SPI SUBSYSTEM" , "moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE" , "moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE" References: <20200528190605.24850-1-f.fainelli@gmail.com> <20200529174719.5tvchnoov747fm2x@wunner.de> From: Florian Fainelli Autocrypt: addr=f.fainelli@gmail.com; prefer-encrypt=mutual; keydata= xsDiBEjPuBIRBACW9MxSJU9fvEOCTnRNqG/13rAGsj+vJqontvoDSNxRgmafP8d3nesnqPyR xGlkaOSDuu09rxuW+69Y2f1TzjFuGpBk4ysWOR85O2Nx8AJ6fYGCoeTbovrNlGT1M9obSFGQ X3IzRnWoqlfudjTO5TKoqkbOgpYqIo5n1QbEjCCwCwCg3DOH/4ug2AUUlcIT9/l3pGvoRJ0E AICDzi3l7pmC5IWn2n1mvP5247urtHFs/uusE827DDj3K8Upn2vYiOFMBhGsxAk6YKV6IP0d ZdWX6fqkJJlu9cSDvWtO1hXeHIfQIE/xcqvlRH783KrihLcsmnBqOiS6rJDO2x1eAgC8meAX SAgsrBhcgGl2Rl5gh/jkeA5ykwbxA/9u1eEuL70Qzt5APJmqVXR+kWvrqdBVPoUNy/tQ8mYc nzJJ63ng3tHhnwHXZOu8hL4nqwlYHRa9eeglXYhBqja4ZvIvCEqSmEukfivk+DlIgVoOAJbh qIWgvr3SIEuR6ayY3f5j0f2ejUMYlYYnKdiHXFlF9uXm1ELrb0YX4GMHz80nRmxvcmlhbiBG YWluZWxsaSA8Zi5mYWluZWxsaUBnbWFpbC5jb20+wmYEExECACYCGyMGCwkIBwMCBBUCCAME FgIDAQIeAQIXgAUCVF/S8QUJHlwd3wAKCRBhV5kVtWN2DvCVAJ4u4/bPF4P3jxb4qEY8I2gS 6hG0gACffNWlqJ2T4wSSn+3o7CCZNd7SLSDOwU0EVxvH8AEQAOqv6agYuT4x3DgFIJNv9i0e S443rCudGwmg+CbjXGA4RUe1bNdPHYgbbIaN8PFkXfb4jqg64SyU66FXJJJO+DmPK/t7dRNA 3eMB1h0GbAHlLzsAzD0DKk1ARbjIusnc02aRQNsAUfceqH5fAMfs2hgXBa0ZUJ4bLly5zNbr r0t/fqZsyI2rGQT9h1D5OYn4oF3KXpSpo+orJD93PEDeseho1EpmMfsVH7PxjVUlNVzmZ+tc IDw24CDSXf0xxnaojoicQi7kzKpUrJodfhNXUnX2JAm/d0f9GR7zClpQMezJ2hYAX7BvBajb Wbtzwi34s8lWGI121VjtQNt64mSqsK0iQAE6OYk0uuQbmMaxbBTT63+04rTPBO+gRAWZNDmQ b2cTLjrOmdaiPGClSlKx1RhatzW7j1gnUbpfUl91Xzrp6/Rr9BgAZydBE/iu57KWsdMaqu84 JzO9UBGomh9eyBWBkrBt+Fe1qN78kM7JO6i3/QI56NA4SflV+N4PPgI8TjDVaxgrfUTV0gVa cr9gDE5VgnSeSiOleChM1jOByZu0JTShOkT6AcSVW0kCz3fUrd4e5sS3J3uJezSvXjYDZ53k +0GS/Hy//7PSvDbNVretLkDWL24Sgxu/v8i3JiYIxe+F5Br8QpkwNa1tm7FK4jOd95xvYADl BUI1EZMCPI7zABEBAAHCwagEGBECAAkFAlcbx/ACGwICKQkQYVeZFbVjdg7BXSAEGQECAAYF Alcbx/AACgkQh9CWnEQHBwSJBw//Z5n6IO19mVzMy/ZLU/vu8flv0Aa0kwk5qvDyvuvfiDTd WQzq2PLs+obX0y1ffntluhvP+8yLzg7h5O6/skOfOV26ZYD9FeV3PIgR3QYF26p2Ocwa3B/k P6ENkk2pRL2hh6jaA1Bsi0P34iqC2UzzLq+exctXPa07ioknTIJ09BT31lQ36Udg7NIKalnj 5UbkRjqApZ+Rp0RAP9jFtq1n/gjvZGyEfuuo/G+EVCaiCt3Vp/cWxDYf2qsX6JxkwmUNswuL C3duQ0AOMNYrT6Pn+Vf0kMboZ5UJEzgnSe2/5m8v6TUc9ZbC5I517niyC4+4DY8E2m2V2LS9 es9uKpA0yNcd4PfEf8bp29/30MEfBWOf80b1yaubrP5y7yLzplcGRZMF3PgBfi0iGo6kM/V2 13iD/wQ45QTV0WTXaHVbklOdRDXDHIpT69hFJ6hAKnnM7AhqZ70Qi31UHkma9i/TeLLzYYXz zhLHGIYaR04dFT8sSKTwTSqvm8rmDzMpN54/NeDSoSJitDuIE8givW/oGQFb0HGAF70qLgp0 2XiUazRyRU4E4LuhNHGsUxoHOc80B3l+u3jM6xqJht2ZyMZndbAG4LyVA2g9hq2JbpX8BlsF skzW1kbzIoIVXT5EhelxYEGqLFsZFdDhCy8tjePOWK069lKuuFSssaZ3C4edHtkZ8gCfWWtA 8dMsqeOIg9Trx7ZBCDOZGNAAnjYQmSb2eYOAti3PX3Ex7vI8ZhJCzsNNBEjPuBIQEAC/6NPW 6EfQ91ZNU7e/oKWK91kOoYGFTjfdOatp3RKANidHUMSTUcN7J2mxww80AQHKjr3Yu2InXwVX SotMMR4UrkQX7jqabqXV5G+88bj0Lkr3gi6qmVkUPgnNkIBe0gaoM523ujYKLreal2OQ3GoJ PS6hTRoSUM1BhwLCLIWqdX9AdT6FMlDXhCJ1ffA/F3f3nTN5oTvZ0aVF0SvQb7eIhGVFxrlb WS0+dpyulr9hGdU4kzoqmZX9T/r8WCwcfXipmmz3Zt8o2pYWPMq9Utby9IEgPwultaP06MHY nhda1jfzGB5ZKco/XEaXNvNYADtAD91dRtNGMwRHWMotIGiWwhEJ6vFc9bw1xcR88oYBs+7p gbFSpmMGYAPA66wdDKGj9+cLhkd0SXGht9AJyaRA5AWB85yNmqcXXLkzzh2chIpSEawRsw8B rQIZXc5QaAcBN2dzGN9UzqQArtWaTTjMrGesYhN+aVpMHNCmJuISQORhX5lkjeg54oplt6Zn QyIsOCH3MfG95ha0TgWwyFtdxOdY/UY2zv5wGivZ3WeS0TtQf/BcGre2y85rAohFziWOzTaS BKZKDaBFHwnGcJi61Pnjkz82hena8OmsnsBIucsz4N0wE+hVd6AbDYN8ZcFNIDyt7+oGD1+c PfqLz2df6qjXzq27BBUboklbGUObNwADBQ//V45Z51Q4fRl/6/+oY5q+FPbRLDPlUF2lV6mb hymkpqIzi1Aj/2FUKOyImGjbLAkuBQj3uMqy+BSSXyQLG3sg8pDDe8AJwXDpG2fQTyTzQm6l OnaMCzosvALk2EOPJryMkOCI52+hk67cSFA0HjgTbkAv4Mssd52y/5VZR28a+LW+mJIZDurI Y14UIe50G99xYxjuD1lNdTa/Yv6qFfEAqNdjEBKNuOEUQOlTLndOsvxOOPa1mRUk8Bqm9BUt LHk3GDb8bfDwdos1/h2QPEi+eI+O/bm8YX7qE7uZ13bRWBY+S4+cd+Cyj8ezKYAJo9B+0g4a RVhdhc3AtW44lvZo1h2iml9twMLfewKkGV3oG35CcF9mOd7n6vDad3teeNpYd/5qYhkopQrG k2oRBqxyvpSLrJepsyaIpfrt5NNaH7yTCtGXcxlGf2jzGdei6H4xQPjDcVq2Ra5GJohnb/ix uOc0pWciL80ohtpSspLlWoPiIowiKJu/D/Y0bQdatUOZcGadkywCZc/dg5hcAYNYchc8AwA4 2dp6w8SlIsm1yIGafWlNnfvqbRBglSTnxFuKqVggiz2zk+1wa/oP+B96lm7N4/3Aw6uy7lWC HvsHIcv4lxCWkFXkwsuWqzEKK6kxVpRDoEQPDj+Oy/ZJ5fYuMbkdHrlegwoQ64LrqdmiVVPC TwQYEQIADwIbDAUCVF/S8QUJHlwd3wAKCRBhV5kVtWN2Do+FAJ956xSz2XpDHql+Wg/2qv3b G10n8gCguORqNGMsVRxrlLs7/himep7MrCc= Message-ID: Date: Fri, 29 May 2020 10:48:11 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 MIME-Version: 1.0 In-Reply-To: <20200529174719.5tvchnoov747fm2x@wunner.de> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 5/29/20 10:47 AM, Lukas Wunner wrote: > On Thu, May 28, 2020 at 12:06:05PM -0700, Florian Fainelli wrote: >> Make sure we clear the FIFOs, stop the block, disable the clock and >> release the DMA channel. > > To what end? Why is this change necessary? Sorry but this seems like > an awfully terse commit message. To ensure clocks are disabled and to save power in low power modes used on 7211 for instance. -- Florian