Received: by 2002:a25:ef43:0:0:0:0:0 with SMTP id w3csp733979ybm; Fri, 29 May 2020 10:51:15 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwyp5FXinLftYgqqQWq4RJlibfRw7VFZleNFULbxwJLAnm8U/u0Olxb3plWcDkHMHrcO1Y3 X-Received: by 2002:a17:906:4d82:: with SMTP id s2mr8434373eju.542.1590774675401; Fri, 29 May 2020 10:51:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1590774675; cv=none; d=google.com; s=arc-20160816; b=ewCudflNAoXgpKWpBsIAvRsBPIBPRJe/4dVwqIFAlDj3oFqzd/ZfQW09QTxwZVMnWa gxu1tKP7P2JypdXqrfJZJLQngS/Dpj2V/n+/pBo4wIltAgSA60E4UDiprsFYikXEGgSn 5X4OTvvRALvlOhATIfvX0nM8Ri9t1FM/MH4u5lJmiLaKLJsPLIIrIX9R/GZ3OpEaH0e4 C3tus0uekALHaetMQbIS71vFffGfMaCoKSXlFg8F5csRaVx4SQceNp2Uo74Bq0AZVL2t wlVNG2gbRd4k8jKeRfImnTIo7Pu9xKaFkgxrD3jLkHqunDtvuFG9ld3ZV87rppQnWzCR gT6g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=q+NxJySvQ2Q6kPp/WgvAdeuX77Yao8+d9yohSOyArEg=; b=NjNF3Aqm1sagGL9H/fNSrCWdlh1/u1fcHzb4bzNbPUljXRHNA02fcZN4vKU9REo1xE 1RSafhry6Z9YK4d5IWcwdTm4mvNstsqT2x22u7YIv86ZR3D10eSFyXA6cWckXWDKOVgw dcjN7UBnzgTngmtfKqRlpion2C0VXY//xc1XUX97QP28RvNOfN6sYOfWoa1oqZLvUz9R JU+FSEtG6uuxIyCrRsm6awgYSLOtuLgONoypQUk1OU0sPf7jGjLqH8AHeACHg5PafSym iuJ2GAkLF6ajR7laZgglaVVmKdzgSVbD1u48wdsFWJzRghZdh417TnG/yl3lHP34edrB 3dkw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=yUOrG3IQ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id j93si6250371edb.327.2020.05.29.10.50.52; Fri, 29 May 2020 10:51:15 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=yUOrG3IQ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727956AbgE2RsI (ORCPT + 99 others); Fri, 29 May 2020 13:48:08 -0400 Received: from mail.kernel.org ([198.145.29.99]:42498 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725601AbgE2RsI (ORCPT ); Fri, 29 May 2020 13:48:08 -0400 Received: from localhost (fw-tnat.cambridge.arm.com [217.140.96.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 1C4F42067B; Fri, 29 May 2020 17:48:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1590774487; bh=CU5XueM8Uren8tTTQCGNaREQdasKk9IK8u1gailMNuc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=yUOrG3IQUBxZeEU18buHBc1e/yA0krknShpUNLJO5bKUFHyrx8iPsyv/K6qfFHLs0 gOHg6SjZFKD8kCRcH48S3sWAIMFNs+kJUDc1PIx7CpM1jWKlMhTs7kVXPTl6eBi39A 3ghzEceZBLYEdbmGjtQ4TPc5MQAOWlHsVxDvSNoc= Date: Fri, 29 May 2020 18:48:04 +0100 From: Mark Brown To: Lukas Wunner Cc: Nicolas Saenz Julienne , Florian Fainelli , Ray Jui , Scott Branden , bcm-kernel-feedback-list@broadcom.com, Martin Sperl , linux-spi@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] spi: bcm2835: Enable shared interrupt support Message-ID: <20200529174804.GT4610@sirena.org.uk> References: <20200528185805.28991-1-nsaenzjulienne@suse.de> <20200529174358.som3snunfxch6phi@wunner.de> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="4AfY4lbNVy6SI0IG" Content-Disposition: inline In-Reply-To: <20200529174358.som3snunfxch6phi@wunner.de> X-Cookie: The Killer Ducks are coming!!! User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --4AfY4lbNVy6SI0IG Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, May 29, 2020 at 07:43:58PM +0200, Lukas Wunner wrote: > This definitely looks wrong. The check whether the interrupt is enabled > should be moved *before* the conditional calls to bcm2835_rd_fifo_blind() > and bcm2835_wr_fifo_blind(), i.e. to the top of the function. Hrm, right - I'll drop the patch. --4AfY4lbNVy6SI0IG Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAl7RStQACgkQJNaLcl1U h9DEcwf/UwyI2LMBvPyY58CcQXrZF5LFTL5YDrcWyvT7nhTkEmJjEepRcXdJFavZ 3F8+5aFweraNFenwqNcTnmpspdIzp45E+ZeaEayzqINHQcPj/QAmCTVwFK/vULr4 XxNwzuiOQz3vIPjaqiJGjIE1jBSltoykiKqMY9B0cHyYPXvqEfrobAZHLWnLYdr5 XIhKIEX2Txj0WvGGbZOUK4wiG8/bj+y1jIVHiOqljCIgcjb06ws739t7UhrWM1HB ZhATvhbiirr0wNcA8oG0mXmgK+vMVTvWenbXxlhReTkbMWG6x8uzCv3rg7aCE02a 4/IdOSFJQ3i6acyBkGgJO5mcHXYXxg== =gcEl -----END PGP SIGNATURE----- --4AfY4lbNVy6SI0IG--