Received: by 2002:a25:ef43:0:0:0:0:0 with SMTP id w3csp751108ybm; Fri, 29 May 2020 11:14:36 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwVPescGYfWE5JhpbylxkoIW98w6dPjkxPs0VJRmqsPlUXckOzkX2EwZV/4vIs98U3G/gtu X-Received: by 2002:a17:906:a8d:: with SMTP id y13mr8591099ejf.455.1590776075949; Fri, 29 May 2020 11:14:35 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1590776075; cv=none; d=google.com; s=arc-20160816; b=iRSnGyRE+GKiH/CicGmRF+F8Z5lBo+BKR7glR4u2GznOZtS/myq8k0ZvxGZwGGji4q VpSJWNEppwvzWL2YE4wVjwzH21kQbZo9BcdEORo6fPc9SRAwdaNQ6OhjGD8KSLHhfrLI rayU9V7+CeTU8Kk7pR5idYuj5SlbrDmHCGYwQB3YEguj2TwWluNOxnr0FFfytReoZfEH vn8B1hBTEh72bhyC2vwlJ5DdXr4nKQp/wuMy17eH+wKhqTI10L+edBHUyXTVh9R8TY1J W1XaCx7Q/aN/52bK34+gA87uM1nPGOUxhpkI/ux1fhq+2XW9ITZ9FZ2edy44ACoCJINR aAsQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:dkim-signature; bh=80vBavyDrtgkerq51SzM+QtqxhSCU7Go2pUSAaWO15M=; b=NL8ZRKZ6zaCkH7r4AoCqDT8Ouz/nOE8AkvFtu+gti+xAR7/RQ9/JEryCjzL+yK8yVx 5s84eb8QGOdZNRSgYA05FEmPpQyPSs2ZO0yy3VILd8Z3Kq0QtjkFoMkIS0S3YEDuq4gR 7xSqxZYZNB5sEN3cBUNA9mMNu8j7dSnSDcBSpBzuPn2PkGHpsjUZLshP9kHf1fs9LupX yqznL1SuMb5CQW6Ug5qIVBuiRburcxbLu4Mb0ZaaSyR/7rdwQ9/29HB7gmtsKRkgGVsy uSUEuRsjHaTY1uj08FJfjlX7K3woNJOTcSk8Z9dy5RTgZdfvb6J0GIQ8w6RspWdmNUs6 9XFQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=QCvzld6V; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id i21si6253778ejy.399.2020.05.29.11.14.12; Fri, 29 May 2020 11:14:35 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=QCvzld6V; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727947AbgE2SJ7 (ORCPT + 99 others); Fri, 29 May 2020 14:09:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46778 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726866AbgE2SJ6 (ORCPT ); Fri, 29 May 2020 14:09:58 -0400 Received: from mail-pg1-x543.google.com (mail-pg1-x543.google.com [IPv6:2607:f8b0:4864:20::543]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7F155C03E969; Fri, 29 May 2020 11:09:58 -0700 (PDT) Received: by mail-pg1-x543.google.com with SMTP id d10so243221pgn.4; Fri, 29 May 2020 11:09:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=80vBavyDrtgkerq51SzM+QtqxhSCU7Go2pUSAaWO15M=; b=QCvzld6VvUsBMgKQk0LAhOxI8cd484PIDwr1VSe/D6VcAFbaJctQmwvzPM1QsuCiEG mxnEnP8HQ9hl50f0zlImq4xCli8HQ/1oU9fG7PdCx+wtYdTe8LyTijodfelKPLiiInJ5 LemgEd82KY5cAAykEwERcAhd2967MGMvkuUguVJRbU+Sea9JS6KFPGNxN0OfX4GrKI50 aUIRFL1FSPQaHh5rIXCkimVbxTHfEV1aJuUi5vsRZUKX7vWEwwIsEEDo5CctW0v52LtR ok/6BX5zH4QYc8ebzQ9gr3xJsNrc0yoXt49R17g4yAS4ECag3oRXHAEekXGTs5wo60ui dTrA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=80vBavyDrtgkerq51SzM+QtqxhSCU7Go2pUSAaWO15M=; b=ME7cjoOgakNqTOxDddjYpNx0x7Py9moxVhRDBbM1pXnjtxRu31GsiYwgO0wyYw8ipq SNlwapt/j7lWwWWwv9rltb6cvyhvHLsOpl6UkEGbtHTutfLA1nJVLGw/51OolI1ajrF/ zcjHY1z8QCt53yUNdJlvhhdsun5M/2/r76Zmz00Y0NbpJkHChJndXYX0P2etKXmc7lAP 69FPi2O/OShkunQby5lIJqd0cJbiv8ru+wt7xk6GUo3V8xnZDP8CsRYiOpkZrCOVjqJo ZK798hRAKTyX0REBXROMsNavgWVDviJq4u2ObsMMo6zneqgTyvwtMOjoW7m6x39jwzIu vFOA== X-Gm-Message-State: AOAM530Go2h1IEMqBQqLqjzwVKIKEjkO2ak+i+drZ2nOr1eUGBQsJ0ho jgkTVbyqFw5m1FkGQO9NKfg= X-Received: by 2002:aa7:9d92:: with SMTP id f18mr10064301pfq.266.1590775798042; Fri, 29 May 2020 11:09:58 -0700 (PDT) Received: from [192.168.86.235] (c-73-241-150-58.hsd1.ca.comcast.net. [73.241.150.58]) by smtp.gmail.com with ESMTPSA id b15sm120523pjb.18.2020.05.29.11.09.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 29 May 2020 11:09:57 -0700 (PDT) Subject: Re: general protection fault in inet_unhash To: Andrii Nakryiko , Dmitry Vyukov Cc: syzbot , Alexei Starovoitov , David Miller , guro@fb.com, kuba@kernel.org, Alexey Kuznetsov , LKML , netdev , syzkaller-bugs , Hideaki YOSHIFUJI References: <00000000000018e1d305a6b80a73@google.com> From: Eric Dumazet Message-ID: <0d25f022-e68d-6a46-e0ad-813b56c66a88@gmail.com> Date: Fri, 29 May 2020 11:09:45 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 5/29/20 10:32 AM, Eric Dumazet wrote: > L2TP seems to use sk->sk_node to insert sockets into l2tp_ip_table, _and_ uses l2tp_ip_prot.unhash == inet_unhash > > So if/when BPF_CGROUP_RUN_PROG_INET_SOCK(sk) returns an error and inet_create() calls sk_common_release() > bad things happen, because inet_unhash() expects a valid hashinfo pointer. > > I guess the following patch should fix this. > > Bug has been there forever, but only BPF_CGROUP_RUN_PROG_INET_SOCK(sk) could trigger it. > Official submission : https://patchwork.ozlabs.org/project/netdev/patch/20200529180838.107255-1-edumazet@google.com/