Received: by 2002:a25:ef43:0:0:0:0:0 with SMTP id w3csp769333ybm; Fri, 29 May 2020 11:39:42 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxl7L2E+pOpcrl4HYR3jMFCuzwaYCkq5VQHZ5y+VQuwJ1zKPz8XbZHz3lmczjkZvo6h/qAt X-Received: by 2002:a05:6402:b0b:: with SMTP id bm11mr9954768edb.92.1590777582154; Fri, 29 May 2020 11:39:42 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1590777582; cv=none; d=google.com; s=arc-20160816; b=N/odks3rwWNDiK43nnkB81Kq4Pgle081bFMYJwZq26kGKBDNgvzHcgq2HRdCm5r2D5 /tOoJ9Jhp4b5olI9ENidnizv0ePCKQNhogMRKZUh+yGTGlqlP33n5w1ToSo35vLWPJMd GldSqjI3evcaKPpP/S/fDw4VvgVbyzecAnPGcQY+aqML70SZDfHzdcd9X8gIl0U6PzBs oBaXRDTLO7rYWDWaU8USRCJT5Wm2JpLoe/cSghRC6baXTn9TLva/QgEMAahDkkQ5p3Ad NLf/Ycstz77uScM3YAIDjOGb1vjCXIUsHUueKNJwRsTU9aaXC6HVt2z/hFn1VFPOWS+R g1mQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=OYQE0uvH3tzzpfHPwyVCPWLLHigSCaMjFXiFc2z8a/4=; b=pqbKFLfJJQh1YC56wDBr1qJ0MphI2/58w+USL8D/scr4pbe4Sm5V/1CRp6DGYL8FwQ XzMPdTY9nFyo0hlIB1QkJXeqPO+VxZKMzHFG4wpUUbzRSuo/po5aNh5oZOrGJTI+8tGr SGwUboK2J0YYu8SdV2AF8aW03xf+ghfluJZDCdgKvL7L5Llsb7Yr9M/qgU4KrJ4HqPao N9OIHXPDiZapuB2JljTdBTEe72dU2M6fjZjG5HCI5ROZyV2IVkIpV9dwsyVoXLnRWbkb TbQz4dYjwgMTDB/8vNN4ws+3hYrtmgjMbPe7ccyy3tswgIoLfF6ryHQu+yW1/qwkVzwI JsZQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@ziepe.ca header.s=google header.b=ES2TDPWT; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id b1si6295391edq.592.2020.05.29.11.39.18; Fri, 29 May 2020 11:39:42 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@ziepe.ca header.s=google header.b=ES2TDPWT; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727816AbgE2ShM (ORCPT + 99 others); Fri, 29 May 2020 14:37:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51062 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727094AbgE2ShK (ORCPT ); Fri, 29 May 2020 14:37:10 -0400 Received: from mail-qt1-x842.google.com (mail-qt1-x842.google.com [IPv6:2607:f8b0:4864:20::842]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 287CDC03E969 for ; Fri, 29 May 2020 11:37:10 -0700 (PDT) Received: by mail-qt1-x842.google.com with SMTP id b11so2780398qtt.3 for ; Fri, 29 May 2020 11:37:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=OYQE0uvH3tzzpfHPwyVCPWLLHigSCaMjFXiFc2z8a/4=; b=ES2TDPWTNdU2r1JEiOfpkLv5famr8ht6/yykg49rfGIaayQnwia8ipnSs67ynZWTis PfZmkwimbmHtCKI74EPGH0DHKXgoOJ9bw9GMaZ5BsCfuGvKpPNKPZiDuEKjv7OHCNIcf h2n8g2bsztSlfNLV7Muc2JYi8hn2130s2YE6FlXMlBCozUABf5MIp1UOYH8dIqqaCgMj Tcvhngp0IcGEAVu5UPNihKvSk3Odb6RHhe6W8vaEHc7o2O50zrmxoeG+N0yUU6r4Kpa0 kMgjnFr5K+bNcgZ64zLDAGYtj5NAO5iRE76dgN2RLghDo5o3ZSSoVJ9zK4Z8SomMFMK2 X6bA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=OYQE0uvH3tzzpfHPwyVCPWLLHigSCaMjFXiFc2z8a/4=; b=O+ptaPDFbC4sN6DaOb4U3H4p1WwLlEWJWzcCT4YYUIYnins2xymHiUsmCPcbVNDlyQ n9Msg6m+rCrwfaioZKf6GRhZVubgeevrOb08i1NqU2e7yJ3/BzyLF2fKSDP2i0O+4cOF qk+jhr3XAI4vDSbp3bO5qT7CW+n4w/uZHfQugAju+TraXrk+mxgUItKR4oB9m34ITqH2 BNvSWdOGCVnoaW+WTD8bJJVEIXO5tDCxXx97hg2nB+3dFSgiDZ2bdqXXcQqSrI75roT4 CZQ/7MycDSieX2tPXmMeWIDMbK+NtqkbZ75fEbQsq6H2U6BID0XaQu4eaLry+DmwM3aW pDPw== X-Gm-Message-State: AOAM533fi7LcRLQb+12A91y6M+Yxl6z0ijWZk7erIKuf25HIYkh/vDpB PvLuWvF34Cj3wQPthY0H4oigVA== X-Received: by 2002:ac8:7383:: with SMTP id t3mr10938438qtp.221.1590777429365; Fri, 29 May 2020 11:37:09 -0700 (PDT) Received: from ziepe.ca (hlfxns017vw-156-34-48-30.dhcp-dynamic.fibreop.ns.bellaliant.net. [156.34.48.30]) by smtp.gmail.com with ESMTPSA id a27sm8731357qtc.92.2020.05.29.11.37.08 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Fri, 29 May 2020 11:37:08 -0700 (PDT) Received: from jgg by mlx.ziepe.ca with local (Exim 4.90_1) (envelope-from ) id 1jejsS-0006aK-Bo; Fri, 29 May 2020 15:37:08 -0300 Date: Fri, 29 May 2020 15:37:08 -0300 From: Jason Gunthorpe To: wu000273@umn.edu Cc: kjlu@umn.edu, Doug Ledford , Leon Romanovsky , Kamal Heib , Mark Zhang , Majd Dibbiny , linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] RDMA/core: Fix several reference count leaks. Message-ID: <20200529183708.GA25212@ziepe.ca> References: <20200528030231.9082-1-wu000273@umn.edu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200528030231.9082-1-wu000273@umn.edu> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 27, 2020 at 10:02:30PM -0500, wu000273@umn.edu wrote: > From: Qiushi Wu > > kobject_init_and_add() takes reference even when it fails. > If this function returns an error, kobject_put() must be called to > properly clean up the memory associated with the object. Previous > commit "b8eb718348b8" fixed a similar problem. > > Signed-off-by: Qiushi Wu > --- > drivers/infiniband/core/sysfs.c | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) Applied to for-next, thanks Jason