Received: by 2002:a25:ef43:0:0:0:0:0 with SMTP id w3csp797290ybm; Fri, 29 May 2020 12:23:29 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz+V+RfZYGOK0k4M1Jo/9M59Rn3gq9qNEtPNntv4+CSq+itlxOPT6BHIVc+wfdKoOWEOv5z X-Received: by 2002:a05:6402:144e:: with SMTP id d14mr8642286edx.14.1590780209330; Fri, 29 May 2020 12:23:29 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1590780209; cv=none; d=google.com; s=arc-20160816; b=wv6zaUXkFhWoAvIFkYwbvjDGcHW1JMNYpdsRAmQY7tB/uEOUjuDArxLFBJDOGrcQOl 7pC+FFe9eaxw6B5GBz4XxdG0XGvBtBHCRcqECUeNorecZmfFAemovTvA5aNAY/gUQfP9 bdYgpVop2pPedfdDgwYNQrdpeocYPprxAPPrDbGNxG+1VafV8I57qa+ethy+9YAL8Fiu IyGK6TqH9wqTvCOiDuTx+GrMRXwoVf09Vtwn8Yz4CU1n2Jlf2Pmm9PnCVLfl1hy+S41x BfXd4tpB9huCAr3gEcQTcog71n8Opyam+/N9lRle9fn1CCNWNM0RgT5MrfUJH7jhXayq waVw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=YeA5iCMq4Q45XEVIPZ2h0YGug+0ZxjI3FXW/lltnCmA=; b=GRFV7wqHO03/pC5mpObCkuh8xqNHhj2JJGEg8b922e0buyLUVWI9X+G9fAWuhN+udt uIL+jw/khwIi5HEwwYBXN4ZMwkBtbv3aSqSxQy9C8gwgeZ+7EPb2dQmxPvbUaf+5VRj4 OXVX5WJo2YJkoqXMjA58qcyF9Li7GAr4tw+VnBY6AB8px+Jp2cDgt2sgVnMmvUXkDuM5 hJoF3X4ZNFnN4fQO1byzMwr0ECoIAL81LsgYSKJ9SyFphvr7q3e5fn71G2fG5Zx4L83m iqasKGDFtz9eHK+PWx7ejRhKRWuLtAA6Xw9ScbtYJYbkphCVZXBaG6YfEIz8ziVG1BH5 XdHA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=YNPdyVh2; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id i12si3629098edq.423.2020.05.29.12.23.06; Fri, 29 May 2020 12:23:29 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=YNPdyVh2; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728160AbgE2TSP (ORCPT + 99 others); Fri, 29 May 2020 15:18:15 -0400 Received: from mail.kernel.org ([198.145.29.99]:52400 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726549AbgE2TSO (ORCPT ); Fri, 29 May 2020 15:18:14 -0400 Received: from kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net (unknown [163.114.132.4]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 861D5207D4; Fri, 29 May 2020 19:18:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1590779893; bh=vgDSnI+7ypiz1z9yX8VrOTh1GkbhLJZZTXgp3PCi0UI=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=YNPdyVh2Rx2tMjeDs1WK7/snMQoVXCURWHb8cV872kD8ltBKQUnSNAxdNc1BUn/u7 W3b2JRZ4+HCLkA+9PiVV1Fhy7VNz2Jd8vQJ94A8N/cbhPGZDeun1sjI0zEo8skGaMz yjzqX95r3intpixgnk5qydDy+Q1ttwO2e7UekyhY= Date: Fri, 29 May 2020 12:18:11 -0700 From: Jakub Kicinski To: Horatiu Vultur Cc: , , , , , , , , Subject: Re: [PATCH net-next 2/2] bridge: mrp: Add support for role MRA Message-ID: <20200529121811.583003cc@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net> In-Reply-To: <20200529100514.920537-3-horatiu.vultur@microchip.com> References: <20200529100514.920537-1-horatiu.vultur@microchip.com> <20200529100514.920537-3-horatiu.vultur@microchip.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 29 May 2020 10:05:14 +0000 Horatiu Vultur wrote: > A node that has the MRA role, it can behave as MRM or MRC. > > Initially it starts as MRM and sends MRP_Test frames on both ring ports. > If it detects that there are MRP_Test send by another MRM, then it > checks if these frames have a lower priority than itself. In this case > it would send MRP_Nack frames to notify the other node that it needs to > stop sending MRP_Test frames. > If it receives a MRP_Nack frame then it stops sending MRP_Test frames > and starts to behave as a MRC but it would continue to monitor the > MRP_Test frames send by MRM. If at a point the MRM stops to send > MRP_Test frames it would get the MRM role and start to send MRP_Test > frames. > > Signed-off-by: Horatiu Vultur net/bridge/br_mrp.c:542:20: warning: cast to restricted __be16 net/bridge/br_mrp.c:542:20: warning: cast to restricted __be16 net/bridge/br_mrp.c:542:20: warning: cast to restricted __be16 net/bridge/br_mrp.c:542:20: warning: cast to restricted __be16