Received: by 2002:a25:ef43:0:0:0:0:0 with SMTP id w3csp972111ybm; Fri, 29 May 2020 17:17:49 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxMySOVxvRmwCfBJt/+6Aqit89FWY2GApJ78zTR/1yVigLFzTBzNHvDUtrFzPtesIf/nJfO X-Received: by 2002:aa7:c607:: with SMTP id h7mr11156384edq.214.1590797869373; Fri, 29 May 2020 17:17:49 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1590797869; cv=none; d=google.com; s=arc-20160816; b=A85gymbwJz4dYwALBJHgVH/rCSUBS/TUznNw1c4nUrRbPv1E5n6wMkyfgBaFP4mxIF AXQH/Ju/ijxEkUT13TwiRyq/kAu49FiH9twvIAu2lYI0KxhW2nuYTA23jiYzoTkNHaJX U+zZIQpSLbw4R/mxmu9YPyRpdc9tRj1ZJjDCl3hGLi1qLbbUjo6ohs0RR01FNx40OiUx HLHL6ltkERF80/4DqQnEHrJob4WrwTtAa+O1t53al+MVaZLMI+zJiIe/Iy1NH+8rm5CE l/c3cz7xJVu0oCfzc3GmZR77XPhwQb8WU2RY0S0mQsH59wf2VlXaLbefcLk5bTiLO7Mz Zjhw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date; bh=1afsRqCuC/GR8kdLMmR+3kAAWNXdlw3S29EWGHFAs3g=; b=XxmiDxSBbMMy5hrxqMrJJP6AH9PzNjM6LSwBb4UUtgSpGyZ1z8Z1YMNnQ6Y8DH6lov tBaQwzGYOqKRE1fXEpRO9SEcj0WHPFYQQL/FmrHnVSsgJywGP4gGOKcsGnhMjWHg9bX+ ewm+wcMTkxml0vBpzTrWVkz/GqgW7ppK21/HjZUzo7IaZvH5vHYVuZhV99tOIKyAekhi h+Rib72ILml9r/+5LHidRcwnkHsrkPfgmqUiRStOM9MZ4m6Xx0k2yKwrvrT/1CbRlmKo pGeJE1epMEBkY13UGyydqQIQlu1NpmQNAdEuMenZz6Ao0eTGB4/h5DKbGlBN50q/2DKw pb6w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id s1si1482057edw.362.2020.05.29.17.17.23; Fri, 29 May 2020 17:17:49 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728598AbgE3APY (ORCPT + 99 others); Fri, 29 May 2020 20:15:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47452 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726898AbgE3APY (ORCPT ); Fri, 29 May 2020 20:15:24 -0400 Received: from shards.monkeyblade.net (shards.monkeyblade.net [IPv6:2620:137:e000::1:9]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E2890C03E969; Fri, 29 May 2020 17:15:23 -0700 (PDT) Received: from localhost (unknown [IPv6:2601:601:9f00:477::3d5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id AA5AC12875128; Fri, 29 May 2020 17:15:22 -0700 (PDT) Date: Fri, 29 May 2020 17:15:21 -0700 (PDT) Message-Id: <20200529.171521.699478164991447623.davem@davemloft.net> To: colin.king@canonical.com Cc: dsahern@kernel.org, kuznet@ms2.inr.ac.ru, yoshfuji@linux-ipv6.org, kuba@kernel.org, netdev@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH][net-next] nexthop: fix incorrect allocation failure on nhg->spare From: David Miller In-Reply-To: <20200528145114.420100-1-colin.king@canonical.com> References: <20200528145114.420100-1-colin.king@canonical.com> X-Mailer: Mew version 6.8 on Emacs 26.3 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Fri, 29 May 2020 17:15:23 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Colin King Date: Thu, 28 May 2020 15:51:14 +0100 > @@ -1185,7 +1185,7 @@ static struct nexthop *nexthop_create_group(struct net *net, > > /* spare group used for removals */ > nhg->spare = nexthop_grp_alloc(num_nh); I don't even see this line in the current net-next tree nor any references to ->spare. What am I missing?